Repository navigation
test(tempo): fold configurable account tests into the main tempo suite - #610
Merged
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Codex Review Summary: ✅ CompletedThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
Contributor
|
Published pnpm add ox@pr-610
pnpm add ox@0.0.0-pr-610-2c6d429 |
This branch had an error being deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Configurable accounts (T14) are on Tempo main, and the
edgeimage's dev genesis activates T14, so the configurable account e2e tests no longer need their own node.src/tempo/configurableAccounts.e2e.test.tsin thetempoproject against the default server.tempo-configurable-accountsproject, its branch image (sha-179347b), the custom genesis and global setup, and the now-unusedcreateServeroptions.test-tempo-multisigCI job:test-tempocovers these tests.invalid transaction signature, so the insufficient-approvals test now asserts that.Verified locally:
pnpm test --project tempo-unit --project tempopasses (25 files, 752 tests), andpnpm checkandpnpm check:typespass.