Skip to content

feat(xattr): add completion spec - #2659

Open
ump45nose wants to merge 1 commit into
withfig:masterfrom
ump45nose:feat-xattr-spec
Open

ump45nose wants to merge 1 commit into
withfig:masterfrom
ump45nose:feat-xattr-spec

Conversation

@ump45nose

Copy link
Copy Markdown

Description

Adds a new completion spec for macOS xattr, which currently has no spec.

The spec covers all five documented command forms through the mode options (-p, -w, -d, -c) with their required arguments (attr_name / attr_value), plus the shared flags -l, -r, -s, -v, -x and -h/--help. File arguments use the filepaths template, and attr_name suggestions include common macOS extended attributes (quarantine, FinderInfo, ResourceFork, kMDItemWhereFroms, provenance).

Closes #941

How Has This Been Tested?

  • npx prettier --check src/xattr.ts --parser typescript passes
  • npx eslint src/xattr.ts passes (fig-linter clean)
  • npx tsc --noEmit: no diagnostics for src/xattr.ts (two pre-existing upstream errors in src/tldr.ts and src/z.ts are unrelated)
  • Flags and the five command forms verified against the local macOS xattr -h output and man xattr on macOS 26

@withfig-bot

Copy link
Copy Markdown
Contributor


Thank you for your submission, we really appreciate it. Like many open-source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution. You can sign the CLA by just posting a Pull Request Comment same as the below format.


I have read the CLA Document and I hereby sign the CLA


You can retrigger this bot by commenting recheck in this Pull Request. Posted by the CLA Assistant Lite bot.

@withfig-bot

Copy link
Copy Markdown
Contributor

Overview

src/xattr.ts:

Info:

@withfig-bot

Copy link
Copy Markdown
Contributor

Hello @ump45nose,
thank you very much for creating a Pull Request!
Here is a small checklist to get this PR merged as quickly as possible:

  • Do all subcommands / options which take arguments include the args property (args: {})?
  • Are all options modular? E.g. -a -u -x instead of -aux
  • Have all other checks passed?

Please add a 👍 as a reaction to this comment to show that you read this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[xattr] missing spec

2 participants