Repository navigation
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## dev #770 +/- ##
==========================================
- Coverage 99.58% 99.00% -0.58%
==========================================
Files 64 63 -1
Lines 4331 4540 +209
==========================================
+ Hits 4313 4495 +182
- Misses 18 45 +27 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Contributor
Author
|
Ah, there's a fatal problem with this approach... |
Contributor
Author
|
That being said, we will need to come up with a solution to |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is an alternative approach to ASH auto-ACKing.
Our current approach of using a second thread for the event loop is unfortunately flawed: when the main thread has GC stutters, so does the gateway thread. This can get bad enough to still trigger ASH resets. We can use a subinterpreter (3.14+) or subprocess as a parallelism mechanism that is more isolated than a thread.
It's comparable to threading for all of the happy paths.
send_datawith NCP ACK over TCP, p50send_datawith NCP ACK over TCP, p99GC storm: 3 million object heap in the main interpreter,
gc.collect()every 0.5 s, each collection ~180 ms.Related: #753
Related: #766
Related: #735