[youdie006]

• The PR title must conform to Conventional Commits and start with one of the types specified by the Angular convention.

#1002 split out parse_central_header, which reads the modification time only when the field is exactly 4 bytes after the flags and reads nothing otherwise. ExtraFields::parse walks one cursor across all fields, so a central 0x5455 field of length 9 or 13 leaves 8 or 12 bytes that are read as the next field's header. Such fields come from any writer that copies the local field into the central directory, including this crate:

let mut o = FullFileOptions::default();
o.add_extra_data(0x5455, &[0x03, 0x00, 0xF1, 0x53, 0x65, 0x01, 0xF1, 0x53, 0x65], false)?;
// start_file, write, finish, then ZipArchive::new on the result:
// master:   Err(invalid Zip archive: Extra field content truncated)
// b5634497~1 and this PR: opens, mod_time == Some(1700000000)

An archive written by Python's zipfile with the same field fails the same way. This reads the modification time when there are at least 4 bytes and skips the rest, as parse_local_header already does with the same comment. The regression is not in a release yet (latest is 9.0.0-pre3).

One behaviour to note: before #1002 a length-9 central field also reported accessed; after this it reports None, as #1002 intended for the central header.

Verification

Base c5e58bcc. New case in the existing test_extended_timestamp_in_central_header.

row	extended_timestamp.rs md5	result
master	8ba15635	new case fails: mod_time is None
this PR	ab90196a	passes
without the skip	add3d132	fails: cursor at 5, not 9
== instead of >=	b2c57928	fails on mod_time
> instead of >=	32f50a48	fails #1002's own length-5 case

On stable: cargo fmt --all -- --check; cargo clippy --all-targets -- -D warnings with --no-default-features, default and --all-features; cargo test --all with each of the three (35 result blocks each, 0 failed); cargo doc --no-deps with default and --all-features. On 1.88 (MSRV): cargo build with --no-default-features and default. cargo doc --no-default-features reports two unresolved intra-doc links to CompressionMethod::Bzip2 and ::Deflated, identical on master. Not run: nightly, Windows and macOS, Miri, wasm and the fuzz job.

Written with AI assistance (Claude); the measurements above were run locally and I have reviewed the change.

[Copilot]

Copilot review overview

🟢 Approval recommended

The parsing fix and regression coverage are complete with no unresolved blocking issues.

Review effort: Lite
Findings: None

What changed in this PR

Fixes central-directory extended timestamp parsing to consume the complete field while preserving the modification time.

Changes:

• Reads timestamps from fields at least four bytes long.
• Skips trailing bytes to preserve parser alignment.
• Adds regression coverage for extended fields.

File	Description
src/​extra_fields/​extended_timestamp.rs	Fixes central-header parsing and adds regression tests.

---

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

[Copilot]

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

[Copilot]

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

[Its-Just-Nans]

Thanks!