Repository navigation
Conversation
The latter will be deleted in the next commit.
…lm5_0, and clm5_1.
Avoids issue with undefined pointer to crop_inst%rx_swindow_starts_thisyr_patch and probably other arrays.
Instead of just :. Hopefully will eliminate too-high index errors in threading tests.
Hopefully will eliminate too-high index errors in threading tests.
…-default to crop_calendars suite.
Hopefully will eliminate too-high index errors in threading tests.
Hopefully will eliminate too-high index errors in threading tests.
samsrabin
marked this pull request as ready for review
July 26, 2024 15:21
slevis-lmwg
approved these changes
Jul 26, 2024
slevis-lmwg
left a comment
Contributor
There was a problem hiding this comment.
@samsrabin I have reviewed this PR and see no problems with it. If I understand correctly, this work sets the stage for bringing in #2593, which we discussed at length a few days ago, right?
Thank you for all this work!
Member
Author
Yes, but not just that! Here's the full list of PRs that have been merged into this development branch before this one: |
- Was: ERS_D.f19_g17.I1850Clm50BgcCrop.izumi_nag.clm-ciso_monthly_matrixcn_spinup - Now: ERS_D.f10_f10_mg37.I1850Clm50BgcCrop.izumi_nag.clm-ciso_monthly_matrixcn_spinup Fixes ESCOMP#2667: Change out a f19 resolution test on Izumi for f10 (ESCOMP#2667)
Contributor
|
Tests on Derecho are still going, but merging this to the branch now. We'll work out the tests for the PR to master. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of changes
Enables
cropcals_rx_adaptby default for clm60.Specific notes
Contributors other than yourself, if any: @slevis-lmwg
Are answers expected to change (and if so in what way)? Yes. Relative to
ctsm5.2.015:croptestmod will have answers change due to more frequent writing of the h2 file. Note that this only affects tests.Any User Interface Changes (namelist or namelist defaults changes)?
cropcals_rx, default false.cropcals_rx_adapt, default true. This is what changes default behavior.stream_year_first_cropcaltostream_year_first_cropcal_swindowsstream_year_last_cropcaltostream_year_last_cropcal_swindowsmodel_year_align_cropcaltomodel_year_align_cropcal_swindowsstream_year_first_cropcal_cultivar_gddsstream_year_last_cropcal_cultivar_gddsmodel_year_align_cropcal_cultivar_gddsstream_fldFileName_gdd20_baselinestream_gdd20_seasons(experimental)flush_gdd20(experimental)stream_fldFileName_gdd20_season_start(experimental)stream_fldFileName_gdd20_season_end(experimental)allow_invalid_gdd20_season_inputsDoes this create a need to change or add documentation? Did you do so?
Testing performed
aux_clmcompared toctsm5.2.015:ctsm5.2.016_cropcals) at 542f708: 10 run failures. Resubmitted those 10 after changes in 126ce29..2156c72 (/glade/derecho/scratch/samrabin/tests_0726-084119de/)...ctsm5.2.016) at 542f708Rerunning both after bug fixes (b1aed3f), comparing to baselines generated above, skipping generate (all should PASS except expected failures):
/glade/derecho/scratch/samrabin/tests_0726-091635de//scratch/cluster/samrabin/tests_0726-091602iz/,/scratch/cluster/samrabin/tests_0726-122439izI used the wrong
--comparefor that latest Derecho test suite, so it will have to be checked manually:Python tests (unit, system,
black,pylint)✅ pass as of 2156c72.
Namelist build tests
🆗. 4 fail; see #2666.