Repository navigation
Merge new crop calendars into master - #2665
Merged
Merged
Conversation
Avoids issue with undefined pointer to crop_inst%rx_swindow_starts_thisyr_patch and probably other arrays.
Instead of just :. Hopefully will eliminate too-high index errors in threading tests.
Hopefully will eliminate too-high index errors in threading tests.
…-default to crop_calendars suite.
Hopefully will eliminate too-high index errors in threading tests.
Hopefully will eliminate too-high index errors in threading tests.
Merge ctsm5.2.015 into scale-maturity-reqs
Enable new crop calendars for clm60 compsets
Contributor
|
@slevis-lmwg and I met about finishing this out. We confirmed Izumi tests are as expected and finished. Tests on Derecho are still going. Ill check on them tomorrow, and make sure they are all good, and resubmit anything needed if there's a couple fails because of a glitch so that we have good baselines. So I expect to finish the tag for this tomorrow. |
ekluzek
approved these changes
Jul 28, 2024
ekluzek
left a comment
Contributor
There was a problem hiding this comment.
This is awesome to see coming in. So glad to see it come in by the chill deadline.
I noticed a couple things that I made issues for or added to issues.
Contributor
|
Testing finished on Derecho and looks good. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of changes
#2664 is the last PR on the
scale-maturity-reqsbranch. After that's done, this one will merge that branch into master. No changes should be necessary. See that PR for details.