Skip to content

Clm60 finidat updates for ne30, f09, f19 grids - #2821

Merged
slevis-lmwg merged 13 commits into
ESCOMP:masterfrom
slevis-lmwg:ne30_f09_f19_IC
Oct 14, 2024
Merged

slevis-lmwg merged 13 commits into
ESCOMP:masterfrom
slevis-lmwg:ne30_f09_f19_IC

Conversation

@slevis-lmwg

@slevis-lmwg slevis-lmwg commented Oct 8, 2024 •

Copy link
Copy Markdown
Contributor

Description of changes

finidat updates needed for cesm's beta04 tag.

Specific notes

Contributors other than yourself, if any:
@ekluzek @olyson

CTSM Issues Fixed (include github issue #):
Relates to #2403 (I'm not confident that this fully resolves it though)

Are answers expected to change (and if so in what way)?
Yes, for clm6 ne30, f09, f19 cases, because pointing to new finidat files.

Any User Interface Changes (namelist or namelist defaults changes)?
Updated namelist_defaults with new finidat files.

Does this create a need to change or add documentation? Did you do so?
No but reminder to

  • Update the ChangeLog about testing and about other contributors.

Testing performed, if any:
izumi ./run_sys_tests -s aux_clm -c ctsm5.3.003 --skip-generate
Compared to 003 because 004 was not available.
004 would differ from 003 only for the hillslope test, which is a clm6 test, so I expect it to differ already due to my mods.
So then, expected due my mods:
New FAILs for clm6 tests in the NLCOMP phase (due to namelist changes) and the BASELINE phase (due to changing answers).

@slevis-lmwg slevis-lmwg self-assigned this Oct 8, 2024
@slevis-lmwg slevis-lmwg added the priority: Immediate Highest priority, something that was unexpected label Oct 8, 2024
@slevis-lmwg

slevis-lmwg commented Oct 8, 2024 •

Copy link
Copy Markdown
Contributor Author

./rimport-ing the following files:

lnd/clm2/initdata_esmf/ctsm5.3/ctsm530_f19_PPE_pSASU.clm2.r.0161-01-01-00000.nc
lnd/clm2/initdata_esmf/ctsm5.3/ctsm53n04ctsm52028_f09_hist.clm2.r.1979-01-01-00000.nc
lnd/clm2/initdata_esmf/ctsm5.3/ctsm53n04ctsm52028_f09_hist.clm2.r.2000-01-01-00000.nc
lnd/clm2/initdata_esmf/ctsm5.3/ctsm53n04ctsm52028_f09_pSASU.clm2.r.0161-01-01-00000.nc
lnd/clm2/initdata_esmf/ctsm5.3/ctsm53n04ctsm52028_ne30pg3t232_hist.clm2.r.1979-01-01-00000.nc
lnd/clm2/initdata_esmf/ctsm5.3/ctsm53n04ctsm52028_ne30pg3t232_hist.clm2.r.2000-01-01-00000.nc
lnd/clm2/initdata_esmf/ctsm5.3/ctsm53n04ctsm52028_ne30pg3t232_pSASU.clm2.r.0121-01-01-00000.nc

@slevis-lmwg

This comment was marked as resolved.

@slevis-lmwg

This comment was marked as resolved.

@samsrabin

This comment was marked as resolved.

@samsrabin

This comment was marked as resolved.

@slevis-lmwg

Copy link
Copy Markdown
Contributor Author

Latest tests on derecho
PASS ./run_ctsm_py_tests -u and ./run_ctsm_py_tests -s
PASS ./build-namelist_test.pl

@ekluzek ekluzek left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some of the settings for init_interp_attributes and finidat attributes look wrong to me. So we should make sure we've got this right.

@ekluzek

ekluzek commented Oct 10, 2024 •

Copy link
Copy Markdown
Contributor

@slevis-lmwg and I went over this, and figured out what we thought was correct for one of the cases, and he'll do the same changes for the other cases and test standard cases to make sure they get the right files. I'll look it over again and approve. And then I'll do some more namelist testing to make sure it's correct with the build-namelist tester and compare_namelists. Then Sam will proceed forward with updating to the b4b-dev tag and running aux_clm.

So checkboxes...

  • Sam updates the other cases and makes sure the new initial condition files are applied correctly (also run all those SMS tests to make sure they do run)
  • Sam pings Erik that it's ready to re-review
  • Erik approves
  • Erik does more build-namelist compare_namelist testing to make sure the special cases are correct (Likely DONE, but I'm not sure, so I removed the checkbox to proceed with the merge)
  • Sam updates to ctsm5.3.006
  • Sam runs aux_clm testing, resolves issues if any
  • Sam completes the tag as normal

@slevis-lmwg

Copy link
Copy Markdown
Contributor Author

Manual testing

SMS.ne30pg3_t232.I1850Clm60BgcCrop.derecho_intel.clm-clm60cam7LndTuningMode
SMS.f19_g17.I1850Clm60BgcCrop.derecho_intel.clm-clm60cam7LndTuningMode
SMS.f09_g17.I1850Clm60BgcCrop.derecho_intel.clm-clm60cam7LndTuningMode

SMS.ne30pg3_t232.I2000Clm60BgcCrop.derecho_intel.clm-clm60cam7LndTuningMode
SMS.f19_g17.I2000Clm60BgcCrop.derecho_intel.clm-clm60cam7LndTuningMode
SMS.f09_g17.I2000Clm60BgcCrop.derecho_intel.clm-clm60cam7LndTuningMode

SMS_Ln9.ne30pg3_t232.IHistClm60Sp.derecho_intel.clm-clm60cam7LndTuningMode_1979Start

@ekluzek the first five tests worked, BUT

  • The first two 1850 and 2000 tests (so ne30 and f19) still had use_init_interp = .true., probably hardwired from somewhere else...
  • The 6th test failed in the RUN phase stating that it needed use_init_interp = .true., so I put it back for that one.
  • The 7th test (1979) picks up the 2000 finidat (instead of 1979) no matter what I try.
    Here I also tried f09 and it worked. Matching the ne30 settings to the f09 settings didn't get ne30 to work for me. I will book a time for us to discuss in the morning.

@samsrabin samsrabin added this to the cesm3_0_beta04 milestone Oct 11, 2024
…, handle 1979 finidat settings consistently for f09, f19, and ne30pg3
@slevis-lmwg

slevis-lmwg commented Oct 12, 2024 •

Copy link
Copy Markdown
Contributor Author

I pulled the latest commit and submitted
PASS ./build-namelist_test.pl on derecho
PASS python testing on derecho
./run_sys_tests -s aux_clm -c ctsm5.3.006 -g ctsm5.3.007 on izumi and derecho

  • OK izumi ./cs.status.fails | grep -v NLCOMP | grep -v DIFF | grep -v PASS
    Resubmitted false failures, including one manual resubmission:
    ./create_test PEM_Ld1.f10_f10_mg37.I2000Clm60BgcCrop.izumi_intel.clm-till--clm-matrixcnOn -c /fs/cgd/csm/ccsm_baselines/ctsm5.3.006 -g /fs/cgd/csm/ccsm_baselines/ctsm5.3.007
  • OK derecho

@slevis-lmwg
slevis-lmwg requested a review from ekluzek October 13, 2024 22:10
@slevis-lmwg
slevis-lmwg merged commit 6d8dad8 into ESCOMP:master Oct 14, 2024
@slevis-lmwg
slevis-lmwg deleted the ne30_f09_f19_IC branch October 14, 2024 17:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

priority: Immediate Highest priority, something that was unexpected

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants