Repository navigation
ctsm5.4.036: Complete the FATES-CLM nitrogen coupling - #3409
Conversation
PASS ERS_D_Ld30.1x1_brazil.I2000Clm60FatesCrujraRs.derecho_intel.clm-FatesColdPRT2 FAIL ERS_D_Ld30.1x1_brazil.I2000Clm60FatesCrujraRs.derecho_intel.clm-FatesColdPRT2--clm-mimicsFatesCold--clm-nofireemis The latter needs "nofireemis" to work with Fates, but it then dumps core in line 1180 SoilBiogeochemDecompCascadeMIMICSMod.F90
...calculating these variables: nf_soil%decomp_npools_sourcesink_col nf_soil%fates_litter_flux
|
With the latest commit, I repeated the two earlier tests and added another to check whether answers have changed from the baseline: The latter fails in case2, after reading the restart file, with a N balance error. UPDATE
|
|
Enabled fixation and ran the same tests: PRT2 still b4b with the baseline. PASS The same tests with the code change for harvest (same results relative to the baseline). |
|
Worked on the next checkbox in the issue (#3378), submitted the same tests, and after some troubleshooting: |
These variables originate in fates, so this renaming requires the same renaming in fates; I will open the corresponding PR very soon
Notes:
|
|
Updated the fates paramfile (see next commit) and submitted these two again The first (LUH2) same as before (DIFF from baseline) since nothing changed for it.
|
|
Hi @ekluzek thanks for this. I just wanted to say that this code does not intersect with LUNA, as Vcmax is an input oarameter in FATES and so we don't for now handle any of the acclimation processes that LUNA predicts. This also goes for FUN and the 'Flex-CN' (I'm unsure if we still call it that) functionality. |
|
Note to self: Open new documentation issues to update Technote and User's Guide. |
This comment was marked as resolved.
This comment was marked as resolved.
bug fix to the FATES land use driver input code This PR includes a cherry-picked fix from NorESMhub#209 to address swap in the order of rangeland and pasture in the reading of the landuse drivers slevis resolved conflicts: src/fates
samsrabin
left a comment
There was a problem hiding this comment.
Looks great! Just some minor things agreeing with Erik.
|
Complete the FATES-CLM nitrogen coupling PR ESCOMP#3409. Description: Intoduce code, namelist option, and tests on the CLM side to accommodate interactive nitrogen with FATES. Roundoff changes for most cases, though not for Sp and FatesSp. The FATES side PR is NGEET/fates#1472. Fates got updated from sci.1.92.1_api.44.1.0 to sci.1.92.4_api.45.0.0. Supporting information (other than in the issue referenced below): - Nutrient enabled FATES handbook: https://docs.google.com/document/d/1I35fGDfKTkn9_8Z6qXot7HZf3ICSpLONd-iFEErAh0k/edit?usp=drive_link - FATES CLM N coupling: https://docs.google.com/document/d/1mpBtpCLGJpAGw6R3-nGGY92IWRU3ISvaAUKxvcDVJRw/edit?usp=drive_link Resolves issue ESCOMP#3378.
Complete the FATES-CLM nitrogen coupling on the FATES side PR NGEET#1472 PR not yet merged on the CLM side: ESCOMP/CTSM#3409 Issue ESCOMP/CTSM#3378
Description of changes
For now see the issue #3378
Corresponding mods on the FATES side:
NGEET/fates#1472
Nutrient enabled FATES handbook
FATES CLM N coupling
Specific notes
Contributors other than yourself, if any:
@rgknox @adrifoster @wwieder
CTSM Issues Fixed (include github issue #):
#3378
Are answers expected to change (and if so in what way)?
For non-fates tests expect roundoff diffs due to a change in the order of operations in CNNDynamicsMod.F90 as documented below.
Any User Interface Changes (namelist or namelist defaults changes)?
Yes, see changes to CLMBuildNamelist and namelistdefaults.
Does this create a need to change or add documentation? Did you do so?
Yes, no.
Initial testing performed
...with the first two commits in this PR:
Later comments point out that these two tests were inadequate at catching problems, and that I switched to two other tests.