Repository navigation
Landuse driver bugfix - #209
Closed
rosiealice wants to merge 2 commits into
Closed
rosiealice wants to merge 2 commits into
rosiealice wants to merge 2 commits into
Conversation
slevis-lmwg
added a commit
to slevis-lmwg/ctsm
that referenced
this pull request
Apr 23, 2026
bug fix to the FATES land use driver input code This PR includes a cherry-picked fix from NorESMhub#209 to address swap in the order of rangeland and pasture in the reading of the landuse drivers slevis resolved conflicts: src/fates
samsrabin
added a commit
to samsrabin/CTSM
that referenced
this pull request
Apr 24, 2026
bug fix to the FATES land use driver input code This PR includes a cherry-picked fix from NorESMhub#209 to address swap in the order of rangeland and pasture in the reading of the landuse drivers
ekluzek
added a commit
to ESCOMP/CTSM
that referenced
this pull request
Apr 27, 2026
bug fix to the FATES land use driver input code This PR includes a cherry-picked fix from NorESMhub#209 to address swap in the order of rangeland and pasture in the reading of the landuse drivers
Collaborator
|
Fixed with #212 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of changes
As discussed in #205, adding the LUPF dimension illustrated that there was some erroneous ENT in the pasture land, which further lead to the realization that there was a swop in the order of rangeland and pasture in the reading of the landuse drivers, which has likely been causing numerous weird pieces of model behavious and performance.
The changes look like this:

Where 45 has the change and 43 does not. So we remove some lai from the pasture in China, and generally increase it on rangeland.
The other plots are in
2.no/datalake/diagnostics/noresm/rosief/grazing_ppe_45/compare/grazing_ppe_43/ANN/
Specific notes
Contributors other than yourself, if any:
CTSM Issues Fixed (include github issue #):
Are answers expected to change (and if so in what way)?
Any User Interface Changes (namelist or namelist defaults changes)?
Does this create a need to change or add documentation? Did you do so?
Testing performed, if any:
(List what testing you did to show your changes worked as expected)
(This can be manual testing or running of the different test suites)
(Documentation on system testing is here: https://github.com/ESCOMP/ctsm/wiki/System-Testing-Guide)
(aux_clm on derecho for intel/gnu and izumi for intel/gnu/nag/nvhpc is the standard for tags on master)
NOTE: Be sure to check your coding style against the standard
(https://github.com/ESCOMP/ctsm/wiki/CTSM-coding-guidelines) and review
the list of common problems to watch out for
(https://github.com/ESCOMP/CTSM/wiki/List-of-common-problems).