Skip to content

TERMINAL_STATUSES omits release_failed, so the poller keeps polling a bounty whose payout has permanently failed #924

Closed

Description

@chonilius

src/types/bounty.ts:16-20:

export const TERMINAL_STATUSES: ReadonlySet<BountyStatus> = new Set(['paid','refunded','expired']);

coerceStatus recognizes ten statuses; release_failed and unknown are both absent from this set.

Why it matters: bountyPoller stops its interval when it sees a terminal status (src/hooks/bountyPoller.ts:51-53) — that is the whole of #632. A release_failed bounty is not going to change state without operator intervention, so every open tab on that bounty page polls it every 5 seconds indefinitely. useBountyStatus also derives isPolling/isLive from this set, so such a bounty is reported as live forever.

unknown is the #596 fallback for an unrecognized status, which means a bounty whose status the frontend cannot interpret is also polled forever.

Fix: add release_failed and unknown to the set, or introduce a separate POLLABLE_STATUSES allowlist so the default is "stop" rather than "keep going" — a new backend status would then be inert rather than producing a permanent poll loop.

Activity

  1. added
    bugSomething isn't working
    performancePerformance/optimization issue
    on Nov 12, 2026
  2. Ranjeet2063 commented on Nov 12, 2026

    @Ranjeet2063

    Hello maintainers,

    I reviewed the requirements for "TERMINAL_STATUSES omits release_failed, so the poller keeps polling a bounty whose payout has permanently failed" and would like to work on this implementation.

    I have reviewed the problem description and acceptance criteria for this issue. I have a clear, tested implementation ready with defensive error handling and 100% green CI proof.

    I will deliver a clean, well-tested, and production-ready PR promptly upon assignment. Kindly assign this issue to me.

    Thank you!

  3. Lion4467cat commented on Nov 14, 2026

    @Lion4467cat

    Hi @chonilius, I have implemented the fix and unit tests for this issue in #957. Kindly assign this issue to me and review when convenient. Thank you!

  4. added a commit that references this issue on Nov 14, 2026
    74a232f
  5. brightcli-stack commented on Nov 18, 2026

    @brightcli-stack
    Contributor

    @brightcli-stack has applied to work on this issue as part of the Stellar Wave Program's 11th wave.

    i will like to work on this issue

    ℹ️ Repo Maintainers: To accept this application, review their application or assign @brightcli-stack to this issue.

  6. drips-wave commented on Nov 18, 2026

    @drips-wave

    Congratulations, @brightcli-stack! 🎉 Your application was accepted by the repo's maintainers, and the issue is due on November 25, 2026.

    🧑‍💻 @brightcli-stack: Please resolve the issue such that the repo's maintainers have enough time to review your contribution before the due date. You'll earn Points for completing the issue on-time, which will make you eligible for a share of the Stellar Wave Program's reward pool.

    Warning

    When opening a PR, please link it to this issue to ensure it gets tracked accurately. Points are awarded when this issue is marked as completed by the maintainer.

    🤠 Repo maintainers: Please keep an eye on the contributor's progress and review their work before the due date. You can manage this issue, including adjusting its complexity and points, here.

    🌊 Happy Wave 🌊

  7. grantfox-oss commented on Nov 18, 2026

    @grantfox-oss

    🎉 This issue has been marked as completed on GrantFox!

    @brightcli-stack's PR #965 was approved and merged by @chonilius.

    🏆 @brightcli-stack: You earned 35 FoxPoints for this contribution! Your current tier: Explorer (990 total points). Track your full progress on GrantFox.

    👏 Great work, @brightcli-stack! Keep contributing to MergeFi.

  8. drips-wave commented on Nov 18, 2026

    @drips-wave

    This issue has been completed by @brightcli-stack as part of the Stellar Wave Program's 11th Wave 🥳

    😎 @brightcli-stack: You earned 200 Points for completing this issue! Once the Wave's rewards are finalized, you'll be eligible for a percentage of the Wave's reward pool based on the percentage of total points you've earned. Learn more here. You can also Leave a review to share your experience working on this issue.

    🧑‍💻 Repo maintainers: How'd the contributor do? Leave a review to share your experience working with them.

  9. added a commit that references this issue on Nov 18, 2026
    512d92a
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

Stellar WaveIssues in the Stellar wave programbugSomething isn't workingperformancePerformance/optimization issue

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions