Repository navigation
fix(bounty): include release_failed and unknown in TERMINAL_STATUSES (Fixes #924) - #957
Open
Lion4467cat wants to merge 1 commit into
Open
Lion4467cat wants to merge 1 commit into
Lion4467cat wants to merge 1 commit into
Conversation
|
@Lion4467cat is attempting to deploy a commit to the chonilius' projects Team on Vercel. A member of the Team first needs to authorize it. |
Lion4467cat
force-pushed
the
fix/issue-924-terminal-statuses
branch
from
November 14, 2026 10:41
c6f2c14 to
74a232f
Compare
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #924
What changed
'release_failed'and'unknown'toTERMINAL_STATUSESinsrc/types/bounty.ts.PollerEntry.snapshotinsrc/hooks/bountyPoller.tsand wireduseBountyStatus.tssouseSyncExternalStorereceives referentially stable snapshots and stops polling once any terminal status is reached.src/hooks/useBountyStatus.test.tsxasserting thatrelease_failedandunknownstop polling and reportisPolling: falseandisLive: false.Why
TERMINAL_STATUSESpreviously omittedrelease_failedandunknown, causingbountyPollerto poll permanently failed or unrecognized bounties every 5 seconds indefinitely anduseBountyStatusto report them as live forever.How to test
npx jest src/hooks/useBountyStatus.test.tsx --no-coverage(6 passed, 6 total)npx eslint src/types/bounty.ts src/hooks/bountyPoller.ts src/hooks/useBountyStatus.ts src/hooks/useBountyStatus.test.tsx(0 errors, 0 warnings)