feat(stellar): apply fetch policy in network service by stanleyyconsensys · Pull Request #551 · MetaMask/internal-snaps

stanleyyconsensys · 2026-11-04T07:51:11Z

Explanation

This PR apply fetch policy in network service

but do not apply the policy on send transaction to avoid the retry behavior becoz of timeout

References

Checklist

I've updated the test suite for new or updated code as appropriate
I've updated documentation (JSDoc, Markdown, etc.) for new or updated code as appropriate
I've communicated my changes to consumers by updating changelogs for packages I've changed
I've introduced breaking changes in this PR and have prepared draft pull requests for clients and consumer packages to resolve them

Copilot

🟡 Changes recommended

The network wrapper does not propagate cancellation during retry backoff, delaying rejection and triggering another adapter call, and its tests do not verify retry recovery or circuit breaking.

2 open issues

Propagate abort signal through retry backoff · New
Test SDK adapter retries and circuit breaking · New

What changed in this PR

Applies the shared fetch policy to Stellar Horizon and RPC requests, adding retries, timeouts, and circuit breaking while keeping transaction submission outside the policy.

Changes:

Adds policy-enabled SDK clients and transport-error mapping.
Configures per-network request timeouts and injects transaction simulation into MultiCall.
Adds error-mapping and configuration tests, plus a changelog entry.

File	Description
`packages/stellar-wallet-snap/src/utils/errors.ts`	Expands recognized transport errors and defines HTTP error types.
`packages/stellar-wallet-snap/src/utils/errors.test.ts`	Tests transport-error recognition and normalization.
`packages/stellar-wallet-snap/src/services/network/NetworkService.ts`	Uses policy-enabled clients while bypassing the policy for submission.
`packages/stellar-wallet-snap/src/services/network/NetworkService.test.ts`	Checks configured SDK client timeouts.
`packages/stellar-wallet-snap/src/services/network/NetworkClient.ts`	Wraps SDK adapters with fetch policies and error mapping.
`packages/stellar-wallet-snap/src/services/network/NetworkClient.test.ts`	Tests client timeouts, error mapping, and Horizon error compatibility.
`packages/stellar-wallet-snap/src/services/network/MultiCall.ts`	Accepts an injected transaction-simulation function.
`packages/stellar-wallet-snap/src/config.ts`	Adds network timeout configuration.
`packages/stellar-wallet-snap/src/config.test.ts`	Tests timeout parsing, defaults, and minimum validation.
`packages/stellar-wallet-snap/CHANGELOG.md`	Documents network resilience changes and the submission exception.

_{Review effort: Balanced}

sonarqubecloud · 2026-11-04T07:59:32Z

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
93.5% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

stanleyyconsensys · 2026-11-04T09:08:56Z

+    }
+
+    if (
+      error.name === KnownHttpErrorCode.CustomErrCanceled ||


stellar sdk using CustomErrCanceled to wrap the cancel request

Copilot

🟢 Approval recommended

No active review issues block the shared fetch-policy integration for Stellar’s Horizon and RPC clients.

No open issues 🎉

2 resolved since last review

_{Review effort: Balanced}

ulissesferreira

As far as I can tell, looks greats ✨

## **Description** Bumps the Solana, Stellar, and Tron wallet snaps to the versions released in internal-snaps `22.0.0`: - `@metamask/solana-wallet-snap`: `^7.2.0` → `^7.3.0` - `@metamask/stellar-wallet-snap`: `^2.0.0` → `^2.1.0` - `@metamask/tron-wallet-snap`: `^4.3.1` → `^4.4.0` All three are backwards-compatible minor updates; no application code changes are required. ### @metamask/solana-wallet-snap 7.3.0 - Remove the temporary fallback that injected `https://metamask.io` as the request origin when `keyring_submitRequest` was called without one ([MetaMask#533](MetaMask/internal-snaps#533)). ### @metamask/stellar-wallet-snap 2.1.0 - `confirmSend` now throws when signing or submission fails after the user confirms, instead of returning a JSON error response ([MetaMask#550](MetaMask/internal-snaps#550)). - Bump `@stellar/stellar-sdk` from `^17.2.1` to `^17.4.0` ([MetaMask#545](MetaMask/internal-snaps#545)). - Retry transient Token API, Price API, Security Alerts API, RPC, and Horizon failures with bounded timeouts and circuit breaking ([MetaMask#534](MetaMask/internal-snaps#534), [MetaMask#551](MetaMask/internal-snaps#551)). - Fix `onAmountInput` to accept the optional destination as `toAddress` instead of `to` ([MetaMask#558](MetaMask/internal-snaps#558)). ### @metamask/tron-wallet-snap 4.4.0 - Support `VoteWitnessContract` and `AccountPermissionUpdateContract` transactions by upgrading TronWeb to 6.5.1 ([MetaMask#561](MetaMask/internal-snaps#561)). - Align transaction security warning copy and scan-loading behavior with user preferences ([MetaMask#557](MetaMask/internal-snaps#557)). ## **Changelog** CHANGELOG entry: null ## **Related issues** n/a ## **Manual testing steps** n/a ## **Screenshots/Recordings** ### **Before**  ### **After**  ## **Pre-merge author checklist** - [X] I've followed [MetaMask Contributor Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask Extension Coding Standards](https://github.com/MetaMask/metamask-extension/blob/main/.github/guidelines/CODING_GUIDELINES.md). - [X] I've completed the PR template to the best of my ability - [X] I’ve included tests if applicable - [X] I’ve documented my code using [JSDoc](https://jsdoc.app/) format if applicable - [X] I’ve applied the right labels on the PR (see [labeling guidelines](https://github.com/MetaMask/metamask-extension/blob/main/.github/guidelines/LABELING_GUIDELINES.md)). Not required for external contributors. ## **Pre-merge reviewer checklist** - [ ] I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed). - [ ] I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

## Explanation This release branch prepares version `22.0.0`. It contains: - `@metamask/solana-wallet-snap` `7.2.0` → `7.3.0` (minor: remove obsolete `https://metamask.io` origin fallback) - `@metamask/stellar-wallet-snap` `2.0.0` → `2.1.0` (minor: fetch policy for RPC, Horizon and HTTP clients, `@stellar/stellar-sdk` upgrade, `onAmountInput` `toAddress` fix, `confirmSend` now throws after confirmation failures) - `@metamask/tron-wallet-snap` `4.3.1` → `4.4.0` (minor: `VoteWitnessContract` and `AccountPermissionUpdateContract` support via TronWeb 6.5.1, security warning copy and scan-loading alignment) - Root monorepo version bumped to `22.0.0` ## References - `@metamask/solana-wallet-snap`: [MetaMask#533](MetaMask#533) - `@metamask/stellar-wallet-snap`: [MetaMask#550](MetaMask#550), [MetaMask#545](MetaMask#545), [MetaMask#534](MetaMask#534), [MetaMask#551](MetaMask#551), [MetaMask#558](MetaMask#558) - `@metamask/tron-wallet-snap`: [MetaMask#561](MetaMask#561), [MetaMask#557](MetaMask#557) ## Checklist - [x] I've communicated my changes to consumers by [updating changelogs for packages I've changed](https://github.com/MetaMask/internal-snaps/tree/main/docs/processes/updating-changelogs.md) - [ ] I've introduced [breaking changes](https://github.com/MetaMask/internal-snaps/tree/main/docs/processes/breaking-changes.md) in this PR and have prepared draft pull requests for clients and consumer packages to resolve them

…taMask#39134)  ## **Description** Bumps the Bitcoin, Solana, Stellar, and Tron wallet snaps to their latest published versions: - `@metamask/bitcoin-wallet-snap`: `^3.2.0` → `^3.3.0` - `@metamask/solana-wallet-snap`: `^7.2.0` → `^7.3.0` - `@metamask/stellar-wallet-snap`: `^2.0.0` → `^2.1.0` - `@metamask/tron-wallet-snap`: `^4.3.0` → `^4.4.0` All are backwards-compatible minor updates; no application code changes are required. ### @metamask/bitcoin-wallet-snap 3.3.0 - Retry transient Bitcoin indexer, price API, and signed transaction broadcast failures with the shared fetch policy, and treat duplicate broadcasts as successful ([MetaMask#530](MetaMask/internal-snaps#530)). - Fix formatting of small Bitcoin balances to avoid scientific notation ([MetaMask#543](MetaMask/internal-snaps#543)). ### @metamask/solana-wallet-snap 7.3.0 - Remove the temporary fallback that injected `https://metamask.io` as the request origin when `keyring_submitRequest` was called without one ([MetaMask#533](MetaMask/internal-snaps#533)). ### @metamask/stellar-wallet-snap 2.1.0 - `confirmSend` now throws when signing or submission fails after the user confirms, instead of returning a JSON error response ([MetaMask#550](MetaMask/internal-snaps#550)). - Bump `@stellar/stellar-sdk` from `^17.2.1` to `^17.4.0` ([MetaMask#545](MetaMask/internal-snaps#545)). - Retry transient Token API, Price API, Security Alerts API, RPC, and Horizon failures with bounded timeouts and circuit breaking ([MetaMask#534](MetaMask/internal-snaps#534), [MetaMask#551](MetaMask/internal-snaps#551)). - Fix `onAmountInput` to accept the optional destination as `toAddress` instead of `to` ([MetaMask#558](MetaMask/internal-snaps#558)). ### @metamask/tron-wallet-snap 4.4.0 - Support `VoteWitnessContract` and `AccountPermissionUpdateContract` transactions by upgrading TronWeb to 6.5.1 ([MetaMask#561](MetaMask/internal-snaps#561)). - Align transaction security warning copy and scan-loading behavior with user preferences ([MetaMask#557](MetaMask/internal-snaps#557)). ## **Changelog** CHANGELOG entry: Updated the Solana, Stellar, and Tron wallet snaps to their latest versions. ## **Related issues** Fixes: N/A ## **Manual testing steps** ```gherkin Feature: Bitcoin and non-EVM wallet flows Scenario: user views account assets Given the user has Bitcoin, Solana, Stellar, and Tron accounts with assets When user opens the wallet and switches between those networks Then the assets and balances load successfully Scenario: user sends funds on each network Given the user has funds on Bitcoin, Solana, Stellar, and Tron When user sends funds on each network Then the fee estimate and confirmation are displayed correctly And the transaction is broadcast and completes successfully ``` ## **Screenshots/Recordings** ### **Before** N/A ### **After** N/A ## **Pre-merge author checklist** - [x] I've followed [MetaMask Contributor Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask Mobile Coding Standards](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/CODING_GUIDELINES.md). - [x] I've completed the PR template to the best of my ability - [x] I've included tests if applicable - [x] I've documented my code using [JSDoc](https://jsdoc.app/) format if applicable - [x] I've applied the right labels on the PR (see [labeling guidelines](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/LABELING_GUIDELINES.md)). Not required for external contributors. #### Performance checks (if applicable) - [x] I've tested on Android - Ideally on a mid-range device; emulator is acceptable - [x] I've tested with a power user scenario - Use these [power-user SRPs](https://consensyssoftware.atlassian.net/wiki/spaces/TL1/pages/edit-v2/401401446401?draftShareId=9d77e1e1-4bdc-4be1-9ebb-ccd916988d93) to import wallets with many accounts and tokens - [x] I've instrumented key operations with Sentry traces for production performance metrics - See [`trace()`](/app/util/trace.ts) for usage and [`addToken`](/app/components/Views/AddAsset/components/AddCustomToken/AddCustomToken.tsx#L274) for an example For performance guidelines and tooling, see the [Performance Guide](https://consensyssoftware.atlassian.net/wiki/spaces/TL1/pages/400085549067/Performance+Guide+for+Engineers). ## **Pre-merge reviewer checklist** - [ ] I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed). - [ ] I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

stanleyyconsensys added 3 commits November 4, 2026 15:19

chore: refactor errors

a36460d

chore: add timeout config

8826888

chore: add network client with policy

074d0da

stanleyyconsensys requested review from a team as code owners November 4, 2026 07:51

stanleyyconsensys temporarily deployed to default-branch November 4, 2026 07:51 — with GitHub Actions Inactive

stanleyyconsensys added 2 commits November 4, 2026 15:53

Merge branch 'main' into fix/stellar/network-client

7b4753f

Update CHANGELOG.md

a4d7271

stanleyyconsensys requested a balanced review from Copilot November 4, 2026 07:54

stanleyyconsensys changed the title ~~feat(stellar): use shared fetch policy in network service~~ feat(stellar): apply fetch policy in network service Nov 4, 2026

Copilot started reviewing on behalf of stanleyyconsensys November 4, 2026 07:55

View session

Copilot AI reviewed Nov 4, 2026

View reviewed changes

Comment thread packages/stellar-wallet-snap/src/services/network/NetworkClient.ts Resolved

Comment thread packages/stellar-wallet-snap/src/services/network/NetworkClient.ts Resolved

stanleyyconsensys commented Nov 4, 2026

View reviewed changes

stanleyyconsensys requested a balanced review from Copilot November 4, 2026 09:17

Copilot started reviewing on behalf of stanleyyconsensys November 4, 2026 09:17

View session

Copilot AI reviewed Nov 4, 2026

View reviewed changes

ulissesferreira approved these changes Nov 4, 2026

View reviewed changes

stanleyyconsensys added this pull request to the merge queue Nov 5, 2026

Merged via the queue into main with commit 2f15e2a Nov 5, 2026
58 checks passed

stanleyyconsensys deleted the fix/stellar/network-client branch November 5, 2026 00:58

This was referenced Nov 6, 2026

Release/22.0.0 #565

Merged

chore: bump solana, stellar, and tron wallet snaps MetaMask/metamask-extension#47698

Merged

chore(deps): bump bitcoin, solana, stellar, and tron wallet snaps MetaMask/metamask-mobile#39134

Merged

Navigation Menu

Repository navigation

feat(stellar): apply fetch policy in network service - #551

feat(stellar): apply fetch policy in network service#551
stanleyyconsensys merged 5 commits into
mainfrom
fix/stellar/network-client

stanleyyconsensys commented Nov 4, 2026

Uh oh!

Copilot AI left a comment

Uh oh!

Uh oh!

Uh oh!

sonarqubecloud Bot commented Nov 4, 2026

Uh oh!

stanleyyconsensys Nov 4, 2026

Uh oh!

Copilot AI left a comment

Uh oh!

ulissesferreira left a comment

Uh oh!

Uh oh!

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Conversation

stanleyyconsensys commented Nov 4, 2026

Explanation

References

Checklist

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

🟡 Changes recommended

Uh oh!

Uh oh!

Uh oh!

sonarqubecloud Bot commented Nov 4, 2026

Quality Gate passed

Uh oh!

stanleyyconsensys Nov 4, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

🟢 Approval recommended

Uh oh!

ulissesferreira left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants