feat(bitcoin): use shared fetch policy helpers by Julink-eth · Pull Request #530 · MetaMask/internal-snaps

Julink-eth · 2026-10-26T13:56:38Z

Explanation

Applies the shared retry and circuit-breaker fetch policy (createFetchPolicy, executeWithFetchPolicy, and fetchWithPolicy from @metamask/snap-networks-utils) to @metamask/bitcoin-wallet-snap, following #472, #478, and #492.

Changes

Esplora indexer reads (EsploraClientAdapter):
- Creates one FetchPolicy per Bitcoin network (esplora_bitcoin, esplora_testnet, esplora_testnet4, esplora_signet, esplora_regtest) so an outage on one network cannot open the circuit breaker for another.
- Disables BDK's internal EsploraClient retry loop (maxRetries = 0) and removes the obsolete chain.maxRetries config so retries are not stacked on top of the shared policy.
- Routes fullScan, sync, and getFeeEstimates through executeWithFetchPolicy, recreating account.startFullScan() and account.startSync() inside each attempt (since the WASM client consumes the request pointer per call) and applying the wallet Update only once after the policy succeeds.
- Routes getTransactionSenders (GET /tx/:txid) through fetchWithPolicy, keeping JSON parsing outside the retry boundary and preserving failed-lookup cache eviction.
- Adds a BDK-specific toFetchPolicyError mapper that extracts HTTP status codes from HttpResponse { status: ... } and maps transport Reqwest(...) errors to NetworkError, while letting response decode (kind: Decode), parsing, and wallet-state errors pass through without retrying.
Price API (PriceApiClientAdapter):
- Routes spotPrices through fetchWithPolicy with a price_api policy and parses JSON outside the policy while preserving the ExternalServiceError boundary.
Safe broadcast retries & duplicate handling (EsploraClientAdapter.broadcast):
- Why Bitcoin transaction broadcasts are safe to retry: A signed Bitcoin transaction has deterministic serialized bytes and a deterministic txid ([sha256d(serialized_tx_without_witness)]). Because EsploraClient.broadcast(transaction) borrows the already-signed Transaction by reference without rebuilding or re-signing it, every retry submits the exact same transaction bytes and txid. Re-broadcasting cannot create a second payment or double-spend; nodes treat it as the same transaction.
- Transaction construction, coin selection, and PSBT signing remain outside the retry boundary and execute once.
- If an earlier broadcast attempt reached the node before a dropped response or timeout, subsequent retries may receive a duplicate rejection (Transaction already in block chain, already in mempool, txn-already-in-mempool, or txn-already-known). isAlreadyBroadcastError treats those responses as a successful broadcast.
Build tooling:
- Provides the @metamask/snap-networks-utils/performance-shim global via webpack's ProvidePlugin in snap.config.ts and declares webpack (5.107.2, matching @metamask/snaps-cli) as a dev dependency.

References

Checklist

I've updated the test suite for new or updated code as appropriate
I've updated documentation (JSDoc, Markdown, etc.) for new or updated code as appropriate
I've communicated my changes to consumers by updating changelogs for packages I've changed
I've introduced breaking changes in this PR and have prepared draft pull requests for clients and consumer packages to resolve them

Julink-eth · 2026-10-26T14:19:15Z

@metamaskbot publish-preview

github-actions · 2026-10-26T14:22:56Z

Preview builds have been published. Learn how to use preview builds in other projects.

Expand for full list of packages and versions.

@metamask-previews/bitcoin-wallet-snap@3.2.0-preview-ff029a7
@metamask-previews/snap-networks-utils@3.1.0-preview-ff029a7
@metamask-previews/solana-wallet-snap@7.2.0-preview-ff029a7
@metamask-previews/stellar-wallet-snap@1.3.0-preview-ff029a7
@metamask-previews/tron-wallet-snap@4.3.0-preview-ff029a7

Copilot

🔵 Needs a closer look

Broadcast retries and string-based error classification need human validation against the real BDK WASM client because the adapter tests mock that boundary.

No open issues 🎉

What changed in this PR

Adopts the shared fetch-policy helpers in the Bitcoin wallet snap, aligning its network handling with the Solana and Tron integrations.

Changes:

Adds per-network Esplora policies and a price API policy, replacing BDK’s internal retries.
Retries signed transaction broadcasts, recognizes duplicate submissions, and recreates scan requests for each attempt.
Adds adapter tests, raises coverage thresholds, and configures the performance shim required by the shared policy.

File	Description
`yarn.lock`	Records the Bitcoin snap’s webpack dependency.
`packages/bitcoin-wallet-snap/src/infra/PriceApiClientAdapter.ts`	Uses the shared fetch policy for price requests.
`packages/bitcoin-wallet-snap/src/infra/PriceApiClientAdapter.test.ts`	Tests retries, non-transient failures, and malformed JSON.
`packages/bitcoin-wallet-snap/src/infra/EsploraClientAdapter.ts`	Adds network policies, BDK error mapping, and duplicate broadcast handling.
`packages/bitcoin-wallet-snap/src/infra/EsploraClientAdapter.test.ts`	Tests retry behavior, request recreation, and broadcast handling.
`packages/bitcoin-wallet-snap/src/index.ts`	Passes the logger to both network adapters.
`packages/bitcoin-wallet-snap/src/entities/config.ts`	Removes the obsolete retry configuration field.
`packages/bitcoin-wallet-snap/src/config.ts`	Removes the retry setting from validation and defaults.
`packages/bitcoin-wallet-snap/src/config.test.ts`	Updates configuration fixtures and expectations.
`packages/bitcoin-wallet-snap/snap.config.ts`	Provides the performance shim through webpack.
`packages/bitcoin-wallet-snap/package.json`	Pins webpack as a development dependency.
`packages/bitcoin-wallet-snap/jest.config.js`	Raises coverage thresholds.
`packages/bitcoin-wallet-snap/CHANGELOG.md`	Documents retries and duplicate broadcast handling.
`eslint-suppressions.json`	Removes suppressions now handled in the snap configuration.

_{Review effort: Balanced}

Copilot

🔵 Needs a closer look

Payment broadcast retries and WASM request ownership require final human validation, including confirmation that the adapter and real-WASM tests pass.

No open issues 🎉

_{Review effort: Balanced}

…ts on retry without a null-pointer error

Copilot

🔵 Needs a closer look

Signed-transaction retries and WASM ownership handling warrant human validation with passing integration tests.

No open issues 🎉

_{Review effort: Balanced}

sonarqubecloud · 2026-10-26T14:58:17Z

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
95.6% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

ulissesferreira · 2026-10-27T15:09:23Z

Completely unrelated remark but eventually I would love to see us use objects to pass parameters to constructors so we have a better way to handle optional ones

ulissesferreira

LGTM!

…aMask#47621)  ## **Description** # Bitcoin [3.3.0] ### Changed - Retry transient Bitcoin indexer, price API, and signed transaction broadcast failures with the shared fetch policy, and treat duplicate broadcasts as successful. ([MetaMask#530](MetaMask/internal-snaps#530)) ### Fixed - Fix formatting of small Bitcoin balances to avoid scientific notation. ([MetaMask#543](MetaMask/internal-snaps#543)) # Tron [4.3.1] ### Fixed - Allow transaction confirmation after remote simulation failures while retaining security warnings and checks for locally invalid transactions. ([MetaMask#552](MetaMask/internal-snaps#552))  ## **Changelog**  CHANGELOG entry: null ## **Related issues** n/a ## **Manual testing steps** n/a ## **Screenshots/Recordings**  ### **Before**  ### **After**  ## **Pre-merge author checklist** - [X] I've followed [MetaMask Contributor Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask Extension Coding Standards](https://github.com/MetaMask/metamask-extension/blob/main/.github/guidelines/CODING_GUIDELINES.md). - [X] I've completed the PR template to the best of my ability - [X] I’ve included tests if applicable - [X] I’ve documented my code using [JSDoc](https://jsdoc.app/) format if applicable - [X] I’ve applied the right labels on the PR (see [labeling guidelines](https://github.com/MetaMask/metamask-extension/blob/main/.github/guidelines/LABELING_GUIDELINES.md)). Not required for external contributors. ## **Pre-merge reviewer checklist** - [ ] I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed). - [ ] I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.  --- > [!NOTE] > **Medium Risk** > Patch bumps change Bitcoin broadcast/retry behavior and Tron confirmation when remote simulation fails, both on transaction-critical paths. > > **Overview** > Bumps **`@metamask/bitcoin-wallet-snap`** to **3.3.0** and **`@metamask/tron-wallet-snap`** to **4.3.1** in `package.json`, with matching **`yarn.lock`** resolutions. No extension source changes—behavior comes from the new snap builds. > > With **Bitcoin 3.3.0**, users get more resilient indexer/price/broadcast calls (shared fetch retries, duplicate broadcasts treated as success) and corrected display of very small balances (no scientific notation). > > With **Tron 4.3.1**, confirmation can proceed when **remote** simulation fails, while locally invalid transactions still block approval and security warnings remain. > > <sup>Reviewed by [Cursor Bugbot](https://cursor.com/bugbot) for commit 4bd1b01. Bugbot is set up for automated code reviews on this repo. Configure [here](https://www.cursor.com/dashboard/bugbot).</sup>

## Explanation # Bitcoin [3.3.0] ### Changed - Retry transient Bitcoin indexer, price API, and signed transaction broadcast failures with the shared fetch policy, and treat duplicate broadcasts as successful. ([MetaMask#530](MetaMask#530)) ### Fixed - Fix formatting of small Bitcoin balances to avoid scientific notation. ([MetaMask#543](MetaMask#543)) # Tron [4.3.1] ### Fixed - Allow transaction confirmation after remote simulation failures while retaining security warnings and checks for locally invalid transactions. ([MetaMask#552](MetaMask#552))  ## References  ## Checklist - [ ] I've updated the test suite for new or updated code as appropriate - [ ] I've updated documentation (JSDoc, Markdown, etc.) for new or updated code as appropriate - [ ] I've communicated my changes to consumers by [updating changelogs for packages I've changed](https://github.com/MetaMask/internal-snaps/tree/main/docs/processes/updating-changelogs.md) - [ ] I've introduced [breaking changes](https://github.com/MetaMask/internal-snaps/tree/main/docs/processes/breaking-changes.md) in this PR and have prepared draft pull requests for clients and consumer packages to resolve them

…taMask#39134)  ## **Description** Bumps the Bitcoin, Solana, Stellar, and Tron wallet snaps to their latest published versions: - `@metamask/bitcoin-wallet-snap`: `^3.2.0` → `^3.3.0` - `@metamask/solana-wallet-snap`: `^7.2.0` → `^7.3.0` - `@metamask/stellar-wallet-snap`: `^2.0.0` → `^2.1.0` - `@metamask/tron-wallet-snap`: `^4.3.0` → `^4.4.0` All are backwards-compatible minor updates; no application code changes are required. ### @metamask/bitcoin-wallet-snap 3.3.0 - Retry transient Bitcoin indexer, price API, and signed transaction broadcast failures with the shared fetch policy, and treat duplicate broadcasts as successful ([MetaMask#530](MetaMask/internal-snaps#530)). - Fix formatting of small Bitcoin balances to avoid scientific notation ([MetaMask#543](MetaMask/internal-snaps#543)). ### @metamask/solana-wallet-snap 7.3.0 - Remove the temporary fallback that injected `https://metamask.io` as the request origin when `keyring_submitRequest` was called without one ([MetaMask#533](MetaMask/internal-snaps#533)). ### @metamask/stellar-wallet-snap 2.1.0 - `confirmSend` now throws when signing or submission fails after the user confirms, instead of returning a JSON error response ([MetaMask#550](MetaMask/internal-snaps#550)). - Bump `@stellar/stellar-sdk` from `^17.2.1` to `^17.4.0` ([MetaMask#545](MetaMask/internal-snaps#545)). - Retry transient Token API, Price API, Security Alerts API, RPC, and Horizon failures with bounded timeouts and circuit breaking ([MetaMask#534](MetaMask/internal-snaps#534), [MetaMask#551](MetaMask/internal-snaps#551)). - Fix `onAmountInput` to accept the optional destination as `toAddress` instead of `to` ([MetaMask#558](MetaMask/internal-snaps#558)). ### @metamask/tron-wallet-snap 4.4.0 - Support `VoteWitnessContract` and `AccountPermissionUpdateContract` transactions by upgrading TronWeb to 6.5.1 ([MetaMask#561](MetaMask/internal-snaps#561)). - Align transaction security warning copy and scan-loading behavior with user preferences ([MetaMask#557](MetaMask/internal-snaps#557)). ## **Changelog** CHANGELOG entry: Updated the Solana, Stellar, and Tron wallet snaps to their latest versions. ## **Related issues** Fixes: N/A ## **Manual testing steps** ```gherkin Feature: Bitcoin and non-EVM wallet flows Scenario: user views account assets Given the user has Bitcoin, Solana, Stellar, and Tron accounts with assets When user opens the wallet and switches between those networks Then the assets and balances load successfully Scenario: user sends funds on each network Given the user has funds on Bitcoin, Solana, Stellar, and Tron When user sends funds on each network Then the fee estimate and confirmation are displayed correctly And the transaction is broadcast and completes successfully ``` ## **Screenshots/Recordings** ### **Before** N/A ### **After** N/A ## **Pre-merge author checklist** - [x] I've followed [MetaMask Contributor Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask Mobile Coding Standards](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/CODING_GUIDELINES.md). - [x] I've completed the PR template to the best of my ability - [x] I've included tests if applicable - [x] I've documented my code using [JSDoc](https://jsdoc.app/) format if applicable - [x] I've applied the right labels on the PR (see [labeling guidelines](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/LABELING_GUIDELINES.md)). Not required for external contributors. #### Performance checks (if applicable) - [x] I've tested on Android - Ideally on a mid-range device; emulator is acceptable - [x] I've tested with a power user scenario - Use these [power-user SRPs](https://consensyssoftware.atlassian.net/wiki/spaces/TL1/pages/edit-v2/401401446401?draftShareId=9d77e1e1-4bdc-4be1-9ebb-ccd916988d93) to import wallets with many accounts and tokens - [x] I've instrumented key operations with Sentry traces for production performance metrics - See [`trace()`](/app/util/trace.ts) for usage and [`addToken`](/app/components/Views/AddAsset/components/AddCustomToken/AddCustomToken.tsx#L274) for an example For performance guidelines and tooling, see the [Performance Guide](https://consensyssoftware.atlassian.net/wiki/spaces/TL1/pages/400085549067/Performance+Guide+for+Engineers). ## **Pre-merge reviewer checklist** - [ ] I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed). - [ ] I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

feat(bitcoin): use shared fetch policy helpers

60d70cd

Julink-eth requested review from a team as code owners October 26, 2026 13:56

Julink-eth temporarily deployed to default-branch October 26, 2026 13:56 — with GitHub Actions Inactive

chore: update changelog

ff029a7

Julink-eth requested a balanced review from Copilot October 26, 2026 14:19

Copilot started reviewing on behalf of Julink-eth October 26, 2026 14:19

View session

Copilot AI reviewed Oct 26, 2026

View reviewed changes

chore: add real BDK WASM client for the tests

f7eb337

Julink-eth requested a balanced review from Copilot October 26, 2026 14:36

Copilot started reviewing on behalf of Julink-eth October 26, 2026 14:37

View session

Copilot AI reviewed Oct 26, 2026

View reviewed changes

chore: adds recreates real WASM FullScanRequest and SyncRequest objec…

ae3ff57

…ts on retry without a null-pointer error

Julink-eth requested a balanced review from Copilot October 26, 2026 14:52

Copilot started reviewing on behalf of Julink-eth October 26, 2026 14:53

View session

Copilot AI reviewed Oct 26, 2026

View reviewed changes

ulissesferreira reviewed Oct 27, 2026

View reviewed changes

ulissesferreira approved these changes Oct 27, 2026

View reviewed changes

Julink-eth added this pull request to the merge queue Oct 27, 2026

Merged via the queue into main with commit dfe5f7d Oct 27, 2026
57 checks passed

Julink-eth deleted the refactor/bitcoin-use-shared-fetch-policy-helpers branch October 27, 2026 15:23

This was referenced Oct 28, 2026

fix(bitcoin): retry the first full scan and make Retry trigger a real scan #521

Draft

perf(bitcoin): scan new accounts with a gap of 5 and deepen only if used #522

Draft

This was referenced Nov 4, 2026

Release/21.0.0 #553

Merged

chore: bump bitcoin-wallet-snap@3.3.0 and tron-wallet-snap@4.3.1 MetaMask/metamask-extension#47621

Merged

taran-a mentioned this pull request Nov 6, 2026

chore: bump bitcoin-wallet-snap to 3.3.0 and tron-wallet-snap to 4.3.1 MetaMask/metamask-mobile#39141

Closed

5 of 10 tasks

ulissesferreira mentioned this pull request Nov 6, 2026

chore(deps): bump bitcoin, solana, stellar, and tron wallet snaps MetaMask/metamask-mobile#39134

Merged

8 of 10 tasks

Navigation Menu

Repository navigation

feat(bitcoin): use shared fetch policy helpers - #530

feat(bitcoin): use shared fetch policy helpers#530
Julink-eth merged 4 commits into
mainfrom
refactor/bitcoin-use-shared-fetch-policy-helpers

Julink-eth commented Oct 26, 2026

Uh oh!

Julink-eth commented Oct 26, 2026

Uh oh!

github-actions Bot commented Oct 26, 2026

Uh oh!

Copilot AI left a comment

Uh oh!

Copilot AI left a comment

Uh oh!

Copilot AI left a comment

Uh oh!

sonarqubecloud Bot commented Oct 26, 2026

Uh oh!

ulissesferreira Oct 27, 2026

Uh oh!

ulissesferreira left a comment

Uh oh!

Uh oh!

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Conversation

Julink-eth commented Oct 26, 2026

Explanation

References

Checklist

Uh oh!

Julink-eth commented Oct 26, 2026

Uh oh!

github-actions Bot commented Oct 26, 2026

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

🔵 Needs a closer look

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

🔵 Needs a closer look

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

🔵 Needs a closer look

Uh oh!

sonarqubecloud Bot commented Oct 26, 2026

Quality Gate passed

Uh oh!

ulissesferreira Oct 27, 2026

Choose a reason for hiding this comment

Uh oh!

ulissesferreira left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants