Skip to content

chore: bump bitcoin-wallet-snap to 3.3.0 and tron-wallet-snap to 4.3.1 - #39141

Closed
taran-a wants to merge 1 commit into
mainfrom
chore/bump-bitcoin-3.3.0-tron-4.3.1-snaps
Closed

taran-a wants to merge 1 commit into
mainfrom
chore/bump-bitcoin-3.3.0-tron-4.3.1-snaps

Conversation

@taran-a

@taran-a taran-a commented Nov 6, 2026 •

Copy link
Copy Markdown
Contributor

Description

Bitcoin [3.3.0]

Changed

  • Retry transient Bitcoin indexer, price API, and signed transaction broadcast failures with the shared fetch policy, and treat duplicate broadcasts as successful. (#530)

Fixed

  • Fix formatting of small Bitcoin balances to avoid scientific notation. (#543)

Tron [4.3.1]

Fixed

  • Allow transaction confirmation after remote simulation failures while retaining security warnings and checks for locally invalid transactions. (#552)

Changelog

CHANGELOG entry: null

Related issues

n/a

Manual testing steps

n/a

Screenshots/Recordings

Before

After

Pre-merge author checklist

Performance checks (if applicable)

  • I've tested on Android
    • Ideally on a mid-range device; emulator is acceptable
  • I've tested with a power user scenario
    • Use these power-user SRPs to import wallets with many accounts and tokens
  • I've instrumented key operations with Sentry traces for production performance metrics

For performance guidelines and tooling, see the Performance Guide.

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

Note

Medium Risk
Dependency-only bumps for multichain wallet snaps that affect signing/broadcast flows; validate Bitcoin balance display, retries, and Tron confirmations after simulation issues.

Overview
Upgrades the preinstalled Bitcoin and Tron wallet snaps to 3.3.0 and 4.3.1, respectively, by bumping their semver ranges in package.json and locking the new tarballs/checksums in yarn.lock.

This picks up upstream snap fixes: Bitcoin retries transient indexer/price/broadcast calls with the shared fetch policy, treats duplicate broadcasts as success, and formats tiny balances without scientific notation; Tron allows confirmation after remote simulation failures while keeping local validation and warnings.

Scope is dependency-only; functional behavior follows the referenced internal snap PRs.

Reviewed by Cursor Bugbot for commit bf54b1f. Bugbot is set up for automated code reviews on this repo. Configure here.

@github-actions

github-actions Bot commented Nov 6, 2026

Copy link
Copy Markdown
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@github-actions github-actions Bot added size-XS pr-not-ready-for-e2e Skip E2E and block merging. Remove this label once the PR is ready to run the E2E tests. labels Nov 6, 2026
@metamask-ci metamask-ci Bot added the team-networks Networks team label Nov 6, 2026
@metamask-ci

metamask-ci Bot commented Nov 6, 2026

Copy link
Copy Markdown
Contributor

PR template — items to address before "Ready for review"

Warnings — informational, address before merging:

  • Description section is empty. Describe what changed and why.
  • Related issues section is empty. Add Fixes: #123 / Closes: <URL> / Refs: <Jira key>, or write a short rationale after the colon.
  • Screenshots/Recordings section is empty. Add an image/video for user-facing changes, logs/console output for non-user-facing changes, or write N/A if no evidence is applicable.
  • Pre-merge author checklist has unchecked items (e.g. "I've tested on Android"). Every box must be consciously checked — see docs/readme/ready-for-review.md.

See docs/readme/ready-for-review.md for the full Definition of Ready for Review.

@socket-security

Copy link
Copy Markdown

Review the following changes in direct dependencies. Learn more about Socket for GitHub.

Diff Package Supply Chain
Security
Vulnerability Quality Maintenance License
Updatednpm/​@​metamask/​bitcoin-wallet-snap@​3.2.0 ⏵ 3.3.0100 +110083 +198100
Updatednpm/​@​metamask/​tron-wallet-snap@​4.3.0 ⏵ 4.3.1100 +510010099100

View full report

@taran-a taran-a closed this Nov 6, 2026
@taran-a
taran-a deleted the chore/bump-bitcoin-3.3.0-tron-4.3.1-snaps branch November 6, 2026 15:46
@github-actions github-actions Bot locked and limited conversation to collaborators Nov 6, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

pr-not-ready-for-e2e Skip E2E and block merging. Remove this label once the PR is ready to run the E2E tests. size-XS team-networks Networks team

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant