Repository navigation
Update to ctsm5.4.034 - #212
Conversation
Fix hydrology doc typos
Transfer biophysical variables for output with FATES dimensions This pull request updates the high frequency wrapper procedure in the interface to pass biophysical CLM variables to be output along FATES dimensions. The FATES land use x pft dimension is also added to the history module. The FATES base land use test module adds the FATES history noted above to the test output.
- Correct Bare Ground PFT acronym in table (use '-' instead of NET Temperate) - Fix 'gridded datasets' typo and 'Stem area index' spelling - Fix 'Lake temperatures' (remove stray 'place') - Add missing comma in physical constants csv-table for thermal conductivity of air - Remove duplicate chapter RST label Made-with: Cursor
…nstants for the dust doc. Removed description of Zender 2003 dust emission scheme in the doc.
…15 file for clm4_5 and clm5_0
…ngs are done when the initial use_init_interp default setting is checked for (otherwise it would always be true since it couldn't distinquish by attributes)
Resolve ESCOMP#3835 by adding 2010 to init_interp_sim_years. nit_interp_sim_years #
…_interp and init_interp_attributes and set 2003 finidat only once and use do_transient_pfts=.true.
…terp more robust, by calling it after the settings have been declared, rather than setting them only for the default run through
…th single vs double precision, larger changes to clm4_5 have already come in
Purpose: To update doc/source/users_guide/overview/introduction.rst with WhatsNewInCTSM5.4.md in its permanent location
…anges ctsm5.4.027: Important coupled model final answer changes: param file and n_melt_glcmec
ctsm5.4.036: Complete the FATES-CLM nitrogen coupling
|
The checks will get fixed when NorESMhub/fates#58 tag is made. Added expected fails for NorESMhub/NorESM PR comming right after |
JessicaNeedham
left a comment
There was a problem hiding this comment.
Thanks @mvdebolskiy - the recent land use changes look correct to me except for a missing test.
| ! Land use name arrays | ||
| character(len=10), parameter :: landuse_pft_map_varnames(num_landuse_pft_vars) = & | ||
| [character(len=10) :: 'frac_primr','frac_secnd','frac_pastr','frac_range'] !need to move 'frac_surf' to a different variable | ||
| [character(len=10) :: 'frac_primr','frac_secnd','frac_range','frac_pastr'] !need to move 'frac_surf' to a different variable |
There was a problem hiding this comment.
Looks good, this is the correct order
| <use_fates_luh use_fates=".true." use_fates_potentialveg=".true.">.true.</use_fates_luh> | ||
| <use_fates_luh use_fates=".true." >.false.</use_fates_luh> | ||
| <fates_parteh_mode use_fates=".true.">1</fates_parteh_mode> | ||
| <fates_lu_transition_logic use_fates=".true." use_fates_luh=".true." >4</fates_lu_transition_logic> |
There was a problem hiding this comment.
This line can be deleted - we have the same namelist option above with more explanation. Actually this looks incorrect in the ctsm side too so I'll make an issue to fix it there as well.
| <fates_spitfire_mode use_fates=".true." use_fates_sp=".true.">0</fates_spitfire_mode> | ||
| <fates_harvest_mode use_fates=".true.">no_harvest</fates_harvest_mode> | ||
| <fates_stomatal_model use_fates=".true.">medlyn2011</fates_stomatal_model> | ||
| <fates_lu_transition_logic use_fates=".true.">4</fates_lu_transition_logic> <!--Default value of 4 means vegetation |
There was a problem hiding this comment.
We want the default option to be 1 for noresm. I left it at 4 for the CTSM/NGEET side to match the previous NGEET hard coded value behaviour.
| my $var = "use_fates_dbh_init"; | ||
| if ( &value_is_true($nl->get_value($var)) && ( !&value_is_true($nl->get_value("use_fates_nocomp")))) { | ||
| $log->fatal_error("$var can only be .true. use_fates_nocomp is .true." ); | ||
| } |
There was a problem hiding this comment.
The fates_lu_transition_logic check is missing. This commit ESCOMP@2a838fb
There was a problem hiding this comment.
@JessicaNeedham It has been removed, since there are valid values. in the definitions. see: ESCOMP/CTSM@2bed67f
Bringin updates from ESCOMP.
For NorESM configurations this primarily means updating parameter files and merging few conflicts.