Skip to content

Draw the comparison and GO plots with openms-insight - #282

Merged
t0mdavid-m merged 11 commits into
developfrom
claude/project-thread-4brz6t
Nov 13, 2026
Merged

t0mdavid-m merged 11 commits into
developfrom
claude/project-thread-4brz6t

Conversation

@t0mdavid-m

@t0mdavid-m t0mdavid-m commented Nov 13, 2026 •

Copy link
Copy Markdown
Member

What this does

The plots of a comparison of runs and of the GO view were Plotly figures. They are now openms-insight SeriesPlot components, so they look and behave like the other plots in the Viewer: the same mode bar, zoom, SVG export, theme and fonts. OpenDDA draws the same plots the same way.

Moved to SeriesPlot:

  • Identification and label-free QC: proteoforms per run, how often a proteoform is found, total intensity per run, CV per condition, match-between-runs score, and feature intensity per run.
  • Comparison steps: where missing values occur, observed vs. imputed values, intensity distributions before and after normalization (horizontal boxes), and the p-value distribution.
  • Isobaric QC: reporter intensity per label, ratio to the reference label, and labels found per spectrum.
  • GO view: most significant terms and most frequent terms, as horizontal bars with the first term at the top and every term labelled. The GO category (buttons above the plot) and the number of terms (Top n in its toolbar) are picked in the plot itself. One GO terms table follows the picked category.

No grey notes under the plots. The notes that sat under the QC plots are gone. Two of them asked for action: replicates loaded unlike, and labels found in under half of the spectra. Those two now show as a warning, and only when the condition holds.

The views of a grid row line up. Each view of a comparison grid row takes the height of the row's tallest view (quant_cells.row_height). The normalization view grows with the number of samples, and the view beside it grows with it. Views that size themselves, such as the summary metrics, GO and the PrSM sequence and spectrum, are not counted. A view alone in its row keeps its own height.

How the code is organized:

  • src/render/series.py draws a small table as a SeriesPlot, cached by its content and settings. It also thins box data to at most 201 evenly spaced values per box, which draw the same box.
  • comparison_plots.py, postprocessing_plots.py and the GO chart functions now return tables plus plot settings, not figures.
  • filter_threshold_curve was not used anywhere and was removed.

What changes visually: SeriesPlot has no stacked bars, reference lines or colour scales. So:

  • stacked bars are now grouped;
  • medians and the expected p-value count are in the plot titles;
  • GO fold enrichment and adjusted p-values are in the hover text.

Depends on

t0mdavid-m/OpenMS-Insight#101 (bar and box modes, horizontal orientation) and t0mdavid-m/OpenMS-Insight#104 (views picked in the plot, Top n menu), both merged. requirements.txt stays at openms-insight==0.7.5, which holds neither; the pin is bumped to a release holding both when the next app release is prepared. Until then these plots need openms-insight installed from its main branch.

Screenshots

Comparison of four label-free runs, QC view. Before: in the first, fourth and fifth rows, the two panels end at different heights. After: every row lines up.

Before After
before after

TMT comparison, QC view:

QC TMT

GO terms of the tested proteoforms. The category and the number of terms are picked in the plot, and the table follows:

Biological process Cellular component Dark theme

Tests

  • pytest tests/: 1148 passed, 2 skipped. New tests in tests/test_series_plots.py cover box thinning, the cache fingerprint, the GO chart tables and the row height.
  • pylint --errors-only is clean on the changed files.

🤖 Generated with Claude Code

https://claude.ai/code/session_01FkEGemhZJqShow7AQz5c3q

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01FkEGemhZJqShow7AQz5c3q
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01FkEGemhZJqShow7AQz5c3q
@coderabbitai

coderabbitai Bot commented Nov 13, 2026 •

Copy link
Copy Markdown
Contributor

Important

  • Trigger review

This repository does not receive automatic reviews because it has fewer than 10 stars.

Run configuration

  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: Organization UI
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: 3d12ff70-22ef-4892-b291-8e4679d4d1d4
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

Share

A note that asks for action (replicates loaded unlike, labels found in under
half of the spectra) is a warning now; the others are gone.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01FkEGemhZJqShow7AQz5c3q
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01FkEGemhZJqShow7AQz5c3q
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01FkEGemhZJqShow7AQz5c3q
Every view of a row takes the height of its tallest one, so the panels of
a row end together.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01FkEGemhZJqShow7AQz5c3q
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01FkEGemhZJqShow7AQz5c3q
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01FkEGemhZJqShow7AQz5c3q
The GO category and the number of terms are now chosen in the openms-insight
SeriesPlot itself (buttons above it, a Top n menu in its toolbar). The plot
writes the picked category to the state and one GO terms table filters on it.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01FkEGemhZJqShow7AQz5c3q
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01FkEGemhZJqShow7AQz5c3q
@t0mdavid-m
t0mdavid-m merged commit 00587ea into develop Nov 13, 2026
18 checks passed
@t0mdavid-m
t0mdavid-m deleted the claude/project-thread-4brz6t branch November 13, 2026 20:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants