Repository navigation
Draw the comparison and GO plots with openms-insight - #282
Merged
Merged
Conversation
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01FkEGemhZJqShow7AQz5c3q
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01FkEGemhZJqShow7AQz5c3q
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01FkEGemhZJqShow7AQz5c3q
Contributor
|
Important
This repository does not receive automatic reviews because it has fewer than 10 stars.
|
A note that asks for action (replicates loaded unlike, labels found in under half of the spectra) is a warning now; the others are gone. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01FkEGemhZJqShow7AQz5c3q
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01FkEGemhZJqShow7AQz5c3q
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01FkEGemhZJqShow7AQz5c3q
Every view of a row takes the height of its tallest one, so the panels of a row end together. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01FkEGemhZJqShow7AQz5c3q
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01FkEGemhZJqShow7AQz5c3q
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01FkEGemhZJqShow7AQz5c3q
The GO category and the number of terms are now chosen in the openms-insight SeriesPlot itself (buttons above it, a Top n menu in its toolbar). The plot writes the picked category to the state and one GO terms table filters on it. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01FkEGemhZJqShow7AQz5c3q
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01FkEGemhZJqShow7AQz5c3q
This was referenced Nov 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this does
The plots of a comparison of runs and of the GO view were Plotly figures. They are now openms-insight
SeriesPlotcomponents, so they look and behave like the other plots in the Viewer: the same mode bar, zoom, SVG export, theme and fonts. OpenDDA draws the same plots the same way.Moved to
SeriesPlot:No grey notes under the plots. The notes that sat under the QC plots are gone. Two of them asked for action: replicates loaded unlike, and labels found in under half of the spectra. Those two now show as a warning, and only when the condition holds.
The views of a grid row line up. Each view of a comparison grid row takes the height of the row's tallest view (
quant_cells.row_height). The normalization view grows with the number of samples, and the view beside it grows with it. Views that size themselves, such as the summary metrics, GO and the PrSM sequence and spectrum, are not counted. A view alone in its row keeps its own height.How the code is organized:
src/render/series.pydraws a small table as aSeriesPlot, cached by its content and settings. It also thins box data to at most 201 evenly spaced values per box, which draw the same box.comparison_plots.py,postprocessing_plots.pyand the GO chart functions now return tables plus plot settings, not figures.filter_threshold_curvewas not used anywhere and was removed.What changes visually:
SeriesPlothas no stacked bars, reference lines or colour scales. So:Depends on
t0mdavid-m/OpenMS-Insight#101 (bar and box modes, horizontal orientation) and t0mdavid-m/OpenMS-Insight#104 (views picked in the plot, Top n menu), both merged.
requirements.txtstays atopenms-insight==0.7.5, which holds neither; the pin is bumped to a release holding both when the next app release is prepared. Until then these plots need openms-insight installed from its main branch.Screenshots
Comparison of four label-free runs, QC view. Before: in the first, fourth and fifth rows, the two panels end at different heights. After: every row lines up.
TMT comparison, QC view:
GO terms of the tested proteoforms. The category and the number of terms are picked in the plot, and the table follows:
Tests
pytest tests/: 1148 passed, 2 skipped. New tests intests/test_series_plots.pycover box thinning, the cache fingerprint, the GO chart tables and the row height.pylint --errors-onlyis clean on the changed files.🤖 Generated with Claude Code
https://claude.ai/code/session_01FkEGemhZJqShow7AQz5c3q