Repository navigation
Explore results: draw bar, box and GO plots with Plotly on openms-insight 0.7.5 - #297
Open
t0mdavid-m wants to merge 1 commit into
Open
t0mdavid-m wants to merge 1 commit into
t0mdavid-m wants to merge 1 commit into
Conversation
….7.5 The comparison and GO plots (#282) pass modes and arguments that the pinned openms-insight 0.7.5 does not have, so Explore results raised a ValueError. show_series now checks the installed SeriesPlot and draws the same table with Plotly when it lacks them, until a release holding them is pinned. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01KyJg47YNaoYnCCj1QYkHEy
t0mdavid-m
marked this pull request as ready for review
November 14, 2026 16:40
Contributor
|
Important
This repository does not receive automatic reviews because it has fewer than 10 stars.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Before: on
develop, opening Explore results on a comparison crashes withValueError: mode must be 'lines', 'markers' or 'lines+markers', got 'bars'(src/render/series.py:46, called fromsrc/render/go_view.py:207). The cause is #282, which draws the comparison and GO plots withSeriesPlotbar and box modes, horizontal orientation and views. Those features are only on openms-insight's main branch, whilerequirements.txtpinsopenms-insight==0.7.5, the newest release. Every install fromrequirements.txtis affected, Docker and the desktop apps included. The daily usability check reported it in a fresh workspace and in the demo workspace.After: the page loads. When the installed
SeriesPlotlacks an argument or mode the plot needs,show_seriesdraws the same table with Plotly instead:Once a release with t0mdavid-m/OpenMS-Insight#101 and #104 is pinned,
SeriesPlotdraws these plots again with no further change.How:
series.supports()checks the installedSeriesPlot.__init__signature for every argument passed, and fororientationwhen the mode is bars or box.series.figure()builds the Plotly figure from the table (Streamlit-free), and_show_plotly()adds the view and Top n controls.Tests:
tests/test_series_plots.py: 8 passed, including new tests forsupports()andfigure().pylint --errors-onlyis clean onseries.py.Generated by Claude Code