Skip to content

Explore results: draw bar, box and GO plots with Plotly on openms-insight 0.7.5 - #297

Open
t0mdavid-m wants to merge 1 commit into
developfrom
claude/project-thread-rfg7be-series-fallback
Open

t0mdavid-m wants to merge 1 commit into
developfrom
claude/project-thread-rfg7be-series-fallback

Conversation

@t0mdavid-m

Copy link
Copy Markdown
Member

Before: on develop, opening Explore results on a comparison crashes with ValueError: mode must be 'lines', 'markers' or 'lines+markers', got 'bars' (src/render/series.py:46, called from src/render/go_view.py:207). The cause is #282, which draws the comparison and GO plots with SeriesPlot bar and box modes, horizontal orientation and views. Those features are only on openms-insight's main branch, while requirements.txt pins openms-insight==0.7.5, the newest release. Every install from requirements.txt is affected, Docker and the desktop apps included. The daily usability check reported it in a fresh workspace and in the demo workspace.

After: the page loads. When the installed SeriesPlot lacks an argument or mode the plot needs, show_series draws the same table with Plotly instead:

  • bars and boxes are grouped by series, in the series colours, with the hover text;
  • horizontal plots put the category on the vertical axis, first entry at the top;
  • for the GO chart, the category and the Top n are picked with controls above the plot, and the picked category is written to the same state identifier, so the GO terms table still follows it.

Once a release with t0mdavid-m/OpenMS-Insight#101 and #104 is pinned, SeriesPlot draws these plots again with no further change.

How: series.supports() checks the installed SeriesPlot.__init__ signature for every argument passed, and for orientation when the mode is bars or box. series.figure() builds the Plotly figure from the table (Streamlit-free), and _show_plotly() adds the view and Top n controls.

Tests:

  • tests/test_series_plots.py: 8 passed, including new tests for supports() and figure().
  • pylint --errors-only is clean on series.py.
  • The usability check run against this branch reports FLASHApp OK: 14 page visits, Explore results included.

Generated by Claude Code

….7.5

The comparison and GO plots (#282) pass modes and arguments that the pinned
openms-insight 0.7.5 does not have, so Explore results raised a ValueError.
show_series now checks the installed SeriesPlot and draws the same table
with Plotly when it lacks them, until a release holding them is pinned.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01KyJg47YNaoYnCCj1QYkHEy
@t0mdavid-m
t0mdavid-m marked this pull request as ready for review November 14, 2026 16:40
@coderabbitai

coderabbitai Bot commented Nov 14, 2026

Copy link
Copy Markdown
Contributor

Important

  • Trigger review

This repository does not receive automatic reviews because it has fewer than 10 stars.

Run configuration

  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: Organization UI
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: 2220d468-b0e0-4875-87c7-13227b5bbcb1
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

Share

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants