Skip to content

Implements the internals of the remote asset protocol - #1816

Merged
palfrey merged 1 commit into
TraceMachina:mainfrom
palfrey:remote-asset-internals
Jun 12, 2025
Merged

palfrey merged 1 commit into
TraceMachina:mainfrom
palfrey:remote-asset-internals

Conversation

@palfrey

@palfrey palfrey commented Jun 6, 2025 •

Copy link
Copy Markdown
Member

Description

Previously I'd added support for the Remote Asset protocol, but purely in a stub "doesn't actually do anything form". This PR adds support for actually adding resources to the store and retrieving them, making Buildstream support usable.

Type of change

Please delete options that aren't relevant.

  • New feature (non-breaking change which adds functionality)

How Has This Been Tested?

Mainly with buildstream-with-nativelink-test. The "hello world" test as that now runs fully cached on the second run of that locally. More advanced Buildstream configs might still break in some way, but hopefully not.

Checklist

  • Updated documentation if needed
  • Tests added/amended
  • bazel test //... passes locally
  • PR is contained in a single commit, using git amend see some docs

This change is Reviewable

Comment thread nativelink-service/src/fetch_server.rs Resolved

This branch was previously deployed

1 inactive deployment
production — 90b41ed4 Deployed Jun 12, 2025 by palfrey
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants