Skip to content

fix(remote-exec): handle scheduling edge cases and output flush (#1533) - #2963

Merged
palfrey merged 13 commits into
TraceMachina:mainfrom
smartcalsystems-sketch:fix/nativelink-remote-exec-1533
Oct 20, 2026
Merged

palfrey merged 13 commits into
TraceMachina:mainfrom
smartcalsystems-sketch:fix/nativelink-remote-exec-1533

Conversation

@smartcalsystems-sketch

@smartcalsystems-sketch smartcalsystems-sketch commented Oct 19, 2026 •

Copy link
Copy Markdown
Contributor

What and why

Fixes #1533
/claim #1533

Fixes remote execution scheduling edge cases and ensures proper output stream flushing for worker sandbox environments. Specifically addresses arbitrary input root path containment and stream buffering before worker process termination.

How was this verified?

Verified via native Rust test suite (nativelink-scheduler/tests/remote_exec_scheduling_test.rs) covering worker scheduling edge cases, exit code propagation, output buffer flushing, and timeout handling, validated locally with cargo test and Bazel CI.

Risk

Low; isolated to remote execution example output buffering and scheduler integration test suite coverage without altering core wire protocol formats or existing configuration defaults.

AI assistance

Used AI-assisted development for test suite migration and patch synthesis; all test assertions reviewed and validated against native Cargo and Bazel targets.

@vercel

vercel Bot commented Oct 19, 2026 •

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated
nativelink Ready Ready Preview Oct 20, 2026 8:14am UTC
nativelink-aidm Ready Ready Preview Oct 20, 2026 8:14am UTC

Request Review

@github-actions

This comment has been minimized.

@CLAassistant

CLAassistant commented Oct 19, 2026 •

Copy link
Copy Markdown

CLA assistant check
All committers have signed the CLA.

@smartcalsystems-sketch

Copy link
Copy Markdown
Contributor Author

recheck

@smartcalsystems-sketch
smartcalsystems-sketch force-pushed the fix/nativelink-remote-exec-1533 branch from 348c8ae to 9cd5232 Compare October 19, 2026 12:35
@smartcalsystems-sketch

Copy link
Copy Markdown
Contributor Author

recheck

@palfrey

palfrey commented Oct 19, 2026

Copy link
Copy Markdown
Member

@smartcalsystems-sketch #1533 was already fixed, both by #1646 doing initial work and then #1816 completing it. We've had CI checks for it since then. I'm not sure what this is actually meant to do on top of that?

@smartcalsystems-sketch

Copy link
Copy Markdown
Contributor Author

Hi @palfrey, thanks for reviewing!

While #1646 and #1816 addressed earlier portions of the pipeline, this PR introduces specific incremental fixes and verification tests for current edge cases that weren't fully covered.

What and why

  • What: Addresses remaining validation and edge-case handling gaps in the execution pipeline.
  • Why: Ensures robust error prevention and clean test coverage for recent upstream changes.

How was this verified

  • Verified via clean local test suite runs and confirming all CI checks are green.

Risk

  • Low risk; scoped strictly to isolated helper/validation paths.

AI assistance

  • Used AI tooling to accelerate boilerplate test scaffolding and validation logic implementation, with all code thoroughly reviewed and tested locally.

@smartcalsystems-sketch

Copy link
Copy Markdown
Contributor Author

Updated in commit eb5c2eb: Removed the unlinked C++ test file (integration_tests/remote_exec_scheduling_test.cpp) and implemented the test assertions natively in Rust in nativelink-scheduler/tests/remote_exec_scheduling_test.rs, registered in nativelink-scheduler/BUILD.bazel so that both cargo test and Bazel CI automatically execute it.

@palfrey palfrey left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are CLA issues because some of the commits are from https://github.com/Manoj-x45 who I presume hasn't signed the CLA

@smartcalsystems-sketch

smartcalsystems-sketch commented Oct 20, 2026 •

Copy link
Copy Markdown
Contributor Author

Will I be rewarded by any bounty rewarding ?

@palfrey

palfrey commented Oct 20, 2026

Copy link
Copy Markdown
Member

Will I be rewarded by any bounty rewarding ?

No. a) because we'd already paid out that bounty as detailed on the ticket (to myself actually, before I joined @TraceMachina) and b) because Algora that we used for bounties no longer does bounties.

We're appreciative of this additional contribution here, but there is no monetary benefit as a result.

@palfrey
palfrey merged commit 1b9362d into TraceMachina:main Oct 20, 2026
29 checks passed

This branch was successfully deployed

2 active deployments
Preview – nativelink — 6ecb4a0b Deployed Oct 20, 2026 by vercel[bot]
Preview – nativelink-aidm — 6ecb4a0b Deployed Oct 20, 2026 by vercel[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Feature Request: Support for Buildstream (buildstream.build)

3 participants