Repository navigation
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This comment has been minimized.
This comment has been minimized.
|
recheck |
348c8ae to
9cd5232
Compare
|
recheck |
|
@smartcalsystems-sketch #1533 was already fixed, both by #1646 doing initial work and then #1816 completing it. We've had CI checks for it since then. I'm not sure what this is actually meant to do on top of that? |
|
Hi @palfrey, thanks for reviewing! While What and why
How was this verified
Risk
AI assistance
|
|
Updated in commit |
eb5c2eb to
d26abcb
Compare
palfrey
left a comment
There was a problem hiding this comment.
There are CLA issues because some of the commits are from https://github.com/Manoj-x45 who I presume hasn't signed the CLA
b39eb80 to
591f43b
Compare
* Update Rust crate zip to v9 [SECURITY] * Fix MODULE.bazel.lock --------- Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Co-authored-by: Tom Parker-Shemilt <tom@tracemachina.com>
f835478 to
6f763ee
Compare
|
Will I be rewarded by any bounty rewarding ? |
No. a) because we'd already paid out that bounty as detailed on the ticket (to myself actually, before I joined @TraceMachina) and b) because Algora that we used for bounties no longer does bounties. We're appreciative of this additional contribution here, but there is no monetary benefit as a result. |
What and why
Fixes #1533
/claim #1533
Fixes remote execution scheduling edge cases and ensures proper output stream flushing for worker sandbox environments. Specifically addresses arbitrary input root path containment and stream buffering before worker process termination.
How was this verified?
Verified via native Rust test suite (
nativelink-scheduler/tests/remote_exec_scheduling_test.rs) covering worker scheduling edge cases, exit code propagation, output buffer flushing, and timeout handling, validated locally withcargo testand Bazel CI.Risk
Low; isolated to remote execution example output buffering and scheduler integration test suite coverage without altering core wire protocol formats or existing configuration defaults.
AI assistance
Used AI-assisted development for test suite migration and patch synthesis; all test assertions reviewed and validated against native Cargo and Bazel targets.