Repository navigation
Re-add tracing to sim - #3152
Merged
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
palfrey
marked this pull request as ready for review
November 9, 2026 15:58
amankrx
approved these changes
Nov 9, 2026
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What and why
Machete flagged the
tracinglibrary as unused bynativelink-simin #3150 and so I removed it. This was fine in Bazel, but broke cargo builds. This PR re-adds it.It also updates the Bazel 8 lockfile to fix https://github.com/TraceMachina/nativelink/actions/runs/42648181381/job/129267023725
How was this verified?
cargo test -p nativelink-sim. See also https://github.com/TraceMachina/nativelink/actions/runs/42634436189/job/129218750384Risk
Low. Although, that was my opinion on #3150 and that's what broke this, so unsure.
AI assistance
None