Skip to content

Re-add tracing to sim - #3152

Merged
palfrey merged 4 commits into
TraceMachina:mainfrom
palfrey:tracing-for-sim
Nov 9, 2026
Merged

palfrey merged 4 commits into
TraceMachina:mainfrom
palfrey:tracing-for-sim

Conversation

@palfrey

@palfrey palfrey commented Nov 9, 2026 •

Copy link
Copy Markdown
Member

What and why

Machete flagged the tracing library as unused by nativelink-sim in #3150 and so I removed it. This was fine in Bazel, but broke cargo builds. This PR re-adds it.

It also updates the Bazel 8 lockfile to fix https://github.com/TraceMachina/nativelink/actions/runs/42648181381/job/129267023725

How was this verified?

cargo test -p nativelink-sim. See also https://github.com/TraceMachina/nativelink/actions/runs/42634436189/job/129218750384

Risk

Low. Although, that was my opinion on #3150 and that's what broke this, so unsure.

AI assistance

None

@vercel

vercel Bot commented Nov 9, 2026 •

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated
nativelink Ready Ready Preview Nov 9, 2026 4:46pm UTC
nativelink-aidm Ready Ready Preview Nov 9, 2026 4:46pm UTC

Request Review

@palfrey
palfrey merged commit c7d1230 into TraceMachina:main Nov 9, 2026
19 checks passed
@palfrey
palfrey deleted the tracing-for-sim branch November 9, 2026 16:56

This branch was successfully deployed

2 active and 1 inactive deployments
public-ci — a0ad0140 Deployed Nov 9, 2026 by palfrey via NativeLink / Linux (PR) #554
Preview – nativelink — a0ad0140 Deployed Nov 9, 2026 by vercel[bot]
Preview – nativelink-aidm — a0ad0140 Deployed Nov 9, 2026 by vercel[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants