Repository navigation
Split out main code to lib for testing - #3150
Merged
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This comment has been minimized.
This comment has been minimized.
palfrey
commented
Nov 9, 2026
Member
Author
There was a problem hiding this comment.
This was already a problem, but probably flagged because I was editing another Cargo.toml
palfrey
marked this pull request as ready for review
November 9, 2026 12:49
amankrx
approved these changes
Nov 9, 2026
This was referenced Nov 9, 2026
Merged
MarcusSorealheis
added a commit
that referenced
this pull request
Nov 18, 2026
Lets a distribution register additional store implementations without carrying them in this tree. An `external` store spec selects a provider by name with a passthrough config value, and the store factory builds it through a registry the embedding binary populates before startup (the library split in #3150 is what makes such a binary possible). The stock binary registers no providers: an `external` spec there fails at startup naming the unknown provider and the registered (empty) set. Regenerates the main config reference.
MarcusSorealheis
added a commit
that referenced
this pull request
Nov 19, 2026
Lets a distribution register additional store implementations without carrying them in this tree. An `external` store spec selects a provider by name with a passthrough config value, and the store factory builds it through a registry the embedding binary populates before startup (the library split in #3150 is what makes such a binary possible). The stock binary registers no providers: an `external` spec there fails at startup naming the unknown provider and the registered (empty) set. Regenerates the main config reference.
MarcusSorealheis
added a commit
that referenced
this pull request
Nov 19, 2026
Lets a distribution register additional store implementations without carrying them in this tree. An `external` store spec selects a provider by name with a passthrough config value, and the store factory builds it through a registry the embedding binary populates before startup (the library split in #3150 is what makes such a binary possible). The stock binary registers no providers: an `external` spec there fails at startup naming the unknown provider and the registered (empty) set. Regenerates the main config reference.
MarcusSorealheis
added a commit
that referenced
this pull request
Nov 20, 2026
Lets a distribution register additional store implementations without carrying them in this tree. An `external` store spec selects a provider by name with a passthrough config value, and the store factory builds it through a registry the embedding binary populates before startup (the library split in #3150 is what makes such a binary possible). The stock binary registers no providers: an `external` spec there fails at startup naming the unknown provider and the registered (empty) set. Regenerates the main config reference.
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What and why
We had a large
nativelink.rsbinary source file (~1100 lines) which is relatively hard to test. This PR trims that to ~15% of that and moves most of the functionality into a separatelib.rsand adds an initial basic test to that. This isn't a big gain on it's own, but it opens up options for testing new endpoints and other changes to the core functionality there that weren't there before.How was this verified?
It's primarily a refactor, so mostly just the existing test suite. I've also added a new test that lets us run the server standalone with a config and verify that responds, which is the core feature this unlocks.
Risk
Low. Mostly just a refactor. If CI passes, it's fine :)
AI assistance
None