Skip to content

Azurite test runner assumed access to transient dependencies - #3181

Merged
palfrey merged 3 commits into
mainfrom
azurite-deps
Nov 13, 2026
Merged

palfrey merged 3 commits into
mainfrom
azurite-deps

Conversation

@palfrey

@palfrey palfrey commented Nov 11, 2026 •

Copy link
Copy Markdown
Member

What and why

The azurite test runner assumed access at the top-level to a number of transient dependencies it never declared a need to be able to access. When we swapped out bun for pnpm we broke that. See https://github.com/TraceMachina/nativelink/actions/runs/42977804493/job/130380878091 and https://github.com/TraceMachina/nativelink/actions/runs/42977057964

How was this verified?

Locally running pnpm install / pnpm run test as per the failing CI lane, and https://github.com/TraceMachina/nativelink/actions/runs/43054171346

Note there are still flaky tests in that build (which is a future PR) and the Windows build breaks (which is #3180) but this PR fixes the Set up Azurite test runner step

Risk

Low. It's some extra dependencies declared, all of which are installed anyways. The only thing this does is add top-level links to them in node_modules so we can import them.

AI assistance

None

@vercel

vercel Bot commented Nov 11, 2026 •

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated
nativelink Ready Ready Preview Nov 13, 2026 3:37am UTC
nativelink-aidm Ready Ready Preview Nov 13, 2026 3:37am UTC

Request Review

@palfrey
palfrey merged commit 933bd22 into main Nov 13, 2026
41 checks passed
@palfrey
palfrey deleted the azurite-deps branch November 13, 2026 08:18

This branch was successfully deployed

2 active and 1 inactive deployments
Preview – nativelink — 011ac621 Deployed Nov 13, 2026 by vercel[bot]
Preview – nativelink-aidm — 011ac621 Deployed Nov 13, 2026 by vercel[bot]
cluster-ci-benchmark — 011ac621 Deployed Nov 13, 2026 by MarcusSorealheis via NativeLink / Linux (PR) #724
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants