Repository navigation
Azurite test runner assumed access to transient dependencies - #3181
Merged
Merged
Conversation
palfrey
temporarily deployed
to
cluster-ci-benchmark
November 11, 2026 12:55 — with
GitHub Actions
Inactive
palfrey
temporarily deployed
to
cluster-ci-benchmark
November 11, 2026 14:19 — with
GitHub Actions
Inactive
palfrey
marked this pull request as ready for review
November 11, 2026 14:33
MarcusSorealheis
temporarily deployed
to
cluster-ci-benchmark
November 11, 2026 15:35 — with
GitHub Actions
Inactive
MarcusSorealheis
temporarily deployed
to
cluster-ci-benchmark
November 11, 2026 15:35 — with
GitHub Actions
Inactive
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
MarcusSorealheis
temporarily deployed
to
cluster-ci-benchmark
November 11, 2026 15:36 — with
GitHub Actions
Inactive
MarcusSorealheis
previously approved these changes
Nov 11, 2026
palfrey
force-pushed
the
azurite-deps
branch
from
November 11, 2026 16:00
18810eb to
2949eed
Compare
palfrey
temporarily deployed
to
cluster-ci-benchmark
November 11, 2026 16:00 — with
GitHub Actions
Inactive
palfrey
temporarily deployed
to
cluster-ci-benchmark
November 11, 2026 16:00 — with
GitHub Actions
Inactive
palfrey
temporarily deployed
to
cluster-ci-benchmark
November 11, 2026 16:00 — with
GitHub Actions
Inactive
palfrey
temporarily deployed
to
cluster-ci-benchmark
November 11, 2026 16:18 — with
GitHub Actions
Inactive
MarcusSorealheis
approved these changes
Nov 13, 2026
MarcusSorealheis
temporarily deployed
to
cluster-ci-benchmark
November 13, 2026 03:36 — with
GitHub Actions
Inactive
MarcusSorealheis
temporarily deployed
to
cluster-ci-benchmark
November 13, 2026 03:36 — with
GitHub Actions
Inactive
MarcusSorealheis
temporarily deployed
to
cluster-ci-benchmark
November 13, 2026 03:36 — with
GitHub Actions
Inactive
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What and why
The azurite test runner assumed access at the top-level to a number of transient dependencies it never declared a need to be able to access. When we swapped out bun for pnpm we broke that. See https://github.com/TraceMachina/nativelink/actions/runs/42977804493/job/130380878091 and https://github.com/TraceMachina/nativelink/actions/runs/42977057964
How was this verified?
Locally running
pnpm install/pnpm run testas per the failing CI lane, and https://github.com/TraceMachina/nativelink/actions/runs/43054171346Note there are still flaky tests in that build (which is a future PR) and the Windows build breaks (which is #3180) but this PR fixes the
Set up Azurite test runnerstepRisk
Low. It's some extra dependencies declared, all of which are installed anyways. The only thing this does is add top-level links to them in
node_modulesso we can import them.AI assistance
None