Skip to content

Windows also needs ShutdownGuard - #3180

Merged
palfrey merged 4 commits into
mainfrom
windows-shutdownguard
Nov 11, 2026
Merged

palfrey merged 4 commits into
mainfrom
windows-shutdownguard

Conversation

@palfrey

@palfrey palfrey commented Nov 11, 2026 •

Copy link
Copy Markdown
Member

What and why

Windows builds currently fail due to an error during #3150 where ShutdownGuard was mistakenly marked as Unix-only.

How was this verified?

CI runs is the only option I have given a lack of Windows machine locally. https://github.com/TraceMachina/nativelink/actions/runs/43039580959/job/130587486764 in CI does this though.

Note the Azurite test runner step still fails, which is #3181

Risk

Worst case it'll break Windows builds that are already broken

AI assistance

None

@vercel

vercel Bot commented Nov 11, 2026 •

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated
nativelink Ready Ready Preview Nov 11, 2026 2:59pm UTC
nativelink-aidm Ready Ready Preview Nov 11, 2026 2:59pm UTC

Request Review

@palfrey
palfrey temporarily deployed to cluster-ci-benchmark November 11, 2026 14:58 — with GitHub Actions Inactive
@palfrey
palfrey temporarily deployed to cluster-ci-benchmark November 11, 2026 14:59 — with GitHub Actions Inactive
@palfrey
palfrey temporarily deployed to cluster-ci-benchmark November 11, 2026 15:00 — with GitHub Actions Inactive
@palfrey
palfrey merged commit 395006f into main Nov 11, 2026
35 checks passed
@palfrey
palfrey deleted the windows-shutdownguard branch November 11, 2026 15:08

This branch was successfully deployed

2 active and 1 inactive deployments
cluster-ci-benchmark — afff91e7 Deployed Nov 11, 2026 by palfrey via Build shared Nix package #9522
Preview – nativelink — afff91e7 Deployed Nov 11, 2026 by vercel[bot]
Preview – nativelink-aidm — afff91e7 Deployed Nov 11, 2026 by vercel[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants