Repository navigation
Windows also needs ShutdownGuard - #3180
Merged
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
palfrey
temporarily deployed
to
cluster-ci-benchmark
November 11, 2026 12:55 — with
GitHub Actions
Inactive
palfrey
temporarily deployed
to
cluster-ci-benchmark
November 11, 2026 14:31 — with
GitHub Actions
Inactive
palfrey
temporarily deployed
to
cluster-ci-benchmark
November 11, 2026 14:31 — with
GitHub Actions
Inactive
palfrey
temporarily deployed
to
cluster-ci-benchmark
November 11, 2026 14:31 — with
GitHub Actions
Inactive
palfrey
marked this pull request as ready for review
November 11, 2026 14:45
amankrx
approved these changes
Nov 11, 2026
palfrey
temporarily deployed
to
cluster-ci-benchmark
November 11, 2026 14:47 — with
GitHub Actions
Inactive
palfrey
temporarily deployed
to
cluster-ci-benchmark
November 11, 2026 14:47 — with
GitHub Actions
Inactive
palfrey
temporarily deployed
to
cluster-ci-benchmark
November 11, 2026 14:58 — with
GitHub Actions
Inactive
palfrey
temporarily deployed
to
cluster-ci-benchmark
November 11, 2026 14:58 — with
GitHub Actions
Inactive
palfrey
temporarily deployed
to
cluster-ci-benchmark
November 11, 2026 14:59 — with
GitHub Actions
Inactive
palfrey
temporarily deployed
to
cluster-ci-benchmark
November 11, 2026 15:00 — with
GitHub Actions
Inactive
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What and why
Windows builds currently fail due to an error during #3150 where
ShutdownGuardwas mistakenly marked as Unix-only.How was this verified?
CI runs is the only option I have given a lack of Windows machine locally. https://github.com/TraceMachina/nativelink/actions/runs/43039580959/job/130587486764 in CI does this though.
Note the Azurite test runner step still fails, which is #3181
Risk
Worst case it'll break Windows builds that are already broken
AI assistance
None