Repository navigation
ci: run trusted fork builds once before merge - #3219
Merged
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
MarcusSorealheis
temporarily deployed
to
cluster-ci-benchmark
November 17, 2026 23:42 — with
GitHub Actions
Inactive
MarcusSorealheis
temporarily deployed
to
cluster-ci-benchmark
November 18, 2026 01:41 — with
GitHub Actions
Inactive
MarcusSorealheis
temporarily deployed
to
cluster-ci-benchmark
November 18, 2026 01:41 — with
GitHub Actions
Inactive
MarcusSorealheis
temporarily deployed
to
cluster-ci-benchmark
November 18, 2026 02:52 — with
GitHub Actions
Inactive
MarcusSorealheis
temporarily deployed
to
cluster-ci-benchmark
November 18, 2026 02:52 — with
GitHub Actions
Inactive
amankrx
approved these changes
Nov 18, 2026
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What and why
Run trusted fork contributions through the retained Bazel and shared Nix build lanes before merge, without also running the full hosted PR Bazel suite. This closes the coverage gap exposed after #3210 while removing the duplicate Bazel invocation observed on #3219.
The protected-base policy lists the six maintainer-supplied account/fork pairs: amankrx, palfrey, corcillo, MarcusSorealheis, modernmedici, and matdexir. GitHub account and repository IDs were verified against the API. Automatic promotion requires matching PR author, fork owner/repository, and a listed triggering account; policy is never loaded from the fork.
The coordinator promotes the exact commit to an immutable upstream branch, dispatches only workflows without an existing run for that SHA, and publishes
ci/trusted-builds. Existing failures require explicit retry. Internal PRs reuse push builds, with missing builds dispatched when a path-filtered push skipped the latest head. Nix automatic dispatch usesscope=branchto omit nightly Cargo and the three integration jobs. Initial reporter notifications are reduced from seven to three; unlisted forks retain local tests and manual promotion.Both LRE toolchain jobs move from pull-request and push events to a daily 07:30 UTC schedule, with manual dispatch retained. A job-level event guard also skips mirrored PR/push runs. Main keeps write-capable cache credentials; manual runs on other refs use read-only credentials.
How was this verified?
Risk
Listing an account authorizes its qualifying future commits to run with trusted CI credentials and the retained client. The coordinator executes only base/default-branch code, but needs contents/actions/status write permissions to create branches, dispatch workflows, and publish results. If GitHub rejects promotion of changed workflow files because additional permissions are needed, the documented manual promotion path remains available.
After merge, require
ci/trusted-buildson main while retaining existing checks and the up-to-date requirement. The status remains advisory until that repository setting is applied. Fork branches must incorporate the new routing and Nix dispatch input from main. Primary Bazel/Nix builds on main and ordinary fork-workflow approval settings are unchanged. LRE-specific regressions will be detected by nightly or manual runs rather than every PR/push. This does not repair the underlying remote-execution or Buildkite failures.AI assistance
Codex drafted and validated the workflows, policy, reporter, tests, and documentation at the maintainer's request. The maintainer supplied the trusted accounts and fork URLs.