Skip to content

Remove the trusted build coordinator - #3243

Open
MarcusSorealheis wants to merge 4 commits into
mainfrom
ci/remove-trusted-builds
Open

MarcusSorealheis wants to merge 4 commits into
mainfrom
ci/remove-trusted-builds

Conversation

@MarcusSorealheis

@MarcusSorealheis MarcusSorealheis commented Nov 20, 2026 •

Copy link
Copy Markdown
Member

What and why

Removes the trusted build coordinator added in #3219.

  • Security: trusted-build-status.yaml ran on pull_request_target with contents: write, actions: write and statuses: write, and the token-permissions scan flags all three. It could create branches and dispatch credentialed workflows for fork commits.
  • Reliability: its ci/trusted-builds status depended on builds on the retained cluster client. Those failed for reasons unrelated to the pull request under test, for example the shared Nix package build running out of disk on the client.

Removed: the coordinator workflow, ci_trusted_builds.py, ci_trust.py, their tests, trusted-contributors.json, the scope input of the Nix workflow, and the coordinator sections of the CI README.

Restored: repository pull requests run the Bazel suite on the hosted runner with remote execution, as before #3219. Fork pull requests keep read-only caching and receive no cluster credentials.

Kept from #3219: the LRE workflow stays on its nightly schedule. The fork build-results workflow is a separate feature and is unchanged.

How was this verified?

  • python3 -m unittest discover -s .github/scripts -p 'test_*.py': 91 tests pass, 9 skipped because grpcio-tools is not installed locally. test_ci_benchmark.py again asserts that the pull request job holds no cluster or cloud identity settings and that repository pull requests require remote execution.
  • The change is git revert of ci: run trusted fork builds once before merge #3219 with lre.yaml left at its current content; it applied without conflicts on top of the later AWS lane changes, which are untouched.
  • No remaining references to the removed scripts, the contributor list or the coordinator workflow.
  • Not verified: a repository pull request run of the restored hosted job. This pull request's own run is the first one.

Risk

  • Repository pull requests again depend on the build service configured in the cluster-ci-benchmark environment for remote execution. If that service is unavailable or its environment does not accept pull request refs, the restored job fails with "This PR requires remote execution".
  • Open pull requests keep a stale ci/trusted-builds status on their current head. It is not a required check on main, so it does not block merging.
  • The existing ci-approved/* branches are left in place and can be deleted separately.
  • Fork contributions no longer get an automatic credentialed build; a maintainer reviews and promotes a commit to a repository branch by hand, as the README describes.

AI assistance

Generated with Claude Code under human steering.

🤖 Generated with Claude Code


This change is Reviewable

Reverts the trusted fork build change (#3219) except for its move of the
LRE workflow to a nightly schedule. The coordinator workflow ran on
pull_request_target with write access to contents, actions and commit
statuses, and its status depended on retained-client builds that failed
for reasons unrelated to the pull request.

Repository pull requests build on the hosted runner with remote execution
again; fork pull requests keep read-only caching.
@vercel

vercel Bot commented Nov 20, 2026 •

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated
nativelink Ready Ready Preview Nov 20, 2026 3:07pm UTC
nativelink-aidm Ready Ready Preview Nov 20, 2026 3:07pm UTC

Request Review

This branch had an error being deployed

2 failed and 2 active deployments
Preview – nativelink — 7f8d74b4 Deployed Nov 20, 2026 by vercel[bot]
Preview – nativelink-aidm — 7f8d74b4 Deployed Nov 20, 2026 by vercel[bot]
cluster-ci-benchmark — 7f8d74b4 Deployed Nov 20, 2026 by MarcusSorealheis via NativeLink / Linux (PR) #979
cluster-ci-aws — 7f8d74b4 Deployed Nov 20, 2026 by MarcusSorealheis via Build shared Nix package #9653
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants