Repository navigation
Remove the trusted build coordinator - #3243
Open
MarcusSorealheis wants to merge 4 commits into
Open
MarcusSorealheis wants to merge 4 commits into
MarcusSorealheis wants to merge 4 commits into
Conversation
Reverts the trusted fork build change (#3219) except for its move of the LRE workflow to a nightly schedule. The coordinator workflow ran on pull_request_target with write access to contents, actions and commit statuses, and its status depended on retained-client builds that failed for reasons unrelated to the pull request. Repository pull requests build on the hosted runner with remote execution again; fork pull requests keep read-only caching.
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
MarcusSorealheis
temporarily deployed
to
cluster-ci-benchmark
November 20, 2026 06:27 — with
GitHub Actions
Inactive
MarcusSorealheis
temporarily deployed
to
cluster-ci-benchmark
November 20, 2026 06:27 — with
GitHub Actions
Inactive
MarcusSorealheis
temporarily deployed
to
cluster-ci-benchmark
November 20, 2026 06:27 — with
GitHub Actions
Inactive
palfrey
temporarily deployed
to
cluster-ci-aws
November 20, 2026 10:30 — with
GitHub Actions
Inactive
palfrey
had a problem deploying
to
cluster-ci-aws
November 20, 2026 10:30 — with
GitHub Actions
Failure
palfrey
had a problem deploying
to
cluster-ci-benchmark
November 20, 2026 10:30 — with
GitHub Actions
Failure
MarcusSorealheis
had a problem deploying
to
cluster-ci-aws
November 20, 2026 13:56 — with
GitHub Actions
Failure
MarcusSorealheis
temporarily deployed
to
cluster-ci-aws
November 20, 2026 13:56 — with
GitHub Actions
Inactive
MarcusSorealheis
had a problem deploying
to
cluster-ci-benchmark
November 20, 2026 13:56 — with
GitHub Actions
Failure
MarcusSorealheis
had a problem deploying
to
cluster-ci-aws
November 20, 2026 15:06 — with
GitHub Actions
Failure
MarcusSorealheis
had a problem deploying
to
cluster-ci-aws
November 20, 2026 15:06 — with
GitHub Actions
Failure
MarcusSorealheis
had a problem deploying
to
cluster-ci-benchmark
November 20, 2026 15:06 — with
GitHub Actions
Failure
This branch had an error being deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What and why
Removes the trusted build coordinator added in #3219.
trusted-build-status.yamlran onpull_request_targetwithcontents: write,actions: writeandstatuses: write, and the token-permissions scan flags all three. It could create branches and dispatch credentialed workflows for fork commits.ci/trusted-buildsstatus depended on builds on the retained cluster client. Those failed for reasons unrelated to the pull request under test, for example the shared Nix package build running out of disk on the client.Removed: the coordinator workflow,
ci_trusted_builds.py,ci_trust.py, their tests,trusted-contributors.json, thescopeinput of the Nix workflow, and the coordinator sections of the CI README.Restored: repository pull requests run the Bazel suite on the hosted runner with remote execution, as before #3219. Fork pull requests keep read-only caching and receive no cluster credentials.
Kept from #3219: the LRE workflow stays on its nightly schedule. The fork build-results workflow is a separate feature and is unchanged.
How was this verified?
python3 -m unittest discover -s .github/scripts -p 'test_*.py': 91 tests pass, 9 skipped becausegrpcio-toolsis not installed locally.test_ci_benchmark.pyagain asserts that the pull request job holds no cluster or cloud identity settings and that repository pull requests require remote execution.git revertof ci: run trusted fork builds once before merge #3219 withlre.yamlleft at its current content; it applied without conflicts on top of the later AWS lane changes, which are untouched.Risk
cluster-ci-benchmarkenvironment for remote execution. If that service is unavailable or its environment does not accept pull request refs, the restored job fails with "This PR requires remote execution".ci/trusted-buildsstatus on their current head. It is not a required check onmain, so it does not block merging.ci-approved/*branches are left in place and can be deleted separately.AI assistance
Generated with Claude Code under human steering.
🤖 Generated with Claude Code
This change is