Repository navigation
Add external store provider hooks - #3221
Draft
MarcusSorealheis wants to merge 1 commit into
Draft
MarcusSorealheis wants to merge 1 commit into
MarcusSorealheis wants to merge 1 commit into
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
MarcusSorealheis
force-pushed
the
feature/external-store-providers
branch
from
November 18, 2026 17:27
0da41ec to
eb82780
Compare
MarcusSorealheis
temporarily deployed
to
cluster-ci-benchmark
November 18, 2026 17:27 — with
GitHub Actions
Inactive
MarcusSorealheis
temporarily deployed
to
cluster-ci-benchmark
November 18, 2026 17:27 — with
GitHub Actions
Inactive
MarcusSorealheis
force-pushed
the
feature/external-store-providers
branch
from
November 19, 2026 17:07
eb82780 to
642e318
Compare
MarcusSorealheis
temporarily deployed
to
cluster-ci-benchmark
November 19, 2026 17:08 — with
GitHub Actions
Inactive
MarcusSorealheis
temporarily deployed
to
cluster-ci-benchmark
November 19, 2026 17:08 — with
GitHub Actions
Inactive
MarcusSorealheis
force-pushed
the
feature/external-store-providers
branch
from
November 19, 2026 21:49
642e318 to
a6fcd18
Compare
MarcusSorealheis
had a problem deploying
to
cluster-ci-aws
November 19, 2026 21:49 — with
GitHub Actions
Failure
MarcusSorealheis
temporarily deployed
to
cluster-ci-benchmark
November 19, 2026 21:49 — with
GitHub Actions
Inactive
MarcusSorealheis
temporarily deployed
to
cluster-ci-benchmark
November 19, 2026 21:49 — with
GitHub Actions
Inactive
MarcusSorealheis
temporarily deployed
to
cluster-ci-benchmark
November 19, 2026 23:37 — with
GitHub Actions
Inactive
MarcusSorealheis
temporarily deployed
to
cluster-ci-benchmark
November 19, 2026 23:37 — with
GitHub Actions
Inactive
Lets a distribution register additional store implementations without carrying them in this tree. An `external` store spec selects a provider by name with a passthrough config value, and the store factory builds it through a registry the embedding binary populates before startup (the library split in #3150 is what makes such a binary possible). The stock binary registers no providers: an `external` spec there fails at startup naming the unknown provider and the registered (empty) set. Regenerates the main config reference.
MarcusSorealheis
force-pushed
the
feature/external-store-providers
branch
from
November 20, 2026 17:02
f053407 to
58c0dc2
Compare
MarcusSorealheis
temporarily deployed
to
cluster-ci-aws
November 20, 2026 17:02 — with
GitHub Actions
Inactive
MarcusSorealheis
temporarily deployed
to
cluster-ci-aws
November 20, 2026 17:02 — with
GitHub Actions
Inactive
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Note
No version change. This PR deliberately bumps nothing: every crate stays at its current version. A release PR will be stacked on top of this branch when the next release is cut.
What and why
A distribution that links additional store implementations into the server has no way to register them today short of forking the store factory. This adds that seam in two logic-free pieces: an
externalstore spec (providername plus a passthroughconfigvalue), and a provider registry innativelink-storethatstore_factoryconsults. The library split from #3150 already lets a distribution embed the server, so no changes undersrc/are needed: an embedding binary registers its providers and then builds the stock server.The stock binary registers no providers: an
externalspec there fails at startup naming the unknown provider and the (empty) registered set, so a config/binary mismatch is diagnosable from the first lines of output, and every successful external-store construction is logged with its provider name.How was this verified?
New regression tests, both exercising new surface (they do not compile without the change):
nativelink-config/tests/external_spec_test.rs: the spec parses with and withoutconfig(defaulting to an empty object), rejects unknown fields, and requiresprovider.nativelink-store/tests/external_store_test.rs: a registered test provider builds a working store throughstore_factoryand round-trips data through the fullStoreAPI; an unregistered provider fails withInvalidArgumentnaming the provider and listing what is registered; duplicate registration is refused withAlreadyExists.Beyond that, locally on this branch (rebased onto current
main):cargo testacrossnativelink-configandnativelink-storepasses (39 suites, 559 tests, 0 failures); a fullcargo test --workspacepasses; under Bazel,//nativelink-config/...and the new store test target pass with the rustfmt and clippy aspects;cargo clippyis clean for the touched crates. The main config reference page was regenerated (gen:config-reference main) and the docslint:snippetsandlint:anchorsgates pass. Not verified locally: a real deployment; no cluster ran this build.Risk
The
externalspec is new, opt-in config surface and inert unless a config names it: with no provider registered (the stock binary), naming it is a clean startup failure. Stores nested inside an external provider'sconfigare opaque to config-wide processing such asgrpcstore adjustments; the spec documents this. There are no version, CLI, wire-protocol, orsrc/changes.AI assistance
Generated with Claude Code under human steering.
🤖 Generated with Claude Code