Skip to content
This repository was archived by the owner on Sep 6, 2021. It is now read-only.
This repository was archived by the owner on Sep 6, 2021. It is now read-only.

[quick edit] quick editor not open when function name has non ascii chars. #3941

Open

Description

@jodyzhang
  1. paste following code in brackets:
function frenchçProp(){
}

put cursor on the function name, press command + E to open quick editor
->it can't open. however if remove char ç, then quick editor shows up.

Expect:
open quick editor on non ascii char as function name

Activity

  1. ghost assigned on Jun 3, 2013
  2. gruehle commented on Jun 3, 2013

    @gruehle
    Member

    Probably related to #3940. To @dloverin

  3. dloverin commented on Jun 7, 2013

    @dloverin

    Look like a code mirror issue with cm.getTokenAt(cursor). The token.string returned is incorrect for non-ascii characters. I'll report the issue.

  4. dloverin commented on Jun 7, 2013

    @dloverin
  5. redmunds commented on Mar 17, 2014

    @redmunds
    Contributor

    Was assigned to tern team, so marking "Needs Review".

  6. self-assigned this
    on Apr 1, 2014
  7. dangoor commented on Apr 24, 2014

    @dangoor
    Contributor

    Note Marijn's comment from the issue open on CodeMirror: this is an issue with how the modes are written and to fix this generically would potentially have memory and performance impacts.

  8. dangoor commented on Apr 24, 2014

    @dangoor
    Contributor

    CodeMirror has had a lot of work done over the past 11 months so it's worth checking to see if the behavior has improved, but I'm not hopeful of that given Marijn's comment.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions