Repository navigation
Conversation
… or setParameters fails Expand the try block in AvaticaParameterBinder.bind(List<TypedValue>, int) to cover the parameter count check, parameters.setRowCount(index + 1), and preparedStatement.setParameters(parameters) so that any RuntimeException thrown before ownership is handed off closes the parameter VectorSchemaRoot.
lidavidm
approved these changes
Nov 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What's Changed
Follow-up to #1441 (#1439).
Expand the
tryblock inAvaticaParameterBinder.bind(List<TypedValue>, int)to cover the initial parameter-count check as well asparameters.setRowCount(index + 1)andpreparedStatement.setParameters(parameters)(up toparametersHandedOff = true), so that anyRuntimeExceptionthrown before ownership is handed off to the prepared statement closesparameters:parameters.setRowCount(index + 1)callssetValueCounton each vector, which can still allocate buffers (for example, child vector buffers of aFixedSizeListVectorwhennullwas bound) and throwOutOfMemoryException.preparedStatement.setParameters(parameters)can also throw beforeparametersHandedOffis set totrue.Added unit tests in
AvaticaParameterBinderTestcovering bothsetRowCount(OutOfMemoryException) andsetParameters(IllegalStateException) failures.Closes #1458.