Repository navigation
feat(split-finder): support splitting based on the resulting number of canisters - #12038
Open
pierugo-dfinity wants to merge 1 commit into
Open
pierugo-dfinity wants to merge 1 commit into
pierugo-dfinity wants to merge 1 commit into
Conversation
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
There are no active review issues for the change adding canister-count balancing.
No open issues 🎉
What changed in this PR
Adds canisters_installed as a load type so the subnet split finder can balance canister counts using its existing optimizer.
Changes:
- Exposes the new load type among supported options.
- Assigns each canister one unit of load, unaffected by baseline subtraction.
- Adds tests for unit loads and an even 10/10 split of 20 canisters.
| File | Description |
|---|---|
rs/recovery/subnet_splitting/split_finder/split_finder.py |
Registers the new supported load type. |
rs/recovery/subnet_splitting/split_finder/split_finder_test.py |
Tests canister-count loading and balanced splitting. |
rs/recovery/subnet_splitting/split_finder/data_io.py |
Defines canisters_installed and assigns unit loads. |
Review effort: Balanced
pierugo-dfinity
marked this pull request as ready for review
November 6, 2026 14:25
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Support splitting a subnet by optimizing according to the resulting number of canisters on each subnet.
To do so, we support
canisters_installedas a new load type. In that case, we naturally label each canister as having a load of 1: the optimizer will then optimize in such a way that each resulting subnet has the same "load", i.e. the same "number of canisters".Tested locally.
A following PR will also add support for optimizing according to the resulting state sizes.