You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
feat(split-finder): support splitting a subnet across multiple load types - #12089
Extend split-finder to split a subnet according to multiple load metrics, attempting to satisfy each of them. For example, splitting a subnet w.r.t instructions executed AND canisters installed (with --load-type instructions_executed canisters_installed). (Note: canisters_installed is only supported after #12038)
Each load can give a different epsilon to prioritize one over another.
The solver was actually already solving for multiple load types within solve_partition. This PR extends the CLI arguments to pass a list of all requested loads instead of a singleton.
The reason will be displayed to describe this comment to others. Learn more.
🔵 Needs a closer look
The PR description advertises canisters_installed as a load type, but the CLI rejects it and the exported CSV lacks the column, so the metric must be implemented or the example corrected.
No open issues 🎉
1 previously missed issue
In code that hasn't changed since last review
Example load type is unsupported and absent from exported CSV
The PR description's example --load-type instructions_executed canisters_installed is rejected here because canisters_installed is absent from LOAD_TYPES. The exported CSV also has no such column, so merely adding it to the choices would fail in the loader. Please either support it by deriving a vector of ones for current canister rows (as post_split_estimations.rs derives the installed count), without baseline subtraction, or update the description to use a supported metric.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Extend
split-finderto split a subnet according to multiple load metrics, attempting to satisfy each of them. For example, splitting a subnet w.r.t instructions executed AND canisters installed (with--load-type instructions_executed canisters_installed). (Note:canisters_installedis only supported after #12038)Each load can give a different epsilon to prioritize one over another.
The solver was actually already solving for multiple load types within
solve_partition. This PR extends the CLI arguments to pass a list of all requested loads instead of a singleton.