Repository navigation
fix(each): Defer a commit the leg deadline kills instead of failing it - #2967
Merged
Merged
Conversation
Port of duckdb/duckdb-r#2921 (ea7a655f8). A commit the leg's `timeout` kills (exit 124) after the leg has decided another commit outran the time the others left, which says nothing about the commit. `scripts/each-shard.sh` now leaves it undecided, with no record, so the next run builds it like a commit the deadline never let start. The leg's first commit had the whole budget, so its kill is still recorded as a failure, which `scripts/series-check.sh` calls REPAIR. Both scripts take the hunks of #2921 unchanged, and `.series-source` moves to that commit with their new blobs. rigraph's own text said every kill is a repair: the repair reference and the playbook's table in the `series-loop` skill, and the legs paragraph of `handbook/operations/ci/per-commit/`. They now say a later commit's kill is deferred and retried, and the first commit's stays a repair. `scripts/each-shard-test.sh` pins both cases offline. It injects stubs for `rcc-one.sh` and the store through `EACH_SHARD_HERE`, and `gh` on `PATH`, and runs two legs side by side under a one-minute deadline, the shortest the shard takes, so the kill is real and the test runs for about a minute. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01JXnA76zWTu4ZD8BQCSYRpk
This was referenced Oct 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Port of duckdb/duckdb-r#2921 (head ea7a655f8, still open there).
A commit the leg's
timeoutkills (exit 124) after the leg has decided another commit only outran the time the others left, which says nothing about the commit.scripts/each-shard.shnow leaves it undecided, with no record, no index line and nothing published, so the next run builds it like a commit the deadline never let start. The leg's first commit had the whole budget, so its kill is still recorded as a failure, whichscripts/series-check.shcalls REPAIR. Both scripts take the hunks of duckdb-r#2921 unchanged; they applied tomainwith offsets of one to three lines, and the rigraph layer of both files is the same diff against the new blobs as against the old.rigraph's own text said every kill is a repair that a rerun only repeats. The repair reference (
.claude/skills/series-loop/references/2-repair.md), the playbook's classification table inSKILL.md, and the legs paragraph ofhandbook/operations/ci/per-commit/now say that a later commit's kill is deferred and retried, and that the first commit's stays a repair. No other leaf said a killed commit is recorded as a failure..series-sourcemoves to duckdb-r's ea7a655f8 (dated 2026-10-16, checked today), with the new blobs foreach-shard.sh(10ebf8e1) andseries-check.sh(e03c9f9f). Every other blob it lists is unchanged between the old source commit and the new one, which I checked file by file.scripts/each-shard-test.shis new and pins both cases offline. It injects stubs forrcc-one.sh,rcc-decided.shandrcc-publish.shthroughEACH_SHARD_HERE, the directory the shard resolves its helpers from, andghonPATHfor the statuses. Two legs run side by side underDEADLINE_MINUTES=1, the shortest deadline the shard accepts, so the kill comes from the realtimeoutand the test takes about a minute. Leg one's first commit hangs and is recorded as a failure with exit code 124. Leg two decides a passing and a failing commit, then defers the hanging one: no record, nothing published, its status leftpending. The test passes (20 checks), and fails 6 of them againstmain'seach-shard.sh.scripts/series-args-test.shstill passes (84), shellcheck is clean on the touched scripts, andcheck-handbook.shis clean.Known limit: the planner cannot put a previously deferred commit first. A deferral leaves no record, and
scripts/each-plan.shreads the store and deliberately not the statuses, so it cannot tell a deferred commit from one that never started. Giving it that signal would take a new kind of store entry or a status read in the planner, plus a forced shard boundary ineach-partition.py, which is more than this port should carry. The deferral is bounded as long as nothing below the commit is rewritten. A kill is deferred only after the leg has decided an older commit, the oldest undecided commit always heads shard 1, and a kill there is recorded. So a commit is deferred at most once for each undecided commit older than it, and in the usual case, where only its own leg's tail is left, once. A repair folded below it re-mints the commit and starts that count again.#2968 is stacked on this one.
Prepared with Claude Code, an LLM coding agent.
🤖 Generated with Claude Code
https://claude.ai/code/session_01JXnA76zWTu4ZD8BQCSYRpk