Repository navigation
feat(series): Review a series' R side before any landing, with series-land.sh --review --series - #2970
Merged
krlmlr merged 3 commits intoOct 18, 2026
Conversation
…s-land.sh --review --series` `--review` wrote `<L>-land-review` only from a landing, hid the generated R/C interface, and pushed to the repository it reads `main` from. #2964 was built by hand around all three. `--review --series` writes the branch from `<S>-green`, unflavored by `series-rc.sh` without a push, taking the vendor commits above the series' base, leaving out the tooling syncs and ports `main` has, and refusing while `main` has a change the series lacks. Each commit names its series commit in a `Series-commit:` trailer. `series_review_hidden` in `series-config.sh` says what a review hides: the strand alone for rigraph, whose Stimulus reads the vendored `functions.yaml`, and the strand with its Makevars where it is undefined. `--review-remote` names where the branch is pushed, `--canonical` by default, and the run prints the pull request's head as `<owner>:<branch>`. Every review is kept as a local branch, and named by its full SHA. The first commit says that a `pull_request_target` workflow still runs. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01JXnA76zWTu4ZD8BQCSYRpk
…a review, and keep `R/aaa-*.R` A review showed the whole generated interface, so the glue a reviewer has to read sat among `src/rinterface.c`, the cpp11 registration, the source and dependency lists and the help pages. `series_review_hidden` now names the strand and those files. `R/aaa-*.R` stays, because Stimulus reads the vendored `functions.yaml`, and it is the one place an `_impl()` function the engine adds or removes shows in R terms. The Makevars and `src/vendor/config.h`, which are written by hand, stay too. `src/*.dd` works as an exclude pathspec as `R/aaa-*.R` already did. The test pins what is shown and what is hidden, including a vendor commit that changes generated C alone and is left out. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01JXnA76zWTu4ZD8BQCSYRpk
…, not into the running series A review of the series before any landing said nothing about where its findings go. They are verified one by one, then collected on `main-fwd-build` with what the revdep checks find, and a fresh rebuild from there makes a new generation of the series. Starting it is a person's decision, which the review does not make. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01JXnA76zWTu4ZD8BQCSYRpk
1 task
This was referenced Oct 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stacked on #2966 (base
claude/series-tests-no-engine-gates), which changesscripts/series-land.sh,scripts/series-config.shand the series-land skill too, so this diff shows only the new work. #2966 stands on #2961 and #2959, and #2959 also editshandbook/branches/model/README.md, a different paragraph from the one this PR adds to. None of #2958, #2960, #2962, #2965, #2967, #2968 or #2969 touches these files.Why
The draft review #2964 shows the R side of the
mainseries before any landing, and it had to be built by hand, becausescripts/series-land.sh --reviewfalls short in three ways. It reads only a landing: a--landingref withmainbelow it and vendor commits above. The series instead stands on an oldermain, the flavor pair, the seed and a commit that bringsmain's changes since the seed in front of the vendor commits. It hidesseries_makevarswith the strand, which assumes an interface change shows as atools/stimulus/edit. That holds for duckdb-r, but rigraph's Stimulus also reads the vendoredfunctions.yaml, so the 19_impl()functions the engine removes and the 12 it adds would not show at all. And it pushes to--canonical, where it also readsmain, while #2964's head lives in the fork.What
--review --serieswrites<L>-land-review<s>from<S>-greenon--remote, without a landing. It runsscripts/series-rc.sh <S>without--push, which mints the unflavored twin of every<S>-devcommit and writes no ref, and takes the strand on the remote instead where that is aligned. The review is built ontomainfrom the twins above the series' base, which is the seed and whatever stands in front of the first vendor commit. A tooling sync or a port of a commitmainhas, found among the vendor commits, is left out and listed, by the same rule the landing's replay places one with (placed_by_ruleinseries-forward-build.sh); any other commit there is refused. After the build, the review is held to the series: outside what it hides, it may differ from<S>-green's unflavored twin only inNEWS.md, the READMEs andDESCRIPTION's version. Anything else is a change ofmain's the series has not ported, and the run stops with no ref written. This is the base check #2964 was built with, generalized so that the mode keeps working once the loop portsmain's next changes among the vendor commits. A vendor commit whose diff no longer applies tomainis named. Each review commit carries its series commit's message and author and names it in aSeries-commit:trailer; a landing's review keepsLanding-commit:. The test report is read off the rc twins, which carry the series' engine and vendor subjects, so the tests removed with their upstream function are classified as removals (#2966).series_review_hiddeninscripts/series-config.shnames what a review hides besides the workflows andDESCRIPTION's version. rigraph sets it to the strand and what is generated for the compiler and the help pages:src/rinterface.c,src/cpp11.cpp,R/cpp11.R,src/sources-glue-{c,cpp}.mk,src/*.ddandman/. It keepsR/aaa-*.R, the Stimulus-generated_impl()wrappers, because they are the one place the engine's interface change shows in R terms, and the hand-writtensrc/Makevars.{in,ucrt,win}andsrc/vendor/{config.h,igraph_config.h}. The globs work as git exclude pathspecs, asR/aaa-*.Ralready did inseries_makevars. Whereseries_review_hiddenis undefined, as in duckdb-r's copy, a review hides the strand andseries_makevars, as before. The comments in both scripts that said an interface change shows as itstools/stimulus/change are corrected.--review-remote <name>names where--pushwrites the branch,--canonicalby default, so a landing's review goes where it went before. The printedgh pr createline names the head as<owner>:<branch>, for examplekrlmlr:main-land-review. Every review run now writes a local branch of the review's name and prints the full SHA, so a review that is not pushed can still be read and compared. The commit that removes the workflows says that apull_request_targetworkflow still runs, because it is read frommain:format-suggest.yamlran on #2964.The series-land skill documents the mode, the remote, the local branch, what is shown and hidden, and where a series review's findings go: each is verified, and those that hold are collected on
main-fwd-buildwith what the revdep checks find, for a fresh rebuild that makes a new generation of the series. Starting that generation is a person's decision, which the review does not make.handbook/branches/model/README.mdlists<L>-land-reviewbeside the other landing refs, with a sentence on reviewing a series before any landing.Verification
scripts/series-land-test.shpasses 129 checks (84 before). Its new section 14 builds a series seeded on an oldermain, withmain's fix brought in front of its vendor commits as one commit, a tooling sync and a port among them, an interface-only vendor commit, a vendor commit that changesDESCRIPTIONbeyond its version, and a commit above green. It checks the review's base, the workflow commit and its message, the engine and version kept frommain, the unflavored package, the interface's R half and the hand-written build files shown, its C half, the registration, the source and dependency lists andman/hidden, a vendor commit that changes generated C alone left out, nothing above green, the subjects, theSeries-commit:trailer and message, the test report, the local branch without--push, the push to--review-remotewith the<owner>:head, the same SHA from a rerun and from an aligned rc strand, the hidden Makevars whereseries_review_hiddenis undefined, and the refusals: a change ofmain's the series lacks, a vendor commit that does not apply tomain, a commit among the vendor commits that is notmain's, and--serieswithout--reviewor with--landing.series-args-test.sh(87),series-lib-test.sh(41),series-tests-test.sh(49),series-forward-build-test.sh(50),series-port-test.sh(17),series-patch-sync-test.sh(32),series-fold-test.sh(26),series-advance-test.sh(149),series-vendor-test.sh(51),vendor-one-test.sh(78) andrcc-store-test.shpass, shellcheck is clean on the changed scripts, andcheck-handbook.shis clean.The review was rebuilt locally for real, without pushing, with
scripts/series-land.sh main --review --series --suffix -hidden --remote origin --canonical upstream --review-remote origin, frommain-greenat krlmlr/rigraph@2242c53ee2 ontomainat 267cc39. It reports 104 of 301 series commits changing the R side, 51 files, +1,778 −1,653, and its test report ends inTESTS KEPT ... but 29 removed with their function upstream. Its diff shows 16R/aaa-*.Rfiles, the Makevars and the two config headers, and no file the configuration hides.Limits
series-rc.shis not changed, because #2958 edits it and this PR is stacked elsewhere, so the mode reads the strand's tip off the lineseries-rc.shprints when it is not aligned, and checks it by itsUnflavored-from:trailer.series-rc.shunflavors all of<S>-dev, so a commit above green that it cannot unflavor stops a review of green too.series-args-test.shis not extended for the two new options, since #2959 to #2961 edit it; both follow the contract, which its existing checks cover.LLM use: this PR was prepared with Claude Code (Claude Opus 5.5), at the maintainer's request.
Generated by Claude Code