Skip to content

feat: show names and states in the plaintext status output - #906

Closed
cchu-ld wants to merge 1 commit into
cchu/aws-devops-3-sso-loginfrom
cchu/aws-devops-4-status
Closed

cchu-ld wants to merge 1 commit into
cchu/aws-devops-3-sso-loginfrom
cchu/aws-devops-4-status

Conversation

@cchu-ld

@cchu-ld cchu-ld commented Oct 20, 2026 •

Copy link
Copy Markdown
Contributor

Requirements

  • I have added test coverage for new or changed functionality
  • I have followed the repository's pull request submission guidelines
  • I have validated my changes against all supported platform versions

Related issues

This PR is part 4 of a stack of 7 PRs for ldcli aws-devops-agent. It goes on PR 3 of the stack. Review and merge the PRs in order.

  1. feat: ask which existing agent space to connect LaunchDarkly to #903 Agent space choice
  2. feat: add AWS regions, send the API version, and shorten credential errors #904 Regions, API version, credential error
  3. feat: offer to run aws sso login when SSO credentials expire #905 aws sso login offer
  4. feat: show names and states in the plaintext status output #906 Readable status output (this PR)
  5. feat: show the setup plan and ask before setup changes AWS #907 Setup plan and confirmation
  6. feat: run the setup plan that setup showed #908 Run the shown plan
  7. feat: choose the setup steps by who made the agent space #909 Ownership rule and existing spaces

Describe the solution you've provided

  • The plaintext status output names each IAM role with a state, not an ARN.
  • Each association names its service, not only the service ID.
  • If nothing is set up, the output names the setup command.
  • The JSON output does not change.

Describe alternatives you've considered

None.

Additional context

Testing: go test ./... and golangci-lint pass on this branch.

🤖 Generated with Claude Code

@cursor cursor Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes using default effort and found 1 potential issue.

Fix All in Cursor

❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, have a team admin enable autofix in the Cursor dashboard.

Reviewed by Cursor Bugbot for commit 6d146a1. Configure here.

_, _ = fmt.Fprintf(out, "\nNothing is set up. %s\n", setupHint)
printConsoleURL(out, status.Region)

return

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Empty status hides existing services

Low Severity

The empty-state path treats missing IAM roles and agent spaces as “nothing is set up” and returns before listing status.Services. Account-level registrations such as an MCP server can still exist in that situation, so plaintext status can hide provisioned services and tell the user to run setup.

Fix in Cursor Fix in Web

Reviewed by Cursor Bugbot for commit 6d146a1. Configure here.

@cchu-ld
cchu-ld added this pull request to stack #910 October 20, 2026 16:53
The status command now names each role with a state, not an ARN. Each
association names its service, not only the service ID. If nothing is
set up, the output names the setup command. The JSON output does not
change.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@cchu-ld
cchu-ld force-pushed the cchu/aws-devops-4-status branch from 6d146a1 to 568a11a Compare October 20, 2026 16:55
@cchu-ld cchu-ld closed this Oct 20, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant