Repository navigation
Conversation
This was referenced Oct 20, 2026
Setup finds its own spaces by the description "Managed by the LaunchDarkly CLI". It runs the full setup on a space that it made. On another space, it only connects the MCP server, unless you pass --auth-flow. The space list marks the spaces that setup made, and the JSON has managedByLdcli. A connect run reads the operator app. If the app is off, setup does not print its URL, and the result has "operatorAppEnabled": false. --agent-space-name has no default. In a terminal, setup asks for the name of a new space. Setup does not provision a space with a name that a space in the region uses. An unattended run with --agent-space-name X uses X, or provisions X if no space has that name. Without a name, it reuses the one space that setup made, or stops. Setup and ConnectExisting move to export_test.go, because only tests use them. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
cchu-ld
force-pushed
the
cchu/aws-devops-7-space-owner
branch
from
October 20, 2026 16:55
e72b392 to
cb180c7
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Requirements
Related issues
This PR is part 7 of a stack of 7 PRs for
ldcli aws-devops-agent. It goes on PR 6 of the stack. Review and merge the PRs in order.Describe the solution you've provided
setupfinds its own spaces by the descriptionManaged by the LaunchDarkly CLI. It runs the full setup on a space that it made. On another space, it only connects the MCP server, unless you pass--auth-flow. The space list marks the spaces thatsetupmade, and the JSON hasmanagedByLdcli.setupdoes not print its URL, and the result has"operatorAppEnabled": false.--agent-space-namehas no default. With a name, Enter at the list picks the space with that name, or a new space with that name. Without a name, the list has no default, and a new space makessetupask for a name.setupdoes not provision a space with a name that a space in the region uses.--agent-space-name Xuses X, or provisions X if no space has that name. Without a name, it reuses the one space thatsetupmade, or stops.SetupandConnectExistingmove toexport_test.go, because only tests use them.Describe alternatives you've considered
A tag on new agent spaces would be a stronger ownership marker than the description.
setupdoes not use one, because it must callListTagsForResourceonce for each space to read tags.Additional context
Testing:
go test ./...andgolangci-lintpass on this branch.I ran
setupagainst a sandbox AWS account. These cases worked: a new space with a typed name, a new space next to existing spaces, and a secondEnableOperatorAppcall (IAM to IAM) on a space whose app is on.Not tested against real AWS:
DevOpsAgentRole-AgentSpaceandDevOpsAgentRole-WebappAdmin.🤖 Generated with Claude Code
Note
Overview
ldcli aws-devops-agent setupnow treats agent spaces differently depending on whether LaunchDarkly created them (descriptionManaged by the LaunchDarkly CLI, surfaced asmanagedByLdcli/ “made by ldcli” in the list). Full setup (IAM, account association, operator app) runs only on those spaces or when you pass--auth-flow; picking someone else’s space is connect-only (MCP registration/association). Connect runs read operator app state: if the app is off, plaintext output skips the URL and JSON includesoperatorAppEnabled: false.Space selection and naming change materially:
--agent-space-namehas no default and drives interactive defaults (Enter matches by name or offers to create that name). Without a name, the list has no default. New spaces must get a unique name (prompt or flag); provisioning refuses names already in use. Unattended/--yes/--output jsonbehavior is spelled out: with--agent-space-name, reuse or create by name (error on ambiguous duplicates); without it, auto-reuse only when exactly one ldcli-managed space exists.README documents the new flows.
Setup/ConnectExistingmove toexport_test.gofor tests only;FindAgentSpaceis removed in favor of the richer resolution helpers.Reviewed by Cursor Bugbot for commit cb180c7. Bugbot is set up for automated code reviews on this repo. Configure here.