Repository navigation
Introduce meson.build - #14
Merged
Merged
Conversation
superna9999
force-pushed
the
meson-build
branch
from
September 21, 2023 07:34
4062e90 to
08e43c1
Compare
Member
|
should we settle on just one? meson is fine in my eyes, it's pretty common |
superna9999
force-pushed
the
meson-build
branch
5 times, most recently
from
September 21, 2023 08:32
9257ce4 to
0cea860
Compare
Member
Author
|
@konradybcio drop makefile ? probably at some point, but we must be confident meson is ok |
Member
|
please rebase |
superna9999
force-pushed
the
meson-build
branch
2 times, most recently
from
September 21, 2023 10:32
a7ef735 to
e47e521
Compare
lumag
marked this pull request as draft
September 21, 2023 14:41
superna9999
force-pushed
the
meson-build
branch
17 times, most recently
from
September 21, 2023 19:49
257eae9 to
4dde958
Compare
superna9999
force-pushed
the
meson-build
branch
4 times, most recently
from
September 21, 2023 20:09
e5cf675 to
552d461
Compare
superna9999
marked this pull request as ready for review
September 21, 2023 20:11
konradybcio
reviewed
Sep 21, 2023
lumag
requested changes
Sep 22, 2023
lumag
left a comment
Contributor
There was a problem hiding this comment.
Generally I'm not sure what is the benefit of switching to meson, other than it being 'newer' than make.
superna9999
force-pushed
the
meson-build
branch
8 times, most recently
from
October 2, 2023 08:56
3a01cd4 to
27f90aa
Compare
Member
Author
|
Well, the biggest point about meson it it's very easy integration with package managers, like: bitbake: debian: apkbuild: arch: (ok not the best example here) rpm spec: gentoo: buildroot: openwrt: |
On ARM the conmux.c around gethostbyname() results in a compiler warning/error: conmux.c:269:27: error: cast increases required alignment of target type [-Werror=cast-align] 269 | saddr.sin_addr = *(struct in_addr *)hent->h_addr_list[0]; Instead of trying to fix the (deprecated) gethostbyname() call, switch conmux to use getaddrinfo(), which is the proper way to resolve addresses. Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
Introduce meson.build to be used with the Meson build system, which handles the dependency and advanced compiler options for when used on various linux distributions. The libftdi .so for example has different names on different distribution, using meson makes sure we can handle those easily, and easily integrate with other package build systems like Yocto or Buildroot. Signed-off-by: Neil Armstrong <neil.armstrong@linaro.org>
superna9999
force-pushed
the
meson-build
branch
from
October 2, 2023 09:12
27f90aa to
7d5982f
Compare
lumag
requested changes
Oct 2, 2023
superna9999
force-pushed
the
meson-build
branch
from
October 2, 2023 12:56
6b60525 to
598c168
Compare
Add x86_64 only meson build for now, meson requires some cross-compile files to be passed. Signed-off-by: Neil Armstrong <neil.armstrong@linaro.org>
Meson requires a cross_compile file for foreign architectures, and also needs the CPU family. Add FAMILY to all matrix entries Remove unused MODE Print PKG_CONFIG_PATH Add i386 special Meson setup case Add cross-compile Meson setup case Signed-off-by: Neil Armstrong <neil.armstrong@linaro.org>
This detects Meson automatically and drops custom build step Signed-off-by: Neil Armstrong <neil.armstrong@linaro.org>
Remove the Makefile and all the references in the README and CI scripts. Signed-off-by: Neil Armstrong <neil.armstrong@linaro.org>
superna9999
force-pushed
the
meson-build
branch
from
October 2, 2023 13:19
4b1e39a to
4225dc8
Compare
Member
Author
|
@lumag done, dropped all references to makefile and switched CodeQL to autobuild |
lumag
approved these changes
Oct 2, 2023
lumag
left a comment
Contributor
There was a problem hiding this comment.
Could you please also delete the Makefile?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Introduce meson.build to be used with the Meson build system, which handles the dependency and advanced compiler options for when used on various linux distributions.
The libftdi .so for example has different names on different distribution, using meson makes sure we can handle those easily, and easily integrate with other package build systems like Yocto or Buildroot.