Repository navigation
Conversation
added 4 commits
September 29, 2023 11:05
Use findstring to determine if gcc or clang is getting used. Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
On ARM the conmux.c around gethostbyname() results in a compiler warning/error: conmux.c:269:27: error: cast increases required alignment of target type [-Werror=cast-align] 269 | saddr.sin_addr = *(struct in_addr *)hent->h_addr_list[0]; Instead of trying to fix the (deprecated) gethostbyname() call, switch conmux to use getaddrinfo(), which is the proper way to resolve addresses. Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
Ubuntu Xenial has very old gcc (5.4.0), which doesn't support significant amount of flags used by our Makefile. Rather than detecting the vesion, circumvent compiler detection by passing cc instead of gcc. Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
Merged
Member
|
IMHO Last commit is quite wrong... but using Meson won't help because the meson version 0.29.0 doesn't even support get_supported_arguments()... |
Contributor
Author
|
@superna9999 Yep. I definitely didn't want to bring up |
Contributor
Author
|
Releveant part was picked into #14. Closing now. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Use findstring to determine if gcc or clang is getting used.