Repository navigation
Declare Python for Vantage-Config - #4052
Conversation
Vantage-Config's CI gates its lint-only `scripts/` tree, with its unittest suite under coverage, through the hub validator, and maps CODECOV_TOKEN for that upload. Declare the python type, the `scripts` directory, and the secret, so the registry records what the repo runs. That clears the audit's registry, python-directories, and stale-secret findings. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Declaring python on Vantage-Config means its pre-commit hook now owes the language-format half too, so the checklist row records the `pre-commit` framework plus doc gates, the shape HomeAutomation-Config's row took when it declared python. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
Important Review skippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the
 |
There was a problem hiding this comment.
🟢 Approval recommended
The reviewed registry and rollout-checklist updates contain no actionable findings.
No open issues 🎉
What changed in this PR
Declares Vantage-Config's existing Python validation and coverage contract in the fleet registry and updates the pre-commit rollout checklist.
Changes:
- Adds the
pythontype,scriptsdirectory, andCODECOV_TOKENrequirement to Vantage-Config. - Updates the rollout checklist with Vantage-Config's Python pre-commit and documentation obligations.
- No actionable findings identified.
| File | Description |
|---|---|
| registry/repos.json | Declares Vantage-Config's Python type, scripts directory, and Codecov secret requirement. |
| docs/pre-commit-hooks-rollout.md | Updates Vantage-Config's rollout requirements to reflect its declared Python tooling. |
Review effort: Lite
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #4052 +/- ##
===========================================
- Coverage 81.60% 79.19% -2.42%
===========================================
Files 26 38 +12
Lines 9070 12769 +3699
===========================================
+ Hits 7402 10113 +2711
- Misses 1668 2656 +988
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
|
A recorded local strict-review pass covers head |
…ry Short Names, Stub Read Grant (#4054) ## Summary Promotes burndown round 1 of the attended run of 2026-11-10 from `develop` to `main`. - #4047: an attested local pass keeps `coverage=local` against a round that only carries a file table. A promotion now reads green Dependabot manifest bumps as covered, through the new `pr_review_promotion.py`. The promotion case also counts an attestation over direct-to-`develop` changes and excuses byte-identical renames. - #4045: the loop skills resume a parked group on a recorded answer, present each question once, accept a clone tip at or behind head, and re-check `deferred` issues whose condition is checkable. An away run's endings that cannot dispatch a promotion worker now report that. - #4046: every registry entry carries a required, gated `shortName`. A changed short name fails the spec gate as a migration. - #4044: `pull-requests: read` on each caller stub's `validate` job, the hub half of #2354. It takes effect once the lint job declares the scope. - #4052, #4053, #4055, from other sessions: registry and rollout-tracker updates. They declare Python for Vantage-Config, register the Employment repository with its short name and pin, and reconcile the HolidayLights entry. Fixes #3955 Fixes #3909 Fixes #3901 Fixes #3905 Fixes #4012 Fixes #3830 Fixes #2669 Fixes #4023 Fixes #4028 #2354 stays open for the lint job's grant and the downstream rollout. 🤖 Generated with [Claude Code](https://claude.com/claude-code)
Declares the
pythontype on the Vantage-Config registry entry, part of a resync against audit run2026-11-11T00:47:59Z | hub 1397e30a | branch override develop.scripts/tree, with its unittest suite under coverage, through the hub validator, and mapsCODECOV_TOKENfor the upload. This edit makes the registry record that. It addspythontotypes,pythonDirectories: ["scripts"], andCODECOV_TOKENtorequiredSecrets, the same shape as HomeAutomation-Config's entry.spec/audit.py --branch develop Vantage-Config: this clears the registry finding, both python-directories findings, and both stale-secret findings, and adds no new one.spec/validate.pypasses.docs/pre-commit-hooks-rollout.md: the Vantage-Config row now owes thepre-commitframework plus doc gates, as HomeAutomation-Config's row did when it declared python. It stays unchecked, since the repo carries no pre-commit config yet.Related, already tracked: #3896 (WORKFLOW.md says operational repos run no unit tests, which this declaration makes false for Vantage-Config).
Local strict review: two rounds recorded. Round 1's one finding was the rollout row, fixed here. Round 2 found nothing.
🤖 Generated with Claude Code