Skip to content

Reconcile the HolidayLights Registry Entry and Rollout Trackers After Its Promotion - #4055

Merged
ptr727 merged 2 commits into
developfrom
registry/holidaylights-drift-20261110
Nov 11, 2026
Merged

ptr727 merged 2 commits into
developfrom
registry/holidaylights-drift-20261110

Conversation

@ptr727

@ptr727 ptr727 commented Nov 11, 2026 •

Copy link
Copy Markdown
Owner

Summary

Reconciles the hub's record of HolidayLights with what its main holds since ptr727/HolidayLights#17 promoted the 2025 and 2026 shows and the fleet baseline. This is the registry step of a HolidayLights resync, audit run 2026-11-11T00:50:25Z | hub 1397e30a | branch override develop.

  • registry/repos.json. Deletes the driftNote saying the 2025 and 2026 show folders and the baseline (ptr727/HolidayLights#11, Update branding and documentation consistency #13-Enforce squash-only merge strategy in GitHub ruleset and workflow #16) wait on develop for a promotion. The audit flagged it as a note asserting pending work.
  • docs/reusable-workflows.md. Ticks HolidayLights in both the merge-bot and the validate-task.yml rows, since its callers have called each by pin since ptr727/HolidayLights#15.
  • docs/eol-lf-rollout.md. Ticks HolidayLights as converted in ptr727/HolidayLights#10, and records its 2026-10-24 reclassification to operational.

Verification

  • spec/validate.py passes, and the registry parses.
  • A read of HolidayLights origin/main confirms each claim: the 2021-2026 show folders, the carried instruction set, a test-pull-request.yml calling validate-task.yml by pin, and * text=auto eol=lf with xlights_effectpresets.json pinned CRLF.
  • Recorded local strict review passes cover the head, and the diff-scoped prose gate is clean.

🤖 Generated with Claude Code

Summary by CodeRabbit

  • Documentation
    • Updated rollout guidance to reflect the repository’s LF line-ending configuration and adoption of merge-bot and validation workflows.
    • Clarified that the effect presets file uses CRLF line endings.
    • Removed an outdated note about show folders and fleet baseline files awaiting promotion.

ptr727 and others added 2 commits November 10, 2026 17:26
Delete the HolidayLights driftNote saying the 2025 and 2026 show
folders and the fleet baseline wait on develop for a develop->main
promotion. ptr727/HolidayLights#17 promoted them, and main now holds
both show folders and the baseline. The audit flags the note because
it asserts pending work.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
The reusable-workflow and LF rollout trackers still list HolidayLights
as not adopted. Its main has called the hub validate-task.yml by pin
since ptr727/HolidayLights#15, and has carried the LF defaults since
ptr727/HolidayLights#10, both promoted in ptr727/HolidayLights#17. The
LF row also names the operational model the registry declares.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Copilot AI lite review requested due to automatic review settings November 11, 2026 01:47
@coderabbitai

coderabbitai Bot commented Nov 11, 2026 •

Copy link
Copy Markdown

Explain Change →

No actionable comments were generated in the recent review.

Walkthrough

The rollout checklist now records HolidayLights’ line-ending setup and adoption of two workflows. The repository registry no longer includes a drift note about show folders and the fleet baseline pending promotion.

Changes: HolidayLights rollout

Layer / File(s) Summary
Line-ending rollout status
docs/eol-lf-rollout.md
The checklist marks HolidayLights operational with lineEndings: lf. It documents the conversion and a CRLF pin for xlights_effectpresets.json.
Workflow adoption and drift status
docs/reusable-workflows.md, registry/repos.json
The checklist records adoption of the merge-bot and validation workflows on develop and main. The registry no longer includes the note about show folders and the fleet baseline pending promotion.

Estimated code review effort: 2 (Simple) | ~8 minutes

Merge Risk: Minimal · up to ccf91

The changes reconcile rollout records. No merge-blocking issue is established, though the external repository status remains independently unverified.

Pre-merge checks: Passed 5

Check name Status Explanation
Description Check Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check Passed The title clearly and concisely describes reconciling the HolidayLights registry and rollout trackers after promotion, matching the main changes.
Docstring Coverage Passed No eligible functions found in the changed files. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff with cyclomatic complexity of at least 2. Documentat…
Linked Issues check Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check Passed Check skipped because no linked issues were found for this pull request.
Full details: Docstring Coverage

Explanation

No eligible functions found in the changed files. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff with cyclomatic complexity of at least 2. Documentation-only edits and deletions within surviving functions are included; unchanged diff context and fully deleted functions are excluded. Analyzed 0 functions across 0 files. (2 skipped: 2 unsupported.)

Finishing Touches

Generate unit tests (beta)

  • Commit to this branch
  • Create a new PR
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

Share

Recent review info

Run configuration

Commits

Reviewing files that changed from the base of the PR and between 3416f61 and ccf9166.

Files selected for processing: 3

  • docs/eol-lf-rollout.md
  • docs/reusable-workflows.md
  • registry/repos.json
Files with no reviewable changes: 1

  • registry/repos.json

Included review availability: This review used your included allowance. Your plan provides up to 1 included review per hour; 0 remain after this review.

@ptr727

ptr727 commented Nov 11, 2026

Copy link
Copy Markdown
Owner Author

A recorded local strict-review pass covers head ccf916670e9bf7d396cf7e010033e5ed7343d4b4, the content this pull request carries at that commit against develop, and it recorded 0 findings.

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔵 Needs a closer look

The registry and rollout claims rely on live ptr727/HolidayLights main state, but the configured GitHub API returned 404, preventing independent verification of those cross-repository facts.

No open issues 🎉

What changed in this PR

This pull request reconciles the HolidayLights registry and rollout trackers with its promoted main state.

Changes:

  • Removes the obsolete registry note describing pending HolidayLights promotion work.
  • Marks HolidayLights as adopted for the merge-bot and validation reusable workflows.
  • Records its operational classification and LF conversion.
  • Requires regeneration of the workflow reuse report to reflect these adoptions.
File Description
registry/​repos.json Removes the outdated drift note describing pending HolidayLights promotion work.
docs/​reusable-workflows.md Marks HolidayLights as adopted for the merge-bot and validation reusable workflows.
docs/​eol-lf-rollout.md Records HolidayLights' completed LF conversion and operational classification.

Review effort: Lite

@codecov

codecov Bot commented Nov 11, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 79.24%. Comparing base (3416f61) to head (ccf9166).
⚠️ Report is 1 commits behind head on develop.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop    #4055   +/-   ##
========================================
  Coverage    79.24%   79.24%           
========================================
  Files           38       38           
  Lines        12802    12802           
========================================
  Hits         10145    10145           
  Misses        2657     2657           
Flag Coverage Δ
python-3.13 79.24% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@ptr727

ptr727 commented Nov 11, 2026

Copy link
Copy Markdown
Owner Author

@coderabbitai review

@ptr727

ptr727 commented Nov 11, 2026

Copy link
Copy Markdown
Owner Author

/review

@coderabbitai

coderabbitai Bot commented Nov 11, 2026 •

Copy link
Copy Markdown
Action performed

Review finished.

Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.

@ptr727

ptr727 commented Nov 11, 2026

Copy link
Copy Markdown
Owner Author

Answering the round on ccf91667 (verdict headline, 0 counted findings): "The registry and rollout claims rely on live ptr727/HolidayLights main state, but the configured GitHub API returned 404, preventing independent verification of those cross-repository facts."

No change needed. ptr727/HolidayLights is private, so the reviewer's token reads a 404 there. The claims were checked against a fetched clone of its main (e226a9e) by read-only git, and by three local strict review passes that re-ran those reads:

@ptr727
ptr727 merged commit 273d4e0 into develop Nov 11, 2026
14 checks passed
@ptr727
ptr727 deleted the registry/holidaylights-drift-20261110 branch November 11, 2026 02:53
ptr727 added a commit that referenced this pull request Nov 11, 2026
…ry Short Names, Stub Read Grant (#4054)

## Summary

Promotes burndown round 1 of the attended run of 2026-11-10 from
`develop` to `main`.

- #4047: an attested local pass keeps `coverage=local` against a round
that only carries a file table. A promotion now reads green Dependabot
manifest bumps as covered, through the new `pr_review_promotion.py`. The
promotion case also counts an attestation over direct-to-`develop`
changes and excuses byte-identical renames.
- #4045: the loop skills resume a parked group on a recorded answer,
present each question once, accept a clone tip at or behind head, and
re-check `deferred` issues whose condition is checkable. An away run's
endings that cannot dispatch a promotion worker now report that.
- #4046: every registry entry carries a required, gated `shortName`. A
changed short name fails the spec gate as a migration.
- #4044: `pull-requests: read` on each caller stub's `validate` job, the
hub half of #2354. It takes effect once the lint job declares the scope.
- #4052, #4053, #4055, from other sessions: registry and rollout-tracker
updates. They declare Python for Vantage-Config, register the Employment
repository with its short name and pin, and reconcile the HolidayLights
entry.

Fixes #3955
Fixes #3909
Fixes #3901
Fixes #3905
Fixes #4012
Fixes #3830
Fixes #2669
Fixes #4023
Fixes #4028

#2354 stays open for the lint job's grant and the downstream rollout.

🤖 Generated with [Claude Code](https://claude.com/claude-code)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants