Complete usage of Faker in generator.py #4

Activity

1. ashwini0529

   added

   enhancement

   hacktoberfest

   on Oct 1, 2017
2. vaibhavsingh97 commented on Oct 1, 2017

   

   vaibhavsingh97

   on Oct 1, 2017

   More actions

   I want to fix this issue 😄
3. willBoyd8 commented on Oct 1, 2017

   

   willBoyd8

   on Oct 1, 2017

   Contributor

   More actions

   How about some networking to get it going? #7.

   It might be beneficial to restructure a little, as all of faker implemented in 1 file could be a bit of a mess...
4. ashwini0529 commented on Oct 1, 2017

   

   ashwini0529

   on Oct 1, 2017

   MemberAuthor

   More actions

   It would be great. @willBoyd8 if you restructure all Faker implementations in one file and use it in generators. 😄
5. willBoyd8 commented on Oct 2, 2017

   

   willBoyd8

   on Oct 2, 2017

   Contributor

   More actions

   See if #13 is what you'd like... That also makes it easy for others ( @vaibhavsingh97 ) to add other functionality too. The month of hacktober is still young... ;)
6. ashwini0529 commented on Oct 3, 2017

   

   ashwini0529

   on Oct 3, 2017

   MemberAuthor

   More actions

   Hey, @willBoyd8 can you please check a comment that I made on your PR?
   That would be ready to merge then. 🎉
7. willBoyd8 commented on Oct 3, 2017

   

   willBoyd8

   on Oct 3, 2017

   Contributor

   More actions

   Yeah sorry. I'm a little slow on weekdays