Skip to content

Added implementation for internet items - #7

Merged
ashwini0529 merged 1 commit into
pytorn:devfrom
willBoyd8:dev
Oct 1, 2017
Merged

ashwini0529 merged 1 commit into
pytorn:devfrom
willBoyd8:dev

Conversation

@willBoyd8

Copy link
Copy Markdown
Contributor

Implemented methods to get all of the standard faker.providers.internet functionality.

Implemented methods to get all of the standard faker.providers.internet functionality
@ashwini0529

ashwini0529 commented Oct 1, 2017 •

Copy link
Copy Markdown
Member

Hey @willBoyd8 looks amazing. Can you please add comments about how to use?

I would suggest you to create a folder Documentation and in that, you can add a Usage.rst.
That would contain sample usage of all the functions that have been implemented.
That would be great IMO. 😄
#4

@willBoyd8

Copy link
Copy Markdown
Contributor Author

Yeah I plan on adding it, but I needed a commit to force me to commit to it :P This is not the last time I pull here...

@ashwini0529
ashwini0529 merged commit 36c65ff into pytorn:dev Oct 1, 2017
@ashwini0529

Copy link
Copy Markdown
Member

Here you go @willBoyd8 😄 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants