Repository navigation
Update GitHub Pages deploy guide with more focus on steps - #12176
Conversation
✅ Deploy Preview for astro-docs-2 ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Lunaria Status Overview🌕 This pull request will trigger status changes. Learn moreBy default, every PR changing files present in the Lunaria configuration's You can change this by adding one of the keywords present in the Tracked Files
Warnings reference
|
|
Per Fryuni remember to add that you cannot have an adapter installed |
Co-authored-by: Junseong Park <39112954+jsparkdev@users.noreply.github.com>
|
Came here from Talking and Doc'ing. |
hkbertoson
left a comment
There was a problem hiding this comment.
I hope i did this review thing right. I dont do it often on Github.
ArmandPhilippot
left a comment
There was a problem hiding this comment.
Unfortunately I wasn't available for T&D, so I don't have the discussion history. I must say I find it a bit confusing to read A value for `base` is required then You do not need a value for`base `. But I know this page is a bit cursed, so this is probably fine. 😅
I only spotted an error I think for the base value. Otherwise, LGTM!
Co-authored-by: Armand Philippot <git@armand.philippot.eu>
bjohansebas
left a comment
There was a problem hiding this comment.
LGTM!, The content looks good to me now
|
LGTM |
delucis
left a comment
There was a problem hiding this comment.
The hero we need, facing down the hydra of deployment guides, where you commit once, and two issues arise. I have no doubt though that Sarah will emerge triumphant! 🐲
Co-authored-by: Chris Swithinbank <swithinbank@gmail.com>
Deploy preview: https://deploy-preview-12176--astro-docs-2.netlify.app/en/guides/deploy/github/
Based on feedback that this guide was difficult to follow, in part because it seemed like the GitHub Action was optional when it's really a required part of using this guide to deploy, this PR restructures the existing content to:
astro.config.mjsto be able to deploy to a GitHub URLOther than reorganizing and turning headings/paragraphs into step items, the content here is unchanged.