Repository navigation
fix(ci): preserve Maven suite results across cache write-back failures - #15274
Conversation
The Managed Agent fast tier can fail without reporting a test result after waiting out the per-host SDK Java lock. #15128 scoped the MariaDB lane's lock to its cache write-back, but the test job still held the same lock across the SDK and Managed Agent Maven suites, so a long full-tier suite could starve the fast tier on that host. Seed the test job's Maven repository from the host cache, run both suites unlocked from that job-local copy, and take the ticketed host lock only for the cache write-back. The write-back children close fd 9 so a cancelled job's survivor cannot retain the lock. Pin the new order and the write-back fd closures in the workflow tests, and update the fair-lock design docs and the workflow size baseline. Fixes #15262 Co-authored-by: Qwen-Coder <qwen-coder@alibabacloud.com>
E2E test reportWhat changedThe self-hosted SDK Java test lane now seeds a job-local Maven repository from the host cache, runs its SDK and Managed Agent Maven suites from that copy without the per-host lock, and takes the ticketed host lock only for the bounded cache write-back. The write-back's children close the inherited lock descriptor so a cancelled job's survivor cannot retain the lock. WhyA fast-tier job can fail before reporting a test result when it waits out its 90-minute host-lock budget behind a long suite hold. The MariaDB lane was already scoped to its write-back; the test lane was the remaining long hold, so a roughly 90-minute full-tier Java 21 leg on the same host could starve the fast tier — the failure shape reported in #15262. E2E test plan
The real pool run is left to CI; this checkout has no Java/Maven toolchain and no self-hosted pool. Local evidence
Verification
中文说明E2E 测试报告改动内容自托管 SDK Java 测试通道现在先从宿主机缓存播种一个 job 本地 Maven 仓库,在不持每宿主机锁的情况下用该副本运行 SDK 和 Managed Agent 两套 Maven 套件,最后只为有界缓存写回获取排队锁。写回的子进程会关闭继承来的锁描述符,因此被取消 job 的幸存进程无法继续持锁。 原因当 fast 档 job 排在长时间套件持锁之后、等满 90 分钟宿主机锁预算时,它会在报告任何测试结果之前失败。MariaDB 通道已经把锁收窄到写回;测试通道是剩下的长时间持锁点,因此同一宿主机上一条约 90 分钟的 full 档 Java 21 leg 可能饿死 fast 档——这正是 #15262 报告的失败形态。 E2E 测试计划
真实 pool 运行留给 CI;本 checkout 没有 Java/Maven 工具链,也没有自托管 pool。 本地证据
验证
|
|
Thanks for the PR! Template looks good ✓ — every required heading is filled in, both design-doc languages are linked, and the two versions carry the same decisions and acceptance criteria. Problem: observed, not theoretical. #15262 is an automated main-CI failure report with a run ( Direction: aligned. The design doc already commits to "hold scope: the write-back, not the suite" and landed it on the MariaDB lane with run-id evidence; this extends that same decision to the second lock site instead of inventing a second mechanism. Worth saying plainly, because the sibling PRs make the cheaper option look tempting: raising the wait budget (#15232, #15257) is a smaller diff, but the design doc rejects exactly that — "a wait budget bounds one attempt, not the wait… no constant budget bounds the queue." So the larger diff here is the correct one, not scope creep. Size: not applicable — no core paths. Production changes are ~83 lines (the workflow step plus one baseline number); the remainder is the guard test and two design docs. Approach: the scope feels right and it reuses what's already there. Two things I'd raise before this merges. First, and this is the one I can't settle from the diff: there are seven open autofix PRs from the same bot editing this same region of Second, a tradeoff the body doesn't name: unlocking the suite means two Maven suites can now run concurrently on one ECS host, where the test job's suite was previously serialized. The cold-host download cost is mentioned; peak resource contention is not. The MariaDB lane already runs its multi-hour verify unlocked and the design doc lists reducing occupancy as an explicit non-goal, so I don't think this blocks anything — it's the thing to watch on the first pool runs. Risk: no elevated risk signals — none of the revert-correlated paths are touched (only The duplicate family doesn't block the code review, so I'm continuing to Stage 2 — but it does need a human decision before merge. 🔍 中文说明感谢贡献! 模板完整 ✓ —— 所有必需标题都已填写,设计文档中英文版本均已链接,两个版本的决策与验收标准一致。 问题: 已观测到,非理论性。#15262 是自动生成的 main CI 失败报告,带有 run( 方向: 对齐。设计文档已经确立"持锁范围:写回,而非套件",并已在 MariaDB 通道落地且附有 run-id 证据;本 PR 是把同一决策扩展到第二处取锁点,而不是另造一套机制。需要明确说明的是(因为兄弟 PR 让更便宜的方案看起来很诱人):提高等待预算(#15232、#15257)diff 更小,但设计文档恰恰否定了这种做法——"等待预算只约束一次尝试,而不约束整个等待……没有任何常量预算能约束队列"。所以这里较大的 diff 是正确的,不是范围蔓延。 规模: 不适用——未触及核心路径。生产代码改动约 83 行(workflow 步骤加一个 baseline 数字);其余是 guard 测试和两份设计文档。 方案: 范围合理,且复用了已有实现。合并前我想提两点。 第一点,也是我从 diff 无法判断的:同一 bot 有 七 个开放 autofix PR 在改 第二点,正文未提及的取舍:套件移出锁后,同一台 ECS 宿主机上现在可能并发运行两套 Maven 套件,而此前 test job 的套件是串行的。正文提到了冷宿主机的下载成本,但没有提到峰值资源争用。MariaDB 通道已经在不持锁的情况下运行数小时的 verify,且设计文档明确把降低占用列为非目标,所以我认为这不构成阻塞——但这是合并后首批 pool 运行需要观察的点。 风险: 无升级风险信号——未触及任何与 revert 相关的路径(仅 重复 PR 家族不阻塞代码审查,因此我继续进入 Stage 2——但合并前确实需要人工决定。🔍 — Qwen Code · qwen3.8-max-2026-09-02 Reviewed at |
Code reviewNo critical blockers. I read the workflow step, the guard test, and the MariaDB lane it mirrors, and verified the parts that can be checked statically. What I checked and cleared:
Non-blocking observations:
CI test evidenceThe PR's own CI, read through the API at the reviewed commit. No check is red. 55 check-runs exist on this SHA; the substantive ones had not started yet at review time, including Final CI results for
One row per check name (latest run); skipped checks omitted; failures sort first. / 每个检查名一行(取最新一次运行),省略 skipped,失败项排在最前。 Not verified: real self-hosted pool behaviour. The guard tests are static shape pins plus a dynamic guard that runs the suite slice against a stubbed Sandboxed verification would settle part of this: 中文说明代码审查无阻塞性问题。我阅读了 workflow 步骤、guard 测试以及它所镜像的 MariaDB 通道,并对可静态验证的部分做了核实。 已核查并排除的问题:
非阻塞观察:
CI 测试证据在被审查的 commit 上通过 API 读取本 PR 自身的 CI。没有 check 变红。 该 SHA 上共有 55 个 check-run;审查时实质性的那些尚未开始,包括 未验证:真实自托管 pool 行为。guard 测试是静态形态 pin,加上一个用 stub 的 沙箱验证可以解决其中一部分: — Qwen Code · qwen3.8-max-2026-09-02 Reviewed at |
|
Confidence: 3/5 — the diff itself is clean and I would merge it on its own merits; what I can't decide is which of seven overlapping autofix PRs should be the one that lands. Going into this I expected to talk myself out of it, and the code didn't give me a reason to. My independent proposal before reading the diff was: point Maven at a job-local repository so concurrent jobs share no mutable state, then lock only a bounded write-back. That is precisely what this does, and it does it by copying a pattern already living in the same file rather than designing a new one. The five things most likely to be wrong — an So this is not a "the code is bad" defer. Two things stop me approving. The duplicate family is the real issue. Seven open autofix PRs from the same bot edit this same region of CI hadn't started. The substantive checks were all still queued at review time, including On the reflection questions: yes, the problem is real and observed (#15262 carries a run ID and a named failing step, not a hypothesis). Yes, six months from now I'd thank the author — the write-back pattern is now consistent across both lock sites instead of one lane being special. And the one reservation I hold about the code itself is that unlocking the suite raises peak concurrency on a shared host, a tradeoff the body doesn't name; I don't think it's blocking, since the MariaDB lane already runs unlocked for hours and the design doc calls reduced occupancy a non-goal, but it's the first thing I'd look at if the pool gets noisier after this lands. ⏸️ Deferring rather than approving — this needs a human call. Specifically: which of #15274 / #15275 / #15254 should land for the test lane, and who closes the other six. Nothing in the diff needs changing to answer that. I could not resolve an accountable owner to @mention, and I'd rather say so than guess a login: no maintainer handle is configured, the PR carries no labels and the owner map is label-driven with every changed path outside 中文说明Confidence: 3/5 —— diff 本身是干净的,单看它我会合并;我无法判断的是七个相互重叠的 autofix PR 中应该由哪一个落地。 开始时我预期会说服自己否掉它,但代码没有给我理由。在读 diff 之前,我的独立方案是:让 Maven 指向 job 本地仓库,使并发 job 之间不共享可变状态,然后只为一次有界写回取锁。这正是本 PR 所做的,而且它是通过复制同一文件中已有的模式实现的,而非另做设计。最可能出错的五点——某个 所以这不是"代码有问题"式的 defer。有两点让我不予批准。 重复 PR 家族是真正的问题。 同一 bot 有七个开放的 autofix PR 在改 CI 尚未开始。 审查时实质性 check 全部仍在排队,包括 关于反思问题:是的,问题真实且已观测(#15262 带有 run ID 和明确的失败步骤名,而非假设)。是的,六个月后我会感谢作者——写回模式现在在两处取锁点上保持一致,而不是让某一条通道成为特例。我对代码本身保留的一点意见是:把套件移出锁会提高共享宿主机上的峰值并发,而正文没有提及这一取舍;我不认为它构成阻塞,因为 MariaDB 通道已经不持锁运行数小时,且设计文档把降低占用列为非目标,但如果合并后 pool 变得更嘈杂,这是我会首先查看的地方。 ⏸️ 选择 defer 而非批准——这需要人工决定。 具体是:测试通道应由 #15274 / #15275 / #15254 中哪一个落地,以及由谁关闭其余六个。回答这个问题不需要修改 diff 中的任何内容。 我无法解析出应当 @ 的负责人,与其猜测一个 login,不如直接说明:未配置维护者 handle,PR 不带任何 label 而 owner 映射由 label 驱动、且所有改动路径都在 — Qwen Code · qwen3.8-max-2026-09-02 Reviewed at |
qwen-code-review-bot
left a comment
There was a problem hiding this comment.
[Critical] Blocking finding(s) follow.
Reviewed. Suggestions are inline.
Unresolved, please confirm:
- [Critical] PR-level triage defer (comment 6348797823, by @qwen-code-review-bot): approval was deferred pending a human merge-order decision across the overlapping autofix family — #15233, #15254, #15257 and #15275 remain OPEN and no human decision is …
Not explored to full depth (tool budget reached): "agent 6a": none — node_modules is absent in this worktree, so I could not execute npx vitest run scripts/tests/sdk-java-workflow.test.js scripts/tests/workflow-size.tes…; "agent 4": npx vitest run scripts/tests/sdk-java-workflow.test.js scripts/tests/workflow-size.test.js — the review worktree has no node_modules , so the rewritten pins ….
Not linted (tool limitation, not a blocker): .github/workflows/sdk-java.yml — actionlint embedded-shell source mapping is not yet supported.
中文说明
已审查。 建议见行内评论。
未决,请确认:共 1 条(原文未翻译,列表见上方英文部分)。
未探索到全部深度(达到工具调用预算):"agent 6a":none — node_modules is absent in this worktree, so I could not execute npx vitest run scripts/tests/sdk-java-workflow.test.js scripts/tests/workflow-size.tes…;"agent 4":npx vitest run scripts/tests/sdk-java-workflow.test.js scripts/tests/workflow-size.test.js — the review worktree has no node_modules , so the rewritten pins …。
未检查(工具限制,非阻断):.github/workflows/sdk-java.yml——actionlint 对 workflow 内嵌 shell 的源映射尚未支持。
— qwen3.8-max via Qwen Code /review (v0.26.0)
|
🕐 Review received — an automatic review of the current head is still running, so this round is held until it lands (a push now would cancel it and discard its work, #8888). Your feedback stays queued for the next eligible round. 中文说明🕐 已收到评审 —— 当前 head 上仍有一轮自动 review 在运行,本轮暂缓(现在推送会取消该 review 并丢弃其工作,#8888)。反馈保持排队,等待下一次可运行的轮次处理。 |
|
🤖 Addressed the latest review feedback (round 1/10). What changed, and what I pushed back on: · 已处理最新评审反馈(第 1/10 轮)。改动内容与我反驳保留之处如下: Autofix review round — PR #15274 (issue #15262)All nine inline suggestions from the automated review were verified against the current code, fixed, and are resolved in code. The review-body merge-order note is a maintainer decision and remains open; it has no inline thread, so there is nothing to resolve on it. No conflicts were present: the round ran with Findings and dispositions
Open question for maintainers[rv:5621767429] The PR-level triage defer asks for a human merge-order decision across the overlapping autofix family: #15233, #15254, #15257 and #15275 remain open. This is a product/merge-order decision, not a code defect, and it is not ours to settle. It is a review-body item with no inline thread, so it is left exactly as raised and is recorded here for the maintainer. Changed files
Verification
Mutation probes run against the same workflow content that was committed; each mutated/negated branch turned the named test red:
中文说明Autofix 审查轮次——PR #15274(issue #15262)自动审查提出的九条行内建议都已对当前代码核实、修复,并在代码中解决。审查正文中的合并顺序说明属于维护者决定,保持未决;它没有行内线程,因此没有可解决的线程。本轮没有冲突:以 发现与处理
维护者未决问题[rv:5621767429] PR 级 triage defer 要求维护者在重叠的 autofix 家族之间做合并顺序决定:#15233、#15254、#15257、#15275 仍未合并。这是产品/合并顺序决定,不是代码缺陷,也不由本轮决定。它是审查正文条目,没有行内线程,因此按原样保留,并在此记录供维护者处理。 改动文件
验证
变异探针针对与提交内容相同的工作流运行;每个被删除或取反的分支都使对应测试变红:
Base-conflict check · 基分支冲突检查: no conflict with main. · 与 main 无冲突。 🧵 Resolved all 9 selected review thread(s). · 已关闭全部选中的 9 条评审线程。 Re-review when you have a moment. After round 10 this bot stops and leaves the PR for a human. · 有空请复审;第 10 轮后本 bot 停止并将 PR 交给人工。 🧠 Handled by Qwen Code · model/模型 |
|
Qwen Code review did not complete successfully. The review pipeline failed before a review could be posted. A transient error is retried automatically; if you are seeing this, retry with |
|
🤖 Reviewed the latest feedback — no changes needed. Why, point by point: · 已审阅最新反馈——无需改动。逐点说明原因如下: No code changes were made this round: the new feedback contains no reviewable findings. What arrived this round
DispositionThe feedback cannot be verified as a code defect, and no claim about current behavior was made, so no probe or fix applies. The review that failed will be retried by the review pipeline; once it posts actual findings they will be triaged on their merits like any other feedback. The branch is unchanged. 中文说明本轮没有做任何代码改动:新的反馈中不包含任何可评审的问题项。 本轮收到的内容
处理结论该反馈无法被验证为代码缺陷,也没有对当前行为提出任何断言,因此不适用复现探针或修复。失败的评审将由评审流水线自动重试;一旦它给出实际的评审意见,将像其他反馈一样按其实质内容进行分诊。分支保持不变。 🧠 Handled by Qwen Code · model/模型 |
qwen-code-review-bot
left a comment
There was a problem hiding this comment.
Partially reviewed — gaps disclosed.
Not explored to full depth (tool budget reached): "agent 6c": executing scripts/tests/sdk-java-workflow.test.js — the review worktree has no node_modules , so every assertion above was traced by hand against the parsed ….
Not reviewed: reverse audit — stopped before round 5 by the review time budget.
Not linted (tool limitation, not a blocker): .github/workflows/sdk-java.yml — actionlint embedded-shell source mapping is not yet supported.
Deferred under the convergence posture (round 2, not a blocker) — recorded, not requested in this round:
.github/workflows/sdk-java.yml:303 — [probe] mkdir -p and cd in the write-back are bare under the restored set -e , so a host-state failure reddens a step whose suite already passedscripts/tests/sdk-java-workflow.test.js:242 — [probe] the executed ordering test's slice end-marker indexOf is never asserted > -1, so rewording one workflow comment silently turns its flock witness into dead code
[Critical] PR-level merge-order blocker carried from the previous round — still stands, and no code change in this diff closes it. Approval was deferred pending a human decision on which of the overlapping autofix PRs should land for the sdk-java test lane. Verified at the reviewed commit: #15233, #15254, #15257 and #15275 all remain OPEN (#15229 and #15232 have since closed), and the mechanism the deferral names still holds — #15254, #15257 and #15275 each edit .github/workflows/sdk-java.yml and each records a different .size-baseline byte count for it (119651, 118481 and 123176 against this PR's 121709), so whichever merges second fails the size ratchet until rebased, and #15233 rewrites the same scripts/tests/sdk-java-workflow.test.js this PR rewrites. No human has reviewed: the only review on the PR is qwen-code-review-bot's COMMENTED, and every comment in the thread is from qwen-code-review-bot or qwen-code-dev-bot. This is a decision for a maintainer — which of #15274 / #15275 / #15254 lands, and who closes the others — not a defect in the diff; nothing in the code needs changing to answer it, and this review's own findings are all Suggestion-level.
中文说明
仅完成部分审查,审查缺口已披露。
未探索到全部深度(达到工具调用预算):"agent 6c":executing scripts/tests/sdk-java-workflow.test.js — the review worktree has no node_modules , so every assertion above was traced by hand against the parsed …。
未审查:反向审计——评审时间预算不足,未能开始第 5 轮。
未检查(工具限制,非阻断):.github/workflows/sdk-java.yml——actionlint 对 workflow 内嵌 shell 的源映射尚未支持。
收敛姿态下延后(第 2 轮,非阻断)——已记录,本轮不要求修改:共 2 条(原文未翻译,列表见上方英文部分)。
[Critical] PR-level merge-order blocker carried from the previous round — still stands, and no code change in this diff closes it. Approval was deferred pending a human decision on which of the overlapping autofix PRs should land for the sdk-java test lane. Verified at the reviewed commit: #15233, #15254, #15257 and #15275 all remain OPEN (#15229 and #15232 have since closed), and the mechanism the deferral names still holds — #15254, #15257 and #15275 each edit .github/workflows/sdk-java.yml and each records a different .size-baseline byte count for it (119651, 118481 and 123176 against this PR's 121709), so whichever merges second fails the size ratchet until rebased, and #15233 rewrites the same scripts/tests/sdk-java-workflow.test.js this PR rewrites. No human has reviewed: the only review on the PR is qwen-code-review-bot's COMMENTED, and every comment in the thread is from qwen-code-review-bot or qwen-code-dev-bot. This is a decision for a maintainer — which of #15274 / #15275 / #15254 lands, and who closes the others — not a defect in the diff; nothing in the code needs changing to answer it, and this review's own findings are all Suggestion-level.
— qwen3.8-max via Qwen Code /review (v0.26.0)
|
🕐 Review received — an automatic review of the current head is still running, so this round is held until it lands (a push now would cancel it and discard its work, #8888). Your feedback stays queued for the next eligible round. 中文说明🕐 已收到评审 —— 当前 head 上仍有一轮自动 review 在运行,本轮暂缓(现在推送会取消该 review 并丢弃其工作,#8888)。反馈保持排队,等待下一次可运行的轮次处理。 |
…15262) The write-back runs after the suite, so the step's exit code must come from the suite: both lanes now track the Maven status, demote only a lock-wait timeout with a step-summary record, and redden when the queue itself is unusable. The wait drops to 1800 s because it guards only the bounded copy; the seed stops hiding cp's diagnosis while staying quiet on a fresh host; the design docs record the head-of-queue stall the shorter hold does not bound.
The previous round changed .github/scripts/sdk-java-lock.sh, which this PR never touched; the deterministic gate rejects that expansion. Restore the helper and keep both call sites on the pre-round `if !` shape, retaining the 1800 s wait and the step-summary record. Drop the status-2 pins and tests that only existed for the reverted helper, and record the unusable-queue gap as a follow-up in the design docs. The timeout-returns test stays. Co-authored-by: Qwen-Coder <qwen-coder@alibabacloud.com>
…code into autofix/issue-15262
|
🤖 Addressed the latest review feedback (round 2/10). What changed, and what I pushed back on: · 已处理最新评审反馈(第 2/10 轮)。改动内容与我反驳保留之处如下: Round summary — PR #15274 (issue #15262)Round: same-run verification repair, plus re-triage of the nine inline findings already fixed in the rejected round. Deterministic rejection repairedThe rejected commit added
Inline findings
Maintainer decisions still open
Verification
中文说明本轮摘要 — PR #15274(issue #15262)本轮为同一轮验证修复,并对上一轮(被拒绝的提交)已修复的 9 条行内 finding 重新分诊。 已修复的确定性验证拒绝被拒绝的提交把
行内 finding
仍需维护者决定
验证
Re-review when you have a moment. After round 10 this bot stops and leaves the PR for a human. · 有空请复审;第 10 轮后本 bot 停止并将 PR 交给人工。 🧠 Handled by Qwen Code · model/模型 |
|
Qwen Code review timed out. Qwen review timed out after 21600 seconds (of the 360-minute budget). This run already used the maximum 360 minute timeout. See workflow logs. |
|
qwen-code-review-bot
left a comment
There was a problem hiding this comment.
No blocking issues. LGTM! ✅
Not fully linted (tool limitation, not a blocker): .github/workflows/sdk-java.yml — actionlint ran workflow-level checks; embedded run: shell deferred (source mapping not yet supported).
Deferred under the convergence posture (round 20, not a blocker) — recorded, not requested in this round:
.github/workflows/sdk-java.yml:469 — [review] New write-back setup arms bypass lock_setup_fault, and the cd arm drops the reason
— deepseek-v4.1-flash-1017@1f214e4e via Qwen Code /review (v0.26.7)
|
qwen-code-review-bot
left a comment
There was a problem hiding this comment.
No blocking issues. LGTM! ✅
Not fully linted (tool limitation, not a blocker): .github/workflows/sdk-java.yml — actionlint ran workflow-level checks; embedded run: shell deferred (source mapping not yet supported).
Deferred under the convergence posture (round 21, not a blocker) — recorded, not requested in this round:
.github/workflows/sdk-java.yml:1018 — [review] MySQL missing-checkout guard is untested: reverting cd packages/managed-agent-server || mvn_status=$? to a bare cd reds nothing while dropping the deferred status, the 300 s clamp, the stag….github/workflows/sdk-java.yml:1021 — [review] MySQL stage labels are pinned by no test: a stale sdk-java install label or a renamed mysql integration suite reds nothing and mislabels a MySQL failure
— deepseek-v4.1-flash-1017@1f214e4e via Qwen Code /review (v0.26.7)
|
autofix round — 2026-11-05: MySQL lane red again after re-run — needs a human decision
This is a known main-side test-fixture defect, not something this PR introduced: #16405 ("[Test] Publication lifecycle fixture misses the tenant guard it waits for") is open for exactly this fixture, and this PR changes no Java code. It is the second distinct Java fixture failure seen on this PR's lanes in two days (#16265's Decision for a maintainer: wait for #16405 (and #16265) to be fixed and let the lane go green on a later head, or merge accepting these known main-side fixture flakes (risk call). The watch will not modify the Java fixtures (out of this PR's scope) and will not spend another re-run at this head. Two fresh approvals at 中文说明autofix 轮次 — 2026-11-05:MySQL 通道重跑后再败——需要人工决定
这是已知 main 侧测试夹具缺陷,非本 PR 引入:#16405 正是该夹具的跟踪 issue(fixture 缺 tenant guard),且本 PR 不改 Java 代码。这是两天内该 PR 通道上第二个不同的 Java 夹具失败(另一个为 #16265 的 WorkspaceMigrationMySqlIT)——managed-agent 套件在 main 上目前不稳定。 请维护者决定: 等 #16405(及 #16265)修复后在后续 head 转绿,或接受这些已知 main 侧夹具 flake 直接合并(风险判断)。监视不会修改 Java 夹具(超出本 PR 范围),也不再消耗本 head 的重跑额度。 |
qwen-code-review-bot
left a comment
There was a problem hiding this comment.
Reviewed.
1 Suggestion-level finding(s) this review confirmed are already reported on this PR and are not repeated:
- D22-3 failed-checkout stage label — already reported (round 21 deferral 'MySQL stage labels are pinned by no test …'; round-15 closeout item 'the MySQL cd-deferral/stage-label pins')
Not explored to full depth (tool budget reached): "agent reverse-audit (round 5)": did not execute the vitest suites ( scripts/tests/sdk-java-workflow.test.js , sdk-java-lock.test.js , main-ci-failure-issue-workflow.test.js ) or a real floc….
Not fully linted (tool limitation, not a blocker): .github/workflows/sdk-java.yml — actionlint ran workflow-level checks; embedded run: shell deferred (source mapping not yet supported).
Deferred under the convergence posture (round 22, not a blocker) — recorded, not requested in this round:
.github/workflows/sdk-java.yml:302 — [review] Seed nests the host cache at m2-repo/repository when RUNNER_TEMP survives a previous job, so the seed silently stops warming Maven (fix: cp -aln SRC/. DST/).github/workflows/.size-baseline:63 — [review] Entry records 162545 for a 162758-byte sdk-java.yml (213 over, inside the 4096 allowance), while the design doc claims re-measurement after the last edit
— deepseek-v4.1-flash-1017@1f214e4e via Qwen Code /review (v0.26.8)
|
🕐 Review received — an automatic review of the current head is still running, so this round is held until it lands (a push now would cancel it and discard its work, #8888). Your feedback stays queued for the next eligible round. 中文说明🕐 已收到评审 —— 当前 head 上仍有一轮自动 review 在运行,本轮暂缓(现在推送会取消该 review 并丢弃其工作,#8888)。反馈保持排队,等待下一次可运行的轮次处理。 |
qwen-code-review-bot
left a comment
There was a problem hiding this comment.
Not reviewed: build-and-test — the SDK Java lanes that run this workflow were skipped in CI at this head (tier resolved to none), so the real-pool behaviour of the changed seed, prune and write-back was not exercised; the suites that pin their text did run green locally.
Not explored to full depth (tool budget reached): "agent 6b": did not execute scripts/tests/sdk-java-workflow.test.js , scripts/tests/sdk-java-lock.test.js or scripts/tests/main-ci-failure-issue-workflow.test.js under….
Not fully linted (tool limitation, not a blocker): .github/workflows/sdk-java.yml — actionlint ran workflow-level checks; embedded run: shell deferred (source mapping not yet supported).
Deferred under the convergence posture (round 23, not a blocker) — recorded, not requested in this round:
.github/workflows/sdk-java.yml:311 — [review] the seed prune is silent when it cannot delete a hardlinked resolver marker, so the unlocked Maven run can still rewrite the host cache through it.github/workflows/sdk-java.yml:469 — [review] the two new write-back prelude arms bypass lock_setup_fault, and the cd arm's warning names no causescripts/tests/sdk-java-workflow.test.js:501 — [review] the new marker-set test duplicates the neighbouring pin and adds a third copy of the seven-name literal
— deepseek-v4.1-flash-1017 via Qwen Code /review (v0.26.8)
|
Verdict: merge-ready — 122/122 scripted assertions passed across 46 replay cells (23 scenarios × 2 arms), the Linux guard suites, a 26-test non-vacuity cross-run, and a 24-row mutation matrix (16 suite kills + 4 harness kills + 2 adjudicated survivors + 2 adjudication rows). Verified head 中文摘要结论:merge-ready(122/122 断言通过;上一轮两条非阻塞建议复测仍在,均为作者已记录的延期项;无新阻塞)。 增量分类:上轮已验 head A/B 结论(两臂同一份逐字提取的
复测上轮两条建议(仍在,非阻塞):S1 缺失 checkout 时注解仍写成上一成功阶段 CI: 未覆盖:真实 Maven 解析语义(桩模拟)、hosted 车道 seed/actions.cache 执行路径(静态四站点计数+套件钉住)、Windows、真实 pool 的受控 A/B。 Previous-round statusThe newest substantive earlier round is the 2026-10-31 Linux verification at
Delta classification (why a full re-run)Between Central claim and A/BThe claim this head is held to: a failed sdk-java Maven suite still reaches the cache write-back and the step keeps Maven's status with a stage annotation; cache setup faults demote to the suite result; the write-back publishes only the job-local delta with all seven mutable name classes excluded and all 16 in-house coordinates pruned; the seed stays best-effort, observable, and clears inherited single-link resolver state; a red MySQL leg waits only the 300 s copy budget. Both arms ran the verbatim
Lock ordering held in every cell that took a lock on either arm: the first FindingsNo new blocking finding. The two previous Suggestions stand, re-measured at this head; both are recorded deferrals under the repository's post-five-round convergence rule, and this round agrees with the non-blocking severity. S1 (Suggestion, stands) — missing-checkout annotation names the previous stageRe-measured on both lanes: with no S2 (Suggestion, stands) — the seed prune failure is silentRe-measured: with an undeletable seed entry, both lanes reach Maven (exit 0, full calls) and the marker survives in the job-local copy as an nlink-2 hardlink of the host file with zero warnings, while the sibling Nits
Mutation matrix (24 rows, all executed)Baseline control: the unmutated head workflow runs the guard file through the exact mutation runner as 143 passed, and the m0 control (final Coverage is claimed per-guard over the effective diff, not per-commit: since the previous verified head the PR authored no production commits (merge resolutions only), so a per-commit enumeration would be empty and prove nothing. Non-vacuityThe head's three changed test files were copied verbatim onto the base production workflow (vac-tree): 26 tests went red (525 passed), all in CI at this head
The same-run shard-3 control is the attribution evidence: one code, three hosts, the two hz2 hosts fail with a runner-level page-load signature while hz3 passes. The diff touches no web-shell file. Main's own ci.yml runs skip the smoke lane, so no main-side comparison was available; the within-run control stands in its place. Round-23 review arrived during this round (review 5799105222, COMMENTED, downgraded from Approve citing the two smoke reds above). Its "not reviewed" note says the SDK Java lanes were skipped at this head ("tier resolved to none") — the job's step ledger corrects that: the fast tier ran the self-hosted test step on a pool host for 23 minutes; what was skipped is the full-tier MySQL lane. Its three deferred probes map onto this round's measurements: (1) the silent seed prune is S2 above, re-measured; (2) the two write-back prelude arms inline their warn-and-exit instead of calling Not covered
MethodologyIsolation: Evidence— qwen-latest-series-invite-202610-m6@e6bf8ffe via Qwen Code /verify-pr (v0.26.8; skill c5273cc80df5) |
Co-authored-by: Qwen-Coder <qwen-coder@alibabacloud.com>
54edbe3
|
Verdict: merge-ready — 123/123 scripted assertions passed at the new head: 46 replay cells re-run, Linux guard suites green, the 26-test non-vacuity cross-run still red on base production, and the 24-row mutation matrix reproduced (16 suite kills + 4 harness kills + 2 adjudicated survivors). Verified head 中文摘要结论:merge-ready(123/123 断言;自上轮已验 head 以来 PR 零自有提交,两条延期建议仍在,r2 的基线小疵已消除)。 增量分类: 重测结果(与 r2 逐格一致):46 格回放全翻转如预期——失败 MySQL 套件写回 1/2 个文件并保持状态与阶段注解;缓存故障不改写套件结果;7 类可变名全排除;继承单链接状态 head 清 7 种/base 留 3 种;元数据硬链接改写被挡;持锁实测红腿 wait=300、绿腿 5400。门禁 head 552/553、base 529/530(各 +1 是 main 新步骤的 pin);head 测试对 base 生产码仍 26 条红。变异基线 144 绿,16 杀 + m6(冗余防御)/m12(承重无测试,作者延期项)由 harness 仲裁。 两条建议复测仍在(非阻塞):S1 缺失 checkout 注解仍指上一成功阶段;S2 seed 剪枝失败仍静默(nlink=2 存活、0 warning)。r2 基线小疵已修:165241 记录 = 165241 实测,精确相等。 CI:此 head 0 失败(28 过 / 4 pending / 18 跳过)——r2 的两条 smoke 红在此 head 不再失败,佐证 hz2 主机归因。wenshao 在旧 head 的批准被 head 前进按过期 dismiss,需在新 head 重新批准(流程状态,非发现)。 Previous-round statusThe previous round is r2 at
Delta classification
Main-side closure changes since the r2 base: sdk-java.yml +48 lines — a new independent A/B and gates (all re-run at this head)Same rig as r2: verbatim-extracted
CI at this head0 failures: 28 pass / 4 pending / 18 skipping at report time. The two r2 smoke reds (shards 2/4 and 4/4, attributed to the hz2 hosts via the same-run shard-3 control) are no longer failing at this head — shards 3/4 and 4/4 passed, 1/4 and 2/4 pending. Pending: the two smoke shards, review-pr, and Review state (process, not a finding): the head advance dismissed wenshao's approval on Not coveredUnchanged from r2: real Maven resolver semantics (stub simulates the in-place rewrite; measured with real Maven in the 10-25 round); hosted-lane seed execution and actions/cache (shape-pinned by the suite, not executed); the pool as a controlled A/B (the green ubuntu lane is one real-infrastructure pass); Windows; the two prose deferrals; existing-destination seed nesting (owned by #15286, both arms). Main's new tool-cache step is base behavior on both arms and outside this PR's delta; its pins ran green in the head gate. MethodologyRound artifacts: Evidence— qwen-latest-series-invite-202610-m6@e6bf8ffe via Qwen Code /verify-pr (v0.26.8; skill c5273cc80df5) |
|
CI attribution at 中文摘要CI 归因(head
Evidence
Action taken: re-ran the failed jobs of run 42256680321 (attempt 2, no code change). The aggregation gate re-evaluates after the shards. Result will be noted here once settled. — qwen-latest-series-invite-202610-m6@e6bf8ffe via Qwen Code /verify-pr (v0.26.8; skill c5273cc80df5) |
qwen-code-review-bot
left a comment
There was a problem hiding this comment.
No blocking issues. LGTM! ✅
Not fully linted (tool limitation, not a blocker): .github/workflows/sdk-java.yml — actionlint ran workflow-level checks; embedded run: shell deferred (source mapping not yet supported).
Deferred under the convergence posture (round 24, not a blocker) — recorded, not requested in this round:
.github/workflows/sdk-java.yml:314 — [review] seed nests into an existing m2-repo; warm cache unreachable.github/workflows/sdk-java.yml:320 — [review] seed prune silent; comment contradicts the test comment.github/workflows/sdk-java.yml:366 — [review] checkout failure misattributed to a passed Maven suite.github/workflows/sdk-java.yml:1152 — [review] stale 'Maven already passed' premise in the mysql write-backscripts/tests/sdk-java-workflow.test.js:381 — [review] byte-identity test neutralized by a two-sided no-opscripts/tests/sdk-java-workflow.test.js:1361 — [review] seeded-alias assertion is vacuous without a seed-landed…scripts/tests/sdk-java-workflow.test.js:1529 — [review] checkout guard unpinned; mutation survivesscripts/tests/sdk-java-workflow.test.js:3009 — [review] mysql stage names unpinned
— deepseek-v4.1-flash-1017 via Qwen Code /review (v0.26.8)
|
…n-hook main advanced 11 commits (stacked-skill overflow #16404, workflow agent approvals #16432, daemon UI tool blocks #16306, sibling model settings #15829, late snapshot publication claim #16489, inline FQN imports in runtime modules #16504, cancelled shell as interrupted #15836, CSI statement helper fold #16503, Maven suite cache write-back #15274, sed char match #15701, Ink TUI tool-batch round #16428). One conflict, the workflow size ratchet: - .size-baseline: sdk-java.yml auto-merged to 167124 bytes (HEAD recorded 161927 / main 165241, both below the combined actual), so record the actual merged size 167124 per the ratchet's "record the real size in the same PR" rule. The absolute gate (470000) and the 4096-byte baseline allowance both pass. No source conflict: main's commits did not touch this branch's A3 source files, so RuntimeBrokerService / RuntimeExecutionRecovery (R18-1/R19-1 observe-only mount-handback guard) and the cli serve fence are unchanged. Verification: check-workflow-size.sh green (bash5); workflow meta tests (workflow-size + sdk-java-workflow + hosted-process-ci) 428 green; workspace build and ClassSizeRatchetTest re-run after the merge.
|
Released in v0.27.0. |
|






What this PR does
This PR hardens the SDK Java Maven cache path after the suite/write-back lock split. Failed MySQL integration suites can still publish downloaded artifacts while preserving the original suite status, cache setup failures preserve the already-known suite result, and the final error annotation identifies the failed Maven stage. Cache seeds report copy failures, tolerate an unavailable cache or failed best-effort prune, and detach mutable resolver metadata before Maven runs — including single-link resolver state inherited from a previous job, since RUNNER_TEMP persists across jobs on the self-hosted pool. Write-back excludes the same metadata and partial-download files.
Why it's needed
The lock relocation associated with #15262 already landed on main through #15128 and #15254. This branch is the remaining hardening delta: a failed suite should not throw away reusable downloads, a best-effort cache operation should not replace the suite result, and mutable resolver state should not be published as an immutable shared artifact. The test repair in 11c0f4b also includes the deferred-status reporter in extracted shell snippets so those tests can exercise their intended paths.
Reviewer Test Plan
How to verify
resolver-status.properties/x.jar.lastUpdateddirectly in${RUNNER_TEMP}/m2-repobefore the seed body runs. The seed prune must delete both while the host-cache peers stay intact. Restoring-links +1to the seed prunes must red theclears inherited single-link resolver state from the job-local repositorywitness.Evidence (Before & After)
Head
26960a72d1merges maina5fec03684into89d3898f4d; the PR delta is unchanged (the same seven files, 1116 insertions / 198 deletions), and the merged workflow's.size-baselineentry is re-recorded to 162545. Earlier measurements below are labeled with the commit they were taken at; the four required suites were re-run after this merge. Prior heads:a0d162dbcc(main90eb13e4c6),d0f6312b82(main91a6274075),7618d49a(mainfe30b5daaa).--testTimeout=30000; no test modified)-links +1at the four seed prunesinherited single-link marker survived the seed prune: expected true to be false); fix restored, green. Re-killed on Linux as row m5b at 7618d49.size-baselinesdk-java.yml entrygit show HEAD:.github/workflows/sdk-java.yml | wc -c(159271 at a0d162d)git diff --checkpreviews qwen3.8-max reasoningflake). CI re-runs at the merged headThe 47 macOS skips are the file's Linux-only behavioral pins; the maintainer's Linux round executes them (142/142), so the macOS counts alone do not certify the changed behavior — the Linux verification does. The new inherited-state witness is cross-platform and ran on both systems. Prior Linux A/B and real-pool reports remain historical evidence at their recorded heads.
Tested on
Current closeout
Round of 2026-10-31 (local takeover after the AutoFix loop reached its round cap): merged main
812a8c7ccb, resolving the write-back conflicts semantically — main's nine-coordinate prune list (from the #15871 Maven-module split) plus this PR's seven-name! -nameexclusions, with the matching test pins moved along — and fixed R13-1 by dropping-links +1from all four seed prunes so inherited single-link resolver state is cleared again; the write-backs'-links 1delta filter is unchanged. Both design-doc languages are synchronized and.size-baselineis re-recorded to the exact byte count. Unlike the previous static-only closeout, this round ran the suites and the mutation locally (evidence table above). The merge-order decision R2-6 asked for is recorded: this PR is the chosen landing PR of the family; #15275, #15284 and #15233 are closed, #15254 merged, and #15286 remains the separately owned follow-up.Later on 2026-10-31: the maintainer merged current main (
7618d49a, PR files untouched) and published an independent Linux verification at that head — verdict merge-ready, 61/61 assertions, 18/18 mutations killed. One non-blocking Suggestion from that report is deferred and recorded here per the repository's post-five-round convergence rule: when themanaged-agent-servercheckout is missing, the deferred-failure annotation names the previous successful Maven stage instead of the checkout (both lanes). The report carries a measured minimal fix (setmvn_stagebefore thecd; the test pin countingmvn_stageoccurrences must move with it). It is follow-up work, not a merge blocker; the deferral is recorded so nothing is silently dropped.2026-11-01: merged main
91a6274075(d0f6312b82) to clear the base conflict, keeping main's Hosted-admission change (#16010) alongside this PR's hardening; delta unchanged, baseline re-recorded (155529), required suites re-run green. At7618d49aCI was fully green (including the full SDK Java tier on the real pool) and the PR held two maintainer approvals (wenshao, yiliang114); CI re-runs at the merged head, and stale-approval dismissal rules may require the two approvals to be refreshed. No review thread is unresolved.2026-11-02: the maintainer merged main once more (
702da7a21a, merging60f5c1ed95); the PR delta is unchanged apart from main-side comment edits insidesdk-java.yml, which now measures 156105 bytes while.size-baselinestill records 155529 — a 576-byte record nit the CI size check tolerates, to be re-recorded with the next content change. All checks at this head are green, including the re-runreview-prwhose round-15 review posted zero findings. The two approvals from7618d49awere dismissed on push by the stale-approval rule; the PR is MERGEABLE and now waits on two fresh maintainer approvals at702da7a21a. The round-15 deferred items stay recorded follow-ups: the baseline record, the MySQLcd-deferral/stage-label pins, the classifier fixture's lock-wait line, and the MySQL write-back comment wording.2026-11-03: merged main
90eb13e4c6(a0d162dbcc) to clear the new base conflict, keeping main's optional-runtime-backend Maven modules (#16141) alongside this PR's hardening; delta unchanged,.size-baselinere-recorded to 159271 (which also clears the 576-byte nit above), and the four required suites re-run green (502 passed | 47 skipped) plus the wider ten-suite set (743 passed | 47 skipped). CI re-runs at the merged head; the two approvals must be refreshed ata0d162dbccsince every push dismisses the previous ones.2026-11-04: merged main
a5fec03684(26960a72d1) to clear the new base conflict, keeping main's disk-exhaustion guards (#16068) alongside this PR's hardening; delta unchanged,.size-baselinere-recorded to 162545, four required suites re-run green (505 passed | 47 skipped) plus six other parsers (241 passed | 0 skipped) and triage (191 passed | 10 skipped). The two web-shell smoke failures before the merge were the SSE-handshake race on a busy pool host and were re-run; the push briefly hit a GitHub-side Internal Server Error during the day's minor outage and succeeded after a short wait (the watch's worktree now pushes over HTTPS withgh auth git-credential, GitHub SSH having refused connections since this morning). CI re-runs at the merged head; two fresh approvals needed at26960a72d1.2026-11-07: merged main
cb282ef5cfe(54edbe30b9a) to clear the new.size-baselineconflict, keeping the runner-local Java tool-cache repair from main alongside this PR cache hardening. The effective PR delta is unchanged: the same seven files with identical per-file addition/deletion counts (1116 insertions / 198 deletions)..size-baselineis re-recorded to 165241, exactly the merged workflow byte count. The four required suites re-run green (506 passed | 47 skipped), six other sdk-java.yml parsers pass (242/242), the new Java tool-cache suite passes (8/8), and prettier plusgit diff --checkare clean. The latest independent Linux verification atf4981199200acovers the identical PR delta and reports merge-ready with 122/122 assertions; PR CI at54edbe30b9acompleted with 48 passing and 35 skipped checks: one substantive red lane remains, full-tier Hosted process fault gates, plus its aggregate. The failures are two test assertions, not a Maven build failure:HostedPublicWorkspaceIT.structuredQuestionSurvivesJavaAndHarnessRestartandHostedWorkspaceToolTurnIT.recordsLatencyWithDelayedRuntimeProvisioning. Both also failed in independent PR #16469 full-tier run42242651788on shared ancestor7cb46d9fed; the shared regression is tracked by #14724. No PR-specific regression was identified, no unrelated Java change was added here, and no speculative 97-minute retry was launched. Fresh approvals are required after this push.Risk & Scope
The host cache remains best-effort. Failure to seed can increase network resolution. An unexpected bare-flock failure remains fatal. Real Maven resolver behavior and contention on the self-hosted pool require CI evidence beyond shell fixtures. The seed prune now also deletes inherited single-link markers in the job-local repository; deleting a job-local hardlink never removes the host peer.
#15286 contains distinct follow-up work: existing-destination seed nesting, removal of old in-house artifacts from the host cache, self-hosted Checkstyle repository selection, and reference-release cache isolation. Those changes remain separately owned. Shared-helper and test-fixture extraction are deferred rather than widening this repair.
Related to #15262; the original lock relocation is already on main.
Latest repair
c7746613ecclears inherited resolver state in the Maven cache seed prune (R13-1): the four seed prunes drop-links +1, thedeAliaspin moves with them, and a cross-platform regression witness plants nlink-1 markers before the seed body — mutation-verified red (exit 1) with-links +1restored and green with the fix. The previous repair (300-second failed-MySQL wait clamp, metadata checksum sidecar and partial-download exclusions) is unchanged.