Repository navigation
refactor: snake_case the dotted arguments of the community, HRG, motif and graphlet functions - #2948
Open
schochastics wants to merge 22 commits into
Open
schochastics wants to merge 22 commits into
schochastics wants to merge 22 commits into
Conversation
…patch/` (#2934) Co-authored-by: Claude <noreply@anthropic.com>
…r's series loop does (#2935) Co-authored-by: Claude <noreply@anthropic.com>
…2936) Co-authored-by: Claude <noreply@anthropic.com>
…f and graphlet functions Count prefixes follow the `n` convention (`nb.trials` → `n_trials`, `num.samples` → `n_samples`, `no.of.communities` → `n_communities`), and `graphlet_proj(Mu)` becomes `mu`. Legacy names are recovered with a soft-deprecation. Part of #2788. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
This was referenced Oct 15, 2026
Contributor
|
This is how benchmark results would change (along with a 95% confidence interval in relative change) if e48f965 is merged into claude/issue-2788-subagents-faw1t1-11:
|
Co-authored-by: krlmlr <krlmlr@users.noreply.github.com>
…ing's setup (#2949) Co-authored-by: Claude <noreply@anthropic.com>
…edit is vendored (#2956) Co-authored-by: Claude <noreply@anthropic.com>
… them (#2957) Co-authored-by: Claude <noreply@anthropic.com>
Co-authored-by: Claude <noreply@anthropic.com>
Co-authored-by: krlmlr <krlmlr@users.noreply.github.com>
…s fixes in front of the vendor commits (#2959) Co-authored-by: Claude <noreply@anthropic.com>
…-no-push-dev` (#2961) Co-authored-by: Claude <noreply@anthropic.com>
… upstream function (#2966) Co-authored-by: Claude <noreply@anthropic.com>
…s-land.sh --review --series` (#2970) Co-authored-by: Claude <noreply@anthropic.com>
#2967) Co-authored-by: Claude <noreply@anthropic.com>
…d input `igraph_match_arg()` eagerly computed `rlang::caller_arg()` and went through `rlang::arg_match()` on every call, costing ~19 us even when the value is valid. It now returns early for the two cases `arg_match()` accepts (the untouched default, or a single exact match) and only pays for the error machinery when it has to report one. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of #2788 (PR 12 of the stack, on top of #2947). It continues the snake_case sweep for
R/community.R,R/hrg.R,R/motifs.RandR/glet.R, and settles theMuquestion from the thread (no case-sensitive argument names, soMu→mu).What this does
cluster_spinglass():start.temp,stop.temp,cool.fact,update.rule,gamma.minus→ snake_casecluster_fluid_communities():no.of.communities→n_communitiescluster_edge_betweenness():edge.betweenness→edge_betweennesscluster_infomap():nb.trials→n_trialsconsensus_tree(),predict_edges():num.samples→n_samples,num.bins→n_binsmotifs(),count_motifs(),sample_motifs():cut.prob→cut_prob,sample.size→sample_sizegraphlet_proj():Mu→muCount prefixes (
no.of.,nb.,num.) follow thenconvention, as in #2946.All are pure registry renames except
cluster_fluid_communities(), which takes its head argument through a trailingdeprecated()sentinel. The deprecated wrappers (spinglass.community(),graph.motifs(),hrg.predict(), …) are untouched and forward the old names through the recovery.graphlets()still returns its weights as$Mu. That is a return-value element, not an argument, so it is out of scope.Tests
There are table-driven
expect_legacy_arg()tests for every rename.same_result()in the helper now compares classed lists such ascommunitieselement by element, becauselength.communities()counts communities, not list elements.The #2788 stack
Each PR is based on the previous one and merges in this order:
algotoalgorithminpage_rank(),feedback_arc_set()andfeedback_vertex_set()#2859:algo→algorithmnodestonin generators andcentr_*_tmax()#2860:nodes→n(vertex counts)cluster_infomap()#2861: weights argumentsnormalized#2862: normalization flags →normalizedverticesandvertex#2864: selectors →vertices/vertexedges#2943: edge selectors →edgesindextovertices/edgesin the attribute accessors #2944: attribute accessors:index→vertices/edgesn_iter/max_iter#2945: iterations →n_iter/max_iterMu→mu) ← this PRalgorithmand measure selection tomeasure#2951: algorithm family →algorithm/measure(closes Algorithm-selection argument names: census ofmethod/algorithm/algo/impl/implementation#2932)🤖 Generated with Claude Code