Skip to content

Fix several back-quote related formatting issues and typos - #48

Closed
liancheng wants to merge 2 commits into
jmespath:masterfrom
liancheng:fix-back-quote-format
Closed

liancheng wants to merge 2 commits into
jmespath:masterfrom
liancheng:fix-back-quote-format

Conversation

@liancheng

@liancheng liancheng commented Mar 17, 2018 •

Copy link
Copy Markdown
Contributor

This PR:

  • Fixes a few formatting issues and typos related to back-quotes
  • Mark all example output values in the specification as inline literals.

@liancheng
liancheng force-pushed the fix-back-quote-format branch from ba7b5dd to 225c04b Compare March 17, 2018 00:43
@liancheng
liancheng force-pushed the fix-back-quote-format branch from 225c04b to 51894e5 Compare March 17, 2018 00:53
@liancheng liancheng changed the title Minor formatting fix Fix several back-quote related formatting issues and typos Mar 17, 2018
Comment thread docs/specification.rst
character must now be escaped in a ``json-value`` which means implementations
need to handle this case before passing the resulting string to a JSON parser.
use an existing JSON parser to parse literal values. Note that the
:literal:`\`` character must now be escaped in a ``json-value`` which means

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unfortunately, the inline-literal markup (``...``) doesn't respect back-slash for escaping purposes while the :literal: role does.

Comment thread docs/specification.rst
- "a, b"
* - ``["a", "b"]``
- ``join(````, @)``
- :literal:`join(\`\`, @)`

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Similarly, using the :literal: role here so that we can escape the back-quotes.

springcomp referenced this pull request in jmespath-community/jmespath.site Feb 19, 2022
springcomp pushed a commit to springcomp/jmespath.site that referenced this pull request May 25, 2022
@springcomp springcomp mentioned this pull request May 25, 2022
jamesls added a commit that referenced this pull request May 25, 2022
PR #98.

* feature/typos:
  Revert "[vladik-hbinov] #79 Moved the example jmespath-input json above the expression"
  Fixed typo.
  Fixed typo.
  [liancheng] #48 Fix several back-quote related formatting issues and typos
  Reordered implementation libraries alphabetically.
  [mdavis-xyz] #89 Fix typos in slicing tutorial
  [gpacix] #66 Fix "count" to "length"
  [oliver-gondza] #69 Update wording of the examples page
  [vladik-hbinov] #79 Moved the example jmespath-input json above the expression
  [brlin-tw] #84 Fix typo
  [pmarkert/patch-1] #90 Update tutorial.rst
  Fixed typo in libraries page.
@jamesls

jamesls commented May 25, 2022

Copy link
Copy Markdown
Member

Merged in #98.

@jamesls jamesls closed this May 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants