Skip to content

Feature/typos - #98

Merged
jamesls merged 12 commits into
jmespath:masterfrom
springcomp:feature/typos
May 25, 2022
Merged

jamesls merged 12 commits into
jmespath:masterfrom
springcomp:feature/typos

Conversation

@springcomp

Copy link
Copy Markdown
Contributor

Fixes:

#48
#66
#69
#79
#84
#89
#90

@springcomp springcomp mentioned this pull request May 25, 2022
…json above the expression"

This reverts commit 9eab207.

This is personal preference, but I'd prefer the JMESPath expression be
at the top as it's the main focus of the page.  It also makes it
consistent with the format used in later examples where there's a
side by side column representation.

@jamesls jamesls left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, looks great. Had a small comment about a change I'm going to make but otherwise thanks for doing this!

Comment thread docs/_templates/index.html Resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

9 participants