Skip to content

Moved the example jmespath-input json above the expression - #79

Closed
vladik-vitre wants to merge 3 commits into
jmespath:masterfrom
vladik-vitre:master
Closed

vladik-vitre wants to merge 3 commits into
jmespath:masterfrom
vladik-vitre:master

Conversation

@vladik-vitre

Copy link
Copy Markdown
Contributor

The expression field should be under the example json because it's based on it

springcomp referenced this pull request in jmespath-community/jmespath.site Feb 18, 2022
springcomp pushed a commit to springcomp/jmespath.site that referenced this pull request May 25, 2022
@springcomp springcomp mentioned this pull request May 25, 2022
jamesls added a commit to springcomp/jmespath.site that referenced this pull request May 25, 2022
…json above the expression"

This reverts commit 9eab207.

This is personal preference, but I'd prefer the JMESPath expression be
at the top as it's the main focus of the page.  It also makes it
consistent with the format used in later examples where there's a
side by side column representation.
jamesls added a commit that referenced this pull request May 25, 2022
PR #98.

* feature/typos:
  Revert "[vladik-hbinov] #79 Moved the example jmespath-input json above the expression"
  Fixed typo.
  Fixed typo.
  [liancheng] #48 Fix several back-quote related formatting issues and typos
  Reordered implementation libraries alphabetically.
  [mdavis-xyz] #89 Fix typos in slicing tutorial
  [gpacix] #66 Fix "count" to "length"
  [oliver-gondza] #69 Update wording of the examples page
  [vladik-hbinov] #79 Moved the example jmespath-input json above the expression
  [brlin-tw] #84 Fix typo
  [pmarkert/patch-1] #90 Update tutorial.rst
  Fixed typo in libraries page.
@jamesls

jamesls commented May 25, 2022

Copy link
Copy Markdown
Member

Addressed in #98.

@jamesls jamesls closed this May 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants