[cchu-ld]

Requirements

• I have added test coverage for new or changed functionality
• I have followed the repository's pull request submission guidelines
• I have validated my changes against all supported platform versions

Related issues

None.

Describe the solution you've provided

• Problem: The plaintext status output showed the full ARN of each IAM role. The ARN did not tell you if the role was ready.
  • Solution: Each role shows its name and a state.
• Problem: Each association showed only a service ID and a raw state, such as pending-confirmation. You could not see which service it was.
  • Solution: Each association names its service, for example AWS account 123456789012 or the MCP server name. The state is in plain words, such as ready or waiting for confirmation.
• Problem: If nothing was set up, the output listed missing roles and gave no next step.
  • Solution: The output says Nothing is set up and names the setup command. It says that only if the account has no roles, no registered services, and no agent spaces, so a registered MCP server still shows.
• Problem: An agent space can read other AWS accounts. Each of those associations has the service ID aws, so a label from the service ID alone named the wrong account.
  • Solution: status reads the account ID and the account type from the configuration of each AWS account association. Another account shows as Source AWS account <id>.
• Problem: Service types such as github or remoteagentsigv4 showed as AWS sends them.
  • Solution: Each service type that the SDK knows has a plain name, for example GitHub. Each MCP server type is MCP server. An unknown type shows as AWS sends it.
• Problem: Scripts read the JSON output, so its fields must not change.
  • Solution: No JSON field changes. The JSON output adds accountId and accountType to each AWS account association.
• The plaintext output does not show association IDs, because no aws-devops-agent command takes one. The JSON output still has them.

Describe alternatives you've considered

None.

Additional context

Testing: go test ./... and golangci-lint pass on this branch.

🤖 Generated with Claude Code

---

Note

Overview
Improves human-readable ldcli aws-devops-agent status by restructuring plaintext output into sections (IAM roles, services, agent spaces) with ready/missing role states instead of ARNs, friendly service labels (including MCP servers and multi-account AWS links), and plain-language association states (e.g. waiting for confirmation). When nothing is provisioned—or there are no agent spaces—it points users at ldcli aws-devops-agent setup.

Status data from AWS now populates accountId / accountType on AWS (aws) associations so monitor vs source accounts can be distinguished in output; JSON mode still uses the same printJSON path but association objects can include those optional fields (covered by fixture tests). Broad unit tests lock plaintext formatting and JSON shape.

^{Reviewed by Cursor Bugbot for commit 17e3475. Bugbot is set up for automated code reviews on this repo. Configure here.}

[cchu-ld]

bugbot run

[ffantl-ld]

The status code is correct, but three faults pass every test in cmd/aws_devops_agent and internal/awsdevops. I tried each one in a worktree.

1. Replace the empty-account condition at status.go:63 with if false. Tests pass. TestStatusEmptyNamesSetupCommand checks for the setup command, the account ID, and the console URL, but the "No agent spaces. Run ldcli aws-devops-agent setup." line also has them. Suggest: assert "Nothing is set up" and assert that "IAM roles:" is absent.
2. Change anyRole (status.go:59-62) to "all roles exist". Tests pass. No test has one role ready with no services and no spaces. With this fault, a half-finished setup prints "Nothing is set up" and hides the role. Suggest: a test with roles [ready, missing] and nothing else.
3. Make plainState return "" for pending-confirmation, or return the raw value for invalid. Tests pass. TestStatusAssociationShowsPlainState only asserts that the raw words are absent. Suggest: assert "waiting for confirmation", and add invalid and empty cases.

[cchu-ld]

Thank you. Commit 68672dd4 adds tests for all three faults. I ran each fault again, and each one now fails a test.

1. TestStatusEmptyNamesSetupCommand now asserts "Nothing is set up. Run ldcli aws-devops-agent setup." and asserts that "IAM roles:" is absent.
2. TestStatusOneRoleShowsTheRoles has roles [ready, missing] and nothing else. It asserts that "Nothing is set up" is absent and that each role shows its state.
3. TestStatusAssociationShowsPlainState now asserts "waiting for confirmation". TestStatusPlainStateNamesEachState covers valid, invalid, pending-confirmation, an empty state, and an unknown state.

This reply is from Claude.

[Andrewjeska]

Two notes from a pass through this PR — both minor but worth catching before it lands.

1. serviceLabel misses the vendor-specific MCP server enums

Besides mcpserver, the SDK enum includes mcpservernewrelic, mcpserverdatadog, mcpserversplunk, mcpservergrafana, mcpserversigv4. They'll render as e.g. "LaunchDarkly mcpservernewrelic (s-ld01)". Consider strings.HasPrefix(kind, "mcpserver") → "MCP server", or a small map, so added vendor-specific service types don't leak the enum string.

2. The JSON golden fixture skips the two fields most likely to be edited

The testdata/status.json fixture leaves operatorAppEnabled and missingSetup at zero values. Those are the two JSON fields most likely to be edited in a follow-up PR. The test — whose stated purpose is to lock the JSON shape — won't notice if someone renames or re-tags either. Either add a second fixture that sets OperatorAppEnabled: true and a non-empty MissingSetup, or extend realisticStatus() so this one does.

via LD Research 🤖

[cchu-ld]

@Andrewjeska, thank you. Commit 68672dd4 addresses both points.

1. serviceLabel now uses strings.HasPrefix(kind, "mcpserver"), so each vendor type is "MCP server". The service name tells the vendor, for example "Datadog MCP server (s-ld01)". TestStatusVendorMCPServerHasPlainLabel covers mcpserverdatadog.
2. TestStatusJSONUnchanged now has a second fixture, testdata/status-partial.json. It is a setup that did not finish, with one missing role and a non-empty missingSetup. operatorAppEnabled comes in feat: read agent space ownership and operator app state #927, and testdata/status.json sets it to true there. Commit 57bbce97 on feat: read agent space ownership and operator app state #927 adds "operatorAppEnabled": false to the partial fixture, so the test covers both values.

This reply is from Claude.